From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 677D3EB64D8 for ; Wed, 14 Jun 2023 21:51:14 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7AADB861DE; Wed, 14 Jun 2023 23:51:11 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="NhXYiZdF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id D4FE4861E2; Wed, 14 Jun 2023 23:51:09 +0200 (CEST) Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 863FE85F9F for ; Wed, 14 Jun 2023 23:51:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=bigunclemax@gmail.com Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-30fc2b44281so3715072f8f.2 for ; Wed, 14 Jun 2023 14:51:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686779466; x=1689371466; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ywdTQhdBqd8AHWeAuobAVs9fzh9ShpkgT0FqWrFACM8=; b=NhXYiZdFoRdvy0wcHgL/8qqjoLeTuO0XYvtDnZA5eAtwR7txW/hZ2CvlW5pH58vNXV 2ldhwr9e6zVUaPdnqmi9hDRg1e7gCu5Wt55v2ev0xP9tTWDN+kFp3mgirVyRl8j592/J JylrW3kqXhcphcSiyiW7lr+cVxy0e+PhUk9cjjaqOqBM+EXR5xaWSFRXrTtJCPp/lOg7 eAbwZqcEGk/QxJ6bc6CWNC7tJIGj4y/4N0oBDdTr7qw6cITfe+gSdtdZDv+0Vr0xPeMN i8O5V9FaS2AfQOe04jhOhRXvKu7PALZavUQ2oReDQHvO03dwnGYrAmTcBXAqmdpGYkHE 2KWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686779466; x=1689371466; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ywdTQhdBqd8AHWeAuobAVs9fzh9ShpkgT0FqWrFACM8=; b=Rb5B6d4P4Ca8MvRUoQmi0gLJLJEFmcxcVX+8DfAQBGMbhQvd9fGsq9fKHE1nl5uZUp ISzQcfGrDKl5K7lCK0ngzvLLGFGVWR4Oy3cJf6etnEq7HFmmXVom73GMaSq6B0wkBd+W MVu02Bx+Hz3CvIkNmc6nbH9ncDg9mwP9VZFXhS2X5VOoHIm9mD1byGUzmDA0pSDUAao/ fkeY+DEV0otn6ppM2vHFyHntmgXrYj7CumekD0xEl0SJ/nLsQNHrCt5tjdZq95OiacZW ykInGLYt5bfXs65+QjqEZDPdfbtKbkuB2JPQmQ4pnio7/7H4jC2GwvceVG7dKD5+v83b 8+Xg== X-Gm-Message-State: AC+VfDzMPaGPjBo+TTKrS+Siasi2D7DcJjpGFv1BpKbLa55iyLmybEks 1T/rNTyGw0n7x6iHgb53Qmej9SUkVVQ+94el X-Google-Smtp-Source: ACHHUZ4GXlVy7ATCH3j2S0i7pycenFVhW2jipcC1+EbownAXfqZ1cf2XX+MJs2Io+xpwS7HduY02+w== X-Received: by 2002:a05:6000:1282:b0:30f:c6c3:e6d9 with SMTP id f2-20020a056000128200b0030fc6c3e6d9mr7596834wrx.46.1686779466298; Wed, 14 Jun 2023 14:51:06 -0700 (PDT) Received: from user-PC.. ([92.51.95.194]) by smtp.gmail.com with ESMTPSA id e7-20020a056000120700b0030af8da022dsm19245177wrx.44.2023.06.14.14.51.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Jun 2023 14:51:05 -0700 (PDT) From: Maxim Kiselev To: u-boot@lists.denx.de Cc: Maksim Kiselev , Joe Hershberger , Ramon Fried Subject: [PATCH v1] net: sun8i-emac: Add support for fixed-link phy Date: Thu, 15 Jun 2023 00:44:06 +0300 Message-Id: <20230614214405.1038301-1-bigunclemax@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean From: Maksim Kiselev Based on dt-specs fixed-link doesn't require phy-handle to be used. Fix driver to only read phy related setting when phy-handle is found. Signed-off-by: Maksim Kiselev --- drivers/net/sun8i_emac.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/sun8i_emac.c b/drivers/net/sun8i_emac.c index 04c3274fbe..0e339d69e0 100644 --- a/drivers/net/sun8i_emac.c +++ b/drivers/net/sun8i_emac.c @@ -834,11 +834,8 @@ static int sun8i_emac_eth_of_to_plat(struct udevice *dev) priv->use_internal_phy = false; offset = fdtdec_lookup_phandle(gd->fdt_blob, node, "phy-handle"); - if (offset < 0) { - debug("%s: Cannot find PHY address\n", __func__); - return -EINVAL; - } - priv->phyaddr = fdtdec_get_int(gd->fdt_blob, offset, "reg", -1); + if (offset >= 0) + priv->phyaddr = fdtdec_get_int(gd->fdt_blob, offset, "reg", -1); pdata->phy_interface = dev_read_phy_mode(dev); debug("phy interface %d\n", pdata->phy_interface); -- 2.39.2