Re: [PATCH v1 1/4] net: rtl8169: Fix compile warning in rtl8169 network adapter

Ramon Fried
2023-07-22T05:56:15Z

On Wed, Jun 21, 2023 at 12:05 PM Minda Chen <minda.chen@starfivetech.com> wrote:
>
> Fix make pointer from integer without a cast compile warning.
>
> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
> ---
> drivers/net/rtl8169.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c
> index 2276a465e7..dcba51590d 100644
> --- a/drivers/net/rtl8169.c
> +++ b/drivers/net/rtl8169.c
> @@ -96,12 +96,12 @@ static int media[MAX_UNITS] = { -1, -1, -1, -1, -1, -1, -1, -1 };
> #define TX_TIMEOUT (6*HZ)
>
> /* write/read MMIO register. Notice: {read,write}[wl] do the necessary swapping */
> -#define RTL_W8(reg, val8) writeb((val8), ioaddr + (reg))
> -#define RTL_W16(reg, val16) writew((val16), ioaddr + (reg))
> -#define RTL_W32(reg, val32) writel((val32), ioaddr + (reg))
> -#define RTL_R8(reg) readb(ioaddr + (reg))
> -#define RTL_R16(reg) readw(ioaddr + (reg))
> -#define RTL_R32(reg) readl(ioaddr + (reg))
> +#define RTL_W8(reg, val8) writeb((val8), (void *)(ioaddr + (reg)))
> +#define RTL_W16(reg, val16) writew((val16), (void *)(ioaddr + (reg)))
> +#define RTL_W32(reg, val32) writel((val32), (void *)(ioaddr + (reg)))
> +#define RTL_R8(reg) readb((void *)(ioaddr + (reg)))
> +#define RTL_R16(reg) readw((void *)(ioaddr + (reg)))
> +#define RTL_R32(reg) readl((void *)(ioaddr + (reg)))
>
> #define bus_to_phys(a) pci_mem_to_phys((pci_dev_t)(unsigned long)dev->priv, \
> (pci_addr_t)(unsigned long)a)
> --
> 2.17.1
>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>