Re: [PATCH v19 8/9] arm_ffa: efi: introduce FF-A MM communication

Abdellatif El Khlifi
2023-08-07T15:26:46Z

Hi Ilias,

> > Add MM communication support using FF-A transport
> >
> > This feature allows accessing MM partitions services through
> > EFI MM communication protocol. MM partitions such as StandAlonneMM
> > or smm-gateway secure partitions which reside in secure world.
> > ...
> >
> > Changelog:
> > ===============
> >
> > v19:
> >
> > Tom:
> >
> > * use CONFIG_FFA_SHARED_MM_BUF_* in place of macros
> >
> > v18:
> >
> > Ilias, Tom:
> >
> > * drop the use of configs for the shared MM buffer, put back #ifdefs instead
> > * add test information to the commit log
> >
>
> Thanks for the quick rework. I like the fact you have the SMC as a
> fallback to FF-A in case it's not discovered. Once and if we get dynamic
> buffer allocation for the NS-world we can easily switch this to an
> automatically scanable feature again.
>
> Tom, I am fine with the series now. I've reviewed the relevant EFI and asm
> bits, feel free to pull it in if the rest of the people are happy.
>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
>

You're welcome :)

Cheers,
Abdellatif