Re: [PATCH v3 1/4] arm64: smccc: add Xn registers support used by SMC calls

Abdellatif El Khlifi
2022-08-05T11:17:56Z

On Mon, Aug 01, 2022 at 07:41:16PM +0100, Sudeep Holla wrote:
> On Mon, Aug 01, 2022 at 06:20:50PM +0100, Abdellatif El Khlifi wrote:
> > use x0-x17 registers in the SMC32/SMC64 calls according to SMCCCv1.2
> >
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
>
> Please drop my signed-off as I didn't. I am seeing this patch on the list
> for the first time and AFAIK I haven't posted any previous version of the
> patch that you are picking up.
>
> IIUC, you are importing this code from the Linux kernel tree which I assume
> is fine. You can just mention the same and must not add anyone's sign-off
> without consulting them.
>
> OTH, if you cherry-pick the commit as is and use it in u-boot tree(e.g.
> DTS patches), then you can retain them. That is my understanding. Happy
> to be corrected if my assumptions are not correct here.
>
> --
> Regards,
> Sudeep

No worries. I'll remove the signed-off. I just wanted to give credit to the original author :)

For the FF-A driver in u-boot, only the SMC part of the kernel patch is needed. No need for HVC
support at the moment. The SMC part has been tested and proven to work. Hence, this patch.

I'll rename this commit to:

arm64: smccc: add support for SMCCCv1.2 x0-x17 registers

I'll also state in the commit description that this work is inspired from the following kernel commit:

arm64: smccc: Add support for SMCCCv1.2 extended input/output registers

You're welcome to provide review comments.

Cheers,
Abdellatif