Re: [PATCH v16 10/10] arm_ffa: efi: corstone1000: enable MM communication

Tom Rini
2023-07-26T16:30:23Z

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

On Wed, Jul 26, 2023 at 10:45:03AM +0100, Abdellatif El Khlifi wrote:

> turn on EFI MM communication
>
> On Corstone-1000 platform MM communication between u-boot
> and the secure world (Optee) is done using the FF-A bus.
>
> Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
[snip]
> diff --git a/configs/corstone1000_defconfig b/configs/corstone1000_defconfig
> index a8a79fd105..fa9f9e4f07 100644
> --- a/configs/corstone1000_defconfig
> +++ b/configs/corstone1000_defconfig
> @@ -65,3 +65,10 @@ CONFIG_EFI_CAPSULE_ON_DISK=y
> CONFIG_EFI_IGNORE_OSINDICATIONS=y
> CONFIG_FWU_MULTI_BANK_UPDATE=y
> CONFIG_ERRNO_STR=y
> +CONFIG_ARM_FFA_TRANSPORT=y
> +CONFIG_OPTEE=y
> +CONFIG_TEE=y
> +CONFIG_EFI_MM_COMM_TEE=y
> +CONFIG_FFA_SHARED_MM_BUF_SIZE=4096
> +CONFIG_FFA_SHARED_MM_BUF_OFFSET=0
> +CONFIG_FFA_SHARED_MM_BUF_ADDR=0x02000000

Not a nak and unless there's other comments I'll simply fix this up, but
you cannot just add options to the bottom of the configs. These are
"defconfig" files like the kernel so for something like this you would
do (and I did locally before throwing this at CI now):
$ make corstone1000_defconfig savedefconfig
$ mv defconfig configs/corstone1000_defconfig

--
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]