Re: [PATCH v8 02/10] lib: uuid: introduce uuid_str_to_le_bin function

Simon Glass
2022-11-23T02:11:25Z

Hi Abdellatif,

On Tue, 22 Nov 2022 at 06:18, Abdellatif El Khlifi
<abdellatif.elkhlifi@arm.com> wrote:
>
> convert UUID string to little endian binary data
>
> Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> Cc: Tom Rini <trini@konsulko.com>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Cc: Jens Wiklander <jens.wiklander@linaro.org>
>
> ---
>
> Changelog:
> ===============
>
> v8:
>
> * use simple_strtoull() in uuid_str_to_le_bin() to support 32-bit platforms
>
> v7:
>
> * rename be_uuid_str_to_le_bin() to uuid_str_to_le_bin()
> * make uuid_str_to_le_bin() implementation similar to uuid_str_to_bin()
> by using same APIs
>
> v4:
>
> * rename ffa_uuid_str_to_bin to be_uuid_str_to_le_bin and put in
> a standalone commit (the current)
>
> v3:
>
> * introduce ffa_uuid_str_to_bin (provided by
> arm_ffa: introduce Arm FF-A low-level driver)
>
> include/uuid.h | 8 ++++++++
> lib/uuid.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 54 insertions(+)

Can you please add a full function comment in the header and also a
test, perhaps in test/lib/uuid.c ?

REgards,
Simon