Re: [PATCH 2/6] arm_ffa: introduce armffa command

Abdellatif El Khlifi
2023-07-28T09:53:26Z

Hi Simon, Heinrich,

On Thu, Jul 27, 2023 at 07:52:00PM -0600, Simon Glass wrote:
> Hi Abdellatif,
>
> On Thu, 27 Jul 2023 at 03:00, Abdellatif El Khlifi
> <abdellatif.elkhlifi@arm.com> wrote:
> >
> > Hi Heinrich,
> >
> > On Thu, Jul 27, 2023 at 07:51:42AM +0200, Heinrich Schuchardt wrote:
> > > On 3/29/22 17:16, abdellatif.elkhlifi@arm.com wrote:
> > > > From: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> > > >
> > > > Provide armffa command showcasing the use of the FF-A driver
> > > >
> > > > The armffa command allows to query secure partitions data from
> > > > the secure world and exchanging messages with the partitions.
> > > >
> > > > Signed-off-by: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> > > > Cc: Tom Rini <trini@konsulko.com>
> > > > ---
> > > > MAINTAINERS | 1 +
> > > > cmd/Kconfig | 10 ++
> > > > cmd/Makefile | 2 +
> > > > cmd/armffa.c | 266 ++++++++++++++++++++++++++++++++++++++++
> > > > drivers/arm-ffa/Kconfig | 1 +
> > >
> > > We want to have all commands to be documented in /doc/usage/cmd/.
> > >
> > > Could you, please, provide the missing /doc/usage/cmd/armffa.rst file.
> > >
> >
> > It's here [1].
>
> I'd suggest mentioning that in the commit message for this patch, or
> even putting the testin the same patch, along with the test for the
> command. I find it hard to keep track of this too.

Please refer to the commit provided by the latest version (v17).

In the commit message the path to doc/usage/cmd/armffa.rst is already given.

Please refer to the commit [A].

The commit log says: For more details please refer to the command documentation [1].

[A]: https://lore.kernel.org/all/20230727160712.81477-6-abdellatif.elkhlifi@arm.com/

Cheers
Abdellatif

>
> >
> > [1]: https://lore.kernel.org/all/20230726094503.100497-6-abdellatif.elkhlifi@arm.com/#Z31doc:usage:cmd:armffa.rst
> >
> > Cheers,
> > Abdellatif
>
> Regards,
> Simon