From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C89FFEB64D9 for ; Mon, 10 Jul 2023 15:03:35 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D702486703; Mon, 10 Jul 2023 17:03:33 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 8ECAD86701; Mon, 10 Jul 2023 17:03:32 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id A95FC86715 for ; Mon, 10 Jul 2023 17:03:29 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=abdellatif.elkhlifi@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2D11F2B; Mon, 10 Jul 2023 08:04:11 -0700 (PDT) Received: from e130802.arm.com (unknown [10.57.34.188]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D7EBE3F740; Mon, 10 Jul 2023 08:03:27 -0700 (PDT) Date: Mon, 10 Jul 2023 16:03:22 +0100 From: Abdellatif El Khlifi To: Simon Glass , trini@konsulko.com Cc: nd@arm.com, u-boot@lists.denx.de Subject: Re: [PATCH v14 11/11] arm_ffa: efi: corstone1000: enable MM communication Message-ID: <20230710150322.GA235402@e130802.arm.com> References: <20230707144410.228472-1-abdellatif.elkhlifi@arm.com> <20230707144410.228472-12-abdellatif.elkhlifi@arm.com> <20230707174405.GF148062@bill-the-cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon, Tom, > > > > #include > > > > > > > > +#define FFA_SHARED_MM_BUFFER_SIZE SZ_4K /* 4 KB */ > > > > + > > > > +/* > > > > + * shared buffer physical address used for communication between > > > > + * u-boot and the MM SP > > > > + */ > > > > +#define FFA_SHARED_MM_BUFFER_ADDR 0x02000000UL > > > > +#define FFA_SHARED_MM_BUFFER_OFFSET 0 > > > > + > > > > > > These should be in devicetree properties, shouldn't they? We don't > > > want things in board config.h files anymore. > > > > Wasn't one of the earlier debates on if the whole thing needs to be in > > device tree, or not, because it's a "discoverable bus" and so Linux > > wasn't needing one? I don't want to de-rail this series, which I think > > we're just about otherwise ready to merge, over that debate again. > > > > As these values have to match up (I assume) with the other side, are > > these truly per-board, or SoC dependent? > > Yes let's not derail the series...it has gone on too long already. > > But we do need to think about this. Addresses in #defines are not a > great look. It isn't even a CFG. > I think replacing the FFA_SHARED_MM_BUFFER_* defines with a config makes sense. In v15 I'll add these as configs if you think guys it's appropriate: FFA_SHARED_MM_BUFFER_SIZE FFA_SHARED_MM_BUFFER_ADDR FFA_SHARED_MM_BUFFER_OFFSET Cheers Abdellatif