Re: [PATCH v1 0/5] Make the clock dt-bindings and DT nodes consistent with Linux

[Torsten Duwe <duwe@lst.de>]

On Fri, 7 Jul 2023 18:50:06 +0800
Hal Feng <hal.feng@starfivetech.com> wrote:

> The clock dt-bindings and DT nodes are not consistent with Linux now.
> Let's sync them with Linux, so the same dtb can work for Linux & U-Boot.
> 
> To achieve this goal, the PLL clock driver is separated and some clock
> IDs conversion is needed in clock drivers. 
> 
> For the motivation, please see the discussion in the link below.
> 
> [1] https://patchwork.kernel.org/project/linux-riscv/patch/20230512022036.97987-2-xingyu.wu@starfivetech.com/
> 
> Xingyu Wu (5):
>   clk: starfive: jh7110: Separate the PLL driver
>   riscv: dts: jh7110: Add PLL clock controller node
>   riscv: dts: jh7110: Add clock source from PLL
>   dt-bindings: clock: jh7110: Modify clock id to be same with Linux
>   clk: starfive: jh7110: Add of_xlate ops and macros for clock id
>     conversion

For better bisectability, I would have put patch 2 first, then merged 1&3,
then merged 4&5. This way U-Boot should compile and boot after each patch
(I think, untested ;) But given the rapid development of the platform,
I'm fine with inclusion of the series as-is; as it does not affect other
targets.

I'm also wondering whether the symbolic clock number constants should be
synced, too. But that's also a minor issue, as long as they expand to yield
the same numbers.

For the series:

Reviewed-by: Torsten Duwe <duwe@suse.de>

	Torsten