From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67043EB64DC for ; Tue, 11 Jul 2023 09:10:13 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6901986822; Tue, 11 Jul 2023 11:09:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id CD5D086822; Tue, 11 Jul 2023 11:09:43 +0200 (CEST) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7B6F98681A for ; Tue, 11 Jul 2023 11:09:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=duwe@lst.de Received: by verein.lst.de (Postfix, from userid 107) id D35DD68BFE; Tue, 11 Jul 2023 11:09:39 +0200 (CEST) Received: from blackhole.lan (p5b33f9bb.dip0.t-ipconnect.de [91.51.249.187]) by verein.lst.de (Postfix) with ESMTPSA id 7456D67328; Tue, 11 Jul 2023 11:09:23 +0200 (CEST) Date: Tue, 11 Jul 2023 11:09:23 +0200 From: Torsten Duwe To: Hal Feng Cc: Lukasz Majewski , Sean Anderson , "Rick Chen" , Leo , Conor Dooley , Yanhong Wang , Emil Renner Berthing , Xingyu Wu , Subject: Re: [PATCH v1 0/5] Make the clock dt-bindings and DT nodes consistent with Linux Message-ID: <20230711110923.08b32183@blackhole.lan> In-Reply-To: <20230707105011.129241-1-hal.feng@starfivetech.com> References: <20230707105011.129241-1-hal.feng@starfivetech.com> Organization: LST e.V. X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.34; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, 7 Jul 2023 18:50:06 +0800 Hal Feng wrote: > The clock dt-bindings and DT nodes are not consistent with Linux now. > Let's sync them with Linux, so the same dtb can work for Linux & U-Boot. > > To achieve this goal, the PLL clock driver is separated and some clock > IDs conversion is needed in clock drivers. > > For the motivation, please see the discussion in the link below. > > [1] https://patchwork.kernel.org/project/linux-riscv/patch/20230512022036.97987-2-xingyu.wu@starfivetech.com/ > > Xingyu Wu (5): > clk: starfive: jh7110: Separate the PLL driver > riscv: dts: jh7110: Add PLL clock controller node > riscv: dts: jh7110: Add clock source from PLL > dt-bindings: clock: jh7110: Modify clock id to be same with Linux > clk: starfive: jh7110: Add of_xlate ops and macros for clock id > conversion For better bisectability, I would have put patch 2 first, then merged 1&3, then merged 4&5. This way U-Boot should compile and boot after each patch (I think, untested ;) But given the rapid development of the platform, I'm fine with inclusion of the series as-is; as it does not affect other targets. I'm also wondering whether the symbolic clock number constants should be synced, too. But that's also a minor issue, as long as they expand to yield the same numbers. For the series: Reviewed-by: Torsten Duwe Torsten