* [PATCH] imx8m: soc.c: demote some printfs to debug
@ 2023-05-22 9:27 Rasmus Villemoes
2023-05-22 10:05 ` Frieder Schrempf
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Rasmus Villemoes @ 2023-05-22 9:27 UTC (permalink / raw)
To: u-boot; +Cc: Stefano Babic, Fabio Estevam, NXP i.MX U-Boot Team,
Rasmus Villemoes
Getting
Found /vpu_g1@38300000 node
Modify /vpu_g1@38300000:status disabled
Found /vpu_g2@38310000 node
Modify /vpu_g2@38310000:status disabled
etc. on the console on every boot is needlessly verbose. Demote the
"Found ..." lines to debug(), which is consistent with other instances
in soc.c.
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
---
arch/arm/mach-imx/imx8m/soc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
index 5a4f8358c9..f5c82dff35 100644
--- a/arch/arm/mach-imx/imx8m/soc.c
+++ b/arch/arm/mach-imx/imx8m/soc.c
@@ -736,7 +736,7 @@ static int disable_fdt_nodes(void *blob, const char *const nodes_path[], int siz
if (nodeoff < 0)
continue; /* Not found, skip it */
- printf("Found %s node\n", nodes_path[i]);
+ debug("Found %s node\n", nodes_path[i]);
add_status:
rc = fdt_setprop(blob, nodeoff, "status", status, strlen(status) + 1);
@@ -1265,7 +1265,7 @@ int ft_system_setup(void *blob, struct bd_info *bd)
if (nodeoff >= 0) {
const char *speed = "high-speed";
- printf("Found %s node\n", usb_dwc3_path[v]);
+ debug("Found %s node\n", usb_dwc3_path[v]);
usb_modify_speed:
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] imx8m: soc.c: demote some printfs to debug
2023-05-22 9:27 [PATCH] imx8m: soc.c: demote some printfs to debug Rasmus Villemoes
@ 2023-05-22 10:05 ` Frieder Schrempf
2023-05-23 6:05 ` Peng Fan
2023-07-11 19:41 ` sbabic
2 siblings, 0 replies; 4+ messages in thread
From: Frieder Schrempf @ 2023-05-22 10:05 UTC (permalink / raw)
To: Rasmus Villemoes, u-boot
Cc: Stefano Babic, Fabio Estevam, NXP i.MX U-Boot Team
On 22.05.23 11:27, Rasmus Villemoes wrote:
> Getting
>
> Found /vpu_g1@38300000 node
> Modify /vpu_g1@38300000:status disabled
> Found /vpu_g2@38310000 node
> Modify /vpu_g2@38310000:status disabled
>
> etc. on the console on every boot is needlessly verbose. Demote the
> "Found ..." lines to debug(), which is consistent with other instances
> in soc.c.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] imx8m: soc.c: demote some printfs to debug
2023-05-22 9:27 [PATCH] imx8m: soc.c: demote some printfs to debug Rasmus Villemoes
2023-05-22 10:05 ` Frieder Schrempf
@ 2023-05-23 6:05 ` Peng Fan
2023-07-11 19:41 ` sbabic
2 siblings, 0 replies; 4+ messages in thread
From: Peng Fan @ 2023-05-23 6:05 UTC (permalink / raw)
To: Rasmus Villemoes, u-boot@lists.denx.de
Cc: Stefano Babic, Fabio Estevam, dl-uboot-imx
On 5/22/2023 5:27 PM, Rasmus Villemoes wrote:
> Getting
>
> Found /vpu_g1@38300000 node
> Modify /vpu_g1@38300000:status disabled
> Found /vpu_g2@38310000 node
> Modify /vpu_g2@38310000:status disabled
>
> etc. on the console on every boot is needlessly verbose. Demote the
> "Found ..." lines to debug(), which is consistent with other instances
> in soc.c.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> arch/arm/mach-imx/imx8m/soc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
> index 5a4f8358c9..f5c82dff35 100644
> --- a/arch/arm/mach-imx/imx8m/soc.c
> +++ b/arch/arm/mach-imx/imx8m/soc.c
> @@ -736,7 +736,7 @@ static int disable_fdt_nodes(void *blob, const char *const nodes_path[], int siz
> if (nodeoff < 0)
> continue; /* Not found, skip it */
>
> - printf("Found %s node\n", nodes_path[i]);
> + debug("Found %s node\n", nodes_path[i]);
>
> add_status:
> rc = fdt_setprop(blob, nodeoff, "status", status, strlen(status) + 1);
> @@ -1265,7 +1265,7 @@ int ft_system_setup(void *blob, struct bd_info *bd)
> if (nodeoff >= 0) {
> const char *speed = "high-speed";
>
> - printf("Found %s node\n", usb_dwc3_path[v]);
> + debug("Found %s node\n", usb_dwc3_path[v]);
>
> usb_modify_speed:
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] imx8m: soc.c: demote some printfs to debug
2023-05-22 9:27 [PATCH] imx8m: soc.c: demote some printfs to debug Rasmus Villemoes
2023-05-22 10:05 ` Frieder Schrempf
2023-05-23 6:05 ` Peng Fan
@ 2023-07-11 19:41 ` sbabic
2 siblings, 0 replies; 4+ messages in thread
From: sbabic @ 2023-07-11 19:41 UTC (permalink / raw)
To: Rasmus Villemoes, u-boot
> Getting
> Found /vpu_g1@38300000 node
> Modify /vpu_g1@38300000:status disabled
> Found /vpu_g2@38310000 node
> Modify /vpu_g2@38310000:status disabled
> etc. on the console on every boot is needlessly verbose. Demote the
> "Found ..." lines to debug(), which is consistent with other instances
> in soc.c.
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> Reviewed-by: Frieder Schrempf <frieder.schrempf@kontron.de>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-07-11 19:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-22 9:27 [PATCH] imx8m: soc.c: demote some printfs to debug Rasmus Villemoes
2023-05-22 10:05 ` Frieder Schrempf
2023-05-23 6:05 ` Peng Fan
2023-07-11 19:41 ` sbabic
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox