Re: [PATCH 1/5] arm: mxs: Provide Kconfig option to to not use VDD5V as IMX28 PMU source

Lukasz Majewski
2023-05-09T15:04:10Z

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

Hi Marek,

> On 5/9/23 16:46, Lukasz Majewski wrote:
> > Hi Marek,
>
> Hi,
>
> >> On 5/9/23 16:32, Lukasz Majewski wrote:
> >>> This option sets the current limit for 5V source to zero, so all
> >>> the PMU outputs are primarily powered from battery source
> >>> (DCDC_BAT).
> >>>
> >>> This option may be set on systems, where the 5V is NOT supposed to
> >>> be in any scenario powering the system - for example on systems
> >>> where DCDC_BAT is connected to fixed and regulated 4.2V source (so
> >>> the "battery" is not present).
> >>
> >> Is it possible to dig this information out of DT or is the DT not
> >> available in SPL for this platform ?
> >
> > This platform uses only SPL_OF_PLATDATA to keep the SPL size < 40
> > KiB.
> >
> > I would prefer to keep this as Kconfig as the PMU driver is not
> > supporting DT and in fact now ARCH_MX28 only has two boards
> > supported - XEA and imx28evk.
>
> Why not use the platdata then ?
> This makes it far better, as the code is actually always compiled and
> doesn't start to bitrot.

As fair as I can tell - the MX28 PMU driver in SPL is not supporting
OF_PLATDATA. Or have I overlooked something?

I would like to investigate the PMU issue, and avoid extra work to
provide platdata support for two supported imx287 based boards.

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]