From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A3C0EB64DC for ; Tue, 11 Jul 2023 19:51:33 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 8A81A869C5; Tue, 11 Jul 2023 21:45:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1689104716; bh=rJsIJMlywdC5DqON0XEO2DabLLjoixp5eBlHj+rNwho=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=vvqMp0kurux9XTWUe8I3VTUM24zVvVVR1FyYLIFZ1VP55LeBcyCZhinX15KlrPUtr LYDlB4MS1Fr/L3CuTbtJlynKyzrEpS+ShDpw4ANXZikreXn3K8u1lyOwZX0wD7D4bF 0nHOoLtZnK/ETLUW8PXuMKSf2x0X9k3t47KxIf6cbsMmPDNZhdSNoWWb/UGC2tkzat hwp8Ge729QgnPLgXtEhGHb+4R9uTwLQ13JEJRqe2pBADXTT2znhvt/82d38vA31hrr 0oqnbzCFlxSI3l/N1MblVA0/YCajgFci+HzQxQVx3dee7JKDrkaaEyFCfwNoEnODGy 3ClhHpgOQ6pQw== Received: by phobos.denx.de (Postfix, from userid 109) id 482428699C; Tue, 11 Jul 2023 21:45:14 +0200 (CEST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 560258699C for ; Tue, 11 Jul 2023 21:45:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4R0rtw14jhz1sGWl; Tue, 11 Jul 2023 21:45:12 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4R0rtw0z1Gz1qqmK; Tue, 11 Jul 2023 21:45:12 +0200 (CEST) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id OkpkAucOZysN; Tue, 11 Jul 2023 21:45:11 +0200 (CEST) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Tue, 11 Jul 2023 21:45:11 +0200 (CEST) From: sbabic@denx.de X-Patchwork-Submitter: Lukasz Majewski X-Patchwork-Id: 1783722 X-Patchwork-Delegate: sbabic@denx.de To: Lukasz Majewski ,u-boot@lists.denx.de Subject: [PATCH v1 11/16] serial: pl01x: Modify pending callback to test if transmit FIFO is empty In-reply-to: <20230519104359.2048821-12-lukma@denx.de> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Message-Id: <20230711194514.482428699C@phobos.denx.de> Date: Tue, 11 Jul 2023 21:45:12 +0200 (CEST) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean > Before this change the FR_TXFF (Transmit FIFO full) bit (5 in > HW_UARTDBG_FR) has been used to assess if there is still data pending > to be sent via UART. > This approach is problematic, as it may happen that serial is in the > middle of transmission (so the TX FIFO is NOT full anymore) and this > test returns true infinitely. As a result, for example in _serial_flush() > DM serial function we are locked in endless while(). > The fix here is to test explicitly if the TX FIFO is empty. > Signed-off-by: Lukasz Majewski Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================