public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [PATCH v1] colibri_imx6: fix RALAT and WALAT values
@ 2023-06-14  9:01 Francesco Dolcini
  2023-07-11 19:45 ` sbabic
  0 siblings, 1 reply; 2+ messages in thread
From: Francesco Dolcini @ 2023-06-14  9:01 UTC (permalink / raw)
  To: Marcel Ziswiler, u-boot
  Cc: Stefan Eichenberger, Marek Vasut, Fabio Estevam, Stefano Babic,
	Francesco Dolcini

From: Stefan Eichenberger <stefan.eichenberger@toradex.com>

Running a memtest in U-Boot and Linux shows that some Colibri iMX6
produce bitflips at temperatures above 60°C. This happens because the
RALAT and WALAT values on the Colibri iMX6 are too low. The problems
were introduced by commit 09dbac8174c4 ("mx6: ddr: Restore ralat/walat
in write level calibration") before the calibration process overwrote
the values and set them to the maximum value. With this commit, we make
sure that the RALAT and WALAT values are set to the maximum values
again. This has been proven to work for years.

Fixes: 09dbac8174c4 ("mx6: ddr: Restore ralat/walat in write level calibration")
Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
---
 board/toradex/colibri_imx6/colibri_imx6.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/board/toradex/colibri_imx6/colibri_imx6.c b/board/toradex/colibri_imx6/colibri_imx6.c
index 65e0e9a156ab..677caa4a4ebc 100644
--- a/board/toradex/colibri_imx6/colibri_imx6.c
+++ b/board/toradex/colibri_imx6/colibri_imx6.c
@@ -767,8 +767,7 @@ MX6_MMDC_P1_MPRDDQBY3DL, 0x33333333,
 /*
  * MDMISC	mirroring	interleaved (row/bank/col)
  */
-/* TODO: check what the RALAT field does */
-MX6_MMDC_P0_MDMISC, 0x00081740,
+MX6_MMDC_P0_MDMISC, 0x000b17c0,
 
 /*
  * MDSCR	con_req
@@ -900,8 +899,7 @@ MX6_MMDC_P1_MPRDDQBY3DL, 0x33333333,
 /*
  * MDMISC	mirroring	interleaved (row/bank/col)
  */
-/* TODO: check what the RALAT field does */
-MX6_MMDC_P0_MDMISC, 0x00081740,
+MX6_MMDC_P0_MDMISC, 0x000b17c0,
 
 /*
  * MDSCR	con_req
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH v1] colibri_imx6: fix RALAT and WALAT values
  2023-06-14  9:01 [PATCH v1] colibri_imx6: fix RALAT and WALAT values Francesco Dolcini
@ 2023-07-11 19:45 ` sbabic
  0 siblings, 0 replies; 2+ messages in thread
From: sbabic @ 2023-07-11 19:45 UTC (permalink / raw)
  To: Francesco Dolcini, u-boot

> From: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> Running a memtest in U-Boot and Linux shows that some Colibri iMX6
> produce bitflips at temperatures above 60°C. This happens because the
> RALAT and WALAT values on the Colibri iMX6 are too low. The problems
> were introduced by commit 09dbac8174c4 ("mx6: ddr: Restore ralat/walat
> in write level calibration") before the calibration process overwrote
> the values and set them to the maximum value. With this commit, we make
> sure that the RALAT and WALAT values are set to the maximum values
> again. This has been proven to work for years.
> Fixes: 09dbac8174c4 ("mx6: ddr: Restore ralat/walat in write level calibration")
> Signed-off-by: Stefan Eichenberger <stefan.eichenberger@toradex.com>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-07-11 19:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-14  9:01 [PATCH v1] colibri_imx6: fix RALAT and WALAT values Francesco Dolcini
2023-07-11 19:45 ` sbabic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox