From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34976EB64DC for ; Tue, 11 Jul 2023 19:56:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2879486A32; Tue, 11 Jul 2023 21:47:12 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1689104832; bh=GfiBa/LTHTQfpuJHYoMdaxh34guVjH8mnVdv9LYoa7I=; h=From:To:Subject:In-reply-to:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=lubU/UB3vdtA/1k4MwN3MFHJz1H7RCS5yk6vE364/GeVg4C3vQf5Z+rZwOwIRxV0I pJLUFJ5gq2bGA818I6qih9ePZsvZ4AW6QridKWT3uwNIoRQUDC4KXRQPG38eqNKLnu IIccabAAw5VucR52Rn59IoSpzK7o5yuYjr3LUTEINc4knaR/CmM1oX/j/4EvBvacoV 9Qs65ciuvW8ZowSgRWDT5R2IossSzsvoduAh+bCf4i5W4KtQJ3/MXczpPbdb6Ib6V0 4vwmY5dQUa4XFlphTbaHkJYzqdq2diD1VCDCRoQp54XN8mFAWNMbdF/i1HSTJznOL5 A8z9hDsFaz/BQ== Received: by phobos.denx.de (Postfix, from userid 109) id 231FC86A35; Tue, 11 Jul 2023 21:47:11 +0200 (CEST) Received: from mail-out.m-online.net (mail-out.m-online.net [212.18.0.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 03C0D86A32 for ; Tue, 11 Jul 2023 21:47:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sbabic@denx.de Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4R0rx85rpnz1r68j; Tue, 11 Jul 2023 21:47:08 +0200 (CEST) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 4R0rx85mTSz1qqmK; Tue, 11 Jul 2023 21:47:08 +0200 (CEST) X-Amavis-Alert: BAD HEADER SECTION, Missing required header field: "Date" Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavis, port 10024) with ESMTP id COstB7uCR2jq; Tue, 11 Jul 2023 21:47:08 +0200 (CEST) Received: from papero (host-88-217-136-221.customer.m-online.net [88.217.136.221]) by mail.mnet-online.de (Postfix) with ESMTP; Tue, 11 Jul 2023 21:47:08 +0200 (CEST) From: sbabic@denx.de X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 1795324 X-Patchwork-Delegate: sbabic@denx.de To: "Peng Fan (OSS)" ,u-boot@lists.denx.de Subject: [PATCH V2 30/30] imx: fsl_sec: preprocessor casting issue with addresses involving math In-reply-to: <20230615100928.25767-31-peng.fan@oss.nxp.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Message-Id: <20230711194711.231FC86A35@phobos.denx.de> Date: Tue, 11 Jul 2023 21:47:09 +0200 (CEST) X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean > From: Utkarsh Gupta > The sec_in32 preprocessor is defined as follows in include/fsl_sec.h file: > When address "a" is calculated using math for ex: addition of base address = and > an offset, then casting is applied only to the first address which in this > example is base address. > caam_ccbvid_reg =3D sec_in32(CONFIG_SYS_FSL_SEC_ADDR + CAAM_CCBVID_OFFSET) > resolves to: > caam_ccbvid_reg =3D in_le32((ulong *)(ulong)CONFIG_SYS_FSL_SEC_ADDR + > CAAM_CCBVID_OFFSET) > instead it should resolve to: > caam_ccbvid_reg =3D in_le32((ulong *)(ulong)(CONFIG_SYS_FSL_SEC_ADDR + > CAAM_CCBVID_OFFSET)) > Thus add parenthesis around the address "a" so that however the address is > calculated, the casting is applied to the final calculated address. > Reviewed-by: Horia Geanta > Reviewed-by: Ye Li > Signed-off-by: Utkarsh Gupta > Signed-off-by: Peng Fan Applied to u-boot-imx, master, thanks ! Best regards, Stefano Babic --=20 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D DENX Software Engineering GmbH, Managing Director: Erika Unter =20 HRB 165235 Munich, Office: Kirchenstr.5, 82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D