From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D273C001B0 for ; Sun, 16 Jul 2023 15:53:44 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 125A886307; Sun, 16 Jul 2023 17:53:42 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1689522822; bh=NfUGAb4nMhua0+j7sSASasDSS2hDyuG5kuBdSJ8ugo0=; h=From:To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=VpZvNsqGlZNw6VZXydHXwAAruKQYa26LIZaTwgYaaQ3IW7P8a8SSI8665VI48VpJw XRkgtEkTCAyX1aTFquelyKS2DUTZDPRcDEH/jNaKCDIdEYBa9gOlVQ5prN2RdisyLw x6tIU5wPw7euLBawN+zebrHPukZwCRUwW++/SruKT0G0Frxw8G5ITmS62hiYa8N9KR 7czjAio07EluW2w3fO2AUSZxXkNNWNXPYoCS1KieZmoQsG5q4CMsdrzuienkyKmRI4 0Svhud0BcGa2TELgJh56KeBxkm7zovxIol4Kl396nkH++8sE8XDc3t4KM7qqIjRuvQ DX/7426ZtR56A== Received: from tr.lan (ip-86-49-120-218.bb.vodafone.cz [86.49.120.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 013888634D; Sun, 16 Jul 2023 17:53:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1689522820; bh=NfUGAb4nMhua0+j7sSASasDSS2hDyuG5kuBdSJ8ugo0=; h=From:To:Cc:Subject:Date:From; b=HKY1nrbejAMZ/vQsFeqh6z8IbrV4UOJzvTk6f9N0UC/pBCdxv1ZfuGEzUbEukMeN8 1+YM98YLIKm3QBuxWPOCKLPkMp0sXQ3vvLnpkoBMIH17CE4LoWMwERb2upL27hbpVV 12a5F48hFxAUbb3mrKO0bfWOZPde3vEe3iC/pE1C8cDwxxBtPojuaNESucryb6nKel tyePmDyQNp2f2mMVXJKuf/ykowxan6wv7aubLY1FUKlA4//6CjkPdTuAO3oafNDvCY eo4tzbV6NDuW/xlxVcJvjR8zTsP3vWEcyWXW9qAfsLa39kDxNULMB21tTL67GquKVd dpCWnFQEVxmFg== From: Marek Vasut To: u-boot@lists.denx.de Cc: Marek Vasut , Jonas Karlman , =?UTF-8?q?Pali=20Roh=C3=A1r?= , Bin Meng , Michal Suchanek , Simon Glass Subject: [PATCH] pci: Fix device_find_first_child() return value handling Date: Sun, 16 Jul 2023 17:53:24 +0200 Message-Id: <20230716155324.11211-1-marex@denx.de> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean This function only ever returns 0, but may not assign the second parameter. Same thing for device_find_next_child(). Do not assign ret to stop proliferation of this misuse. Reported-by: Jonas Karlman Signed-off-by: Marek Vasut --- Cc: "Pali Rohár" Cc: Bin Meng Cc: Marek Vasut Cc: Michal Suchanek Cc: Simon Glass --- drivers/pci/pci-uclass.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index 8d27e40338c..6421eda7721 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -545,9 +545,9 @@ int pci_auto_config_devices(struct udevice *bus) sub_bus = dev_seq(bus); debug("%s: start\n", __func__); pciauto_config_init(hose); - for (ret = device_find_first_child(bus, &dev); - !ret && dev; - ret = device_find_next_child(&dev)) { + for (device_find_first_child(bus, &dev); + dev; + device_find_next_child(&dev)) { unsigned int max_bus; int ret; -- 2.40.1