From: Tom Rini <trini@konsulko.com>
To: Joshua Watt <jpewhacker@gmail.com>
Cc: u-boot@lists.denx.de, Roger Knecht <rknecht@pm.me>,
Simon Glass <sjg@chromium.org>
Subject: Re: [PATCH] tests: Fix exception when cleaning up skipped test
Date: Tue, 18 Jul 2023 09:58:20 -0400 [thread overview]
Message-ID: <20230718135820.GS1670569@bill-the-cat> (raw)
In-Reply-To: <20230703133518.3879199-1-JPEWhacker@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
On Mon, Jul 03, 2023 at 08:35:09AM -0500, Joshua Watt wrote:
> If test_cat and test_xxd cannot create the required file, the test will
> be skipped, but this would result in an exception being raised in the
> finally block because the file didn't exist to be cleaned up. This
> caused the test to be marked as failed instead of skipped.
>
> Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-07-18 13:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 13:35 [PATCH] tests: Fix exception when cleaning up skipped test Joshua Watt
2023-07-04 2:40 ` Simon Glass
2023-07-18 13:58 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230718135820.GS1670569@bill-the-cat \
--to=trini@konsulko.com \
--cc=jpewhacker@gmail.com \
--cc=rknecht@pm.me \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox