Re: [PATCH v4 1/2] board/km/cent2: add include common.h

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1099 bytes --]

On Wed, Jul 19, 2023 at 03:45:43PM +0200, christian.taedcke-oss@weidmueller.com wrote:

> From: Christian Taedcke <christian.taedcke@weidmueller.com>
> 
> Including common.h before event.h is required, because the new fpga
> load event in event.h uses the size_t type.
> 
> Signed-off-by: Christian Taedcke <christian.taedcke@weidmueller.com>
> ---
> 
> Changes in v4:
> - add include common.h to kmcent2 board file
> 
>  board/keymile/kmcent2/kmcent2.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/board/keymile/kmcent2/kmcent2.c b/board/keymile/kmcent2/kmcent2.c
> index ed552c57b5..6dbaaa5457 100644
> --- a/board/keymile/kmcent2/kmcent2.c
> +++ b/board/keymile/kmcent2/kmcent2.c
> @@ -6,6 +6,7 @@
>   * Copyright 2013 Freescale Semiconductor, Inc.
>   */
>  
> +#include <common.h>
>  #include <event.h>
>  #include <asm/cache.h>
>  #include <asm/fsl_fdt.h>

No, we aren't adding common.h to more files.  What in event.h needs some
other part of common.h that it's not getting today?  common.h has
nothing more in it than other includes.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]