public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minda Chen <minda.chen@starfivetech.com>
To: Joe Hershberger <joe.hershberger@ni.com>,
	Ramon Fried <rfried.dev@gmail.com>, Leo <ycliang@andestech.com>,
	Rick Chen <rick@andestech.com>
Cc: <u-boot@lists.denx.de>, Mason Huo <mason.huo@starfivetech.com>
Subject: [PATCH v2 2/4] net: rtl8169: Fix DMA minimal aligned compile warning in RISC-V
Date: Thu, 20 Jul 2023 19:37:27 +0800	[thread overview]
Message-ID: <20230720113729.9798-3-minda.chen@starfivetech.com> (raw)
In-Reply-To: <20230720113729.9798-1-minda.chen@starfivetech.com>

For RISC-V architeture, hardware maintain the dcache coherency.
Software do not flush the cache. So even cache-line size larger
than descriptor size, driver can work.

Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
---
 drivers/net/rtl8169.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/net/rtl8169.c b/drivers/net/rtl8169.c
index dcba51590d..34e4cff1e9 100644
--- a/drivers/net/rtl8169.c
+++ b/drivers/net/rtl8169.c
@@ -311,10 +311,12 @@ static unsigned char rxdata[RX_BUF_LEN];
  *
  * This can be fixed by defining CONFIG_SYS_NONCACHED_MEMORY which will cause
  * the driver to allocate descriptors from a pool of non-cached memory.
+ *
+ * Hardware maintain D-cache coherency in RISC-V architecture.
  */
 #if RTL8169_DESC_SIZE < ARCH_DMA_MINALIGN
 #if !defined(CONFIG_SYS_NONCACHED_MEMORY) && \
-	!CONFIG_IS_ENABLED(SYS_DCACHE_OFF) && !defined(CONFIG_X86)
+	!CONFIG_IS_ENABLED(SYS_DCACHE_OFF) && !defined(CONFIG_X86) && !defined(CONFIG_RISCV)
 #warning cache-line size is larger than descriptor size
 #endif
 #endif
-- 
2.17.1


  parent reply	other threads:[~2023-07-20 11:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-20 11:37 [PATCH v2 0/4] Fix rtl8169 compile warning and add a new device ID Minda Chen
2023-07-20 11:37 ` [PATCH v2 1/4] net: rtl8169: Fix compile warning in rtl8169 Minda Chen
2023-07-24  2:05   ` Leo Liang
2023-07-20 11:37 ` Minda Chen [this message]
2023-07-24  2:06   ` [PATCH v2 2/4] net: rtl8169: Fix DMA minimal aligned compile warning in RISC-V Leo Liang
2023-07-20 11:37 ` [PATCH v2 3/4] net: rtl8169: Add one device ID 0x8161 Minda Chen
2023-07-24  2:07   ` Leo Liang
2023-07-20 11:37 ` [PATCH v2 4/4] configs: starfive-jh7110: Add CONFIG_RTL8169 Minda Chen
2023-07-24  1:41   ` Leo Liang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230720113729.9798-3-minda.chen@starfivetech.com \
    --to=minda.chen@starfivetech.com \
    --cc=joe.hershberger@ni.com \
    --cc=mason.huo@starfivetech.com \
    --cc=rfried.dev@gmail.com \
    --cc=rick@andestech.com \
    --cc=u-boot@lists.denx.de \
    --cc=ycliang@andestech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox