From: Tom Rini <trini@konsulko.com>
To: Nikhil M Jain <n-jain1@ti.com>
Cc: u-boot@lists.denx.de, devarsht@ti.com, vigneshr@ti.com,
nsekhar@ti.com, sjg@chromium.org
Subject: Re: [PATCH V2 2/2] common: splash_source: Fix type casting errors
Date: Fri, 21 Jul 2023 19:34:31 -0400 [thread overview]
Message-ID: <20230721233431.GI3630934@bill-the-cat> (raw)
In-Reply-To: <20230621105953.49533-3-n-jain1@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1189 bytes --]
On Wed, Jun 21, 2023 at 04:29:53PM +0530, Nikhil M Jain wrote:
> During compilation splash_source puts out below warning for type
> conversion in splash_load_fit for bmp_load_addr and fit_header.
> Change their type to uintptr_t to fix the warnings.
>
> common/splash_source.c: In function ‘splash_load_fit’:
> common/splash_source.c:366:22: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 366 | img_header = (struct legacy_img_hdr *)bmp_load_addr;
> | ^
> common/splash_source.c:376:49: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
> 376 | res = splash_storage_read_raw(location, (u32)fit_header, fit_size);
> | ^
> common/splash_source.c:401:25: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> 401 | memmove((void *)bmp_load_addr, internal_splash_data, internal_splash_size);
>
> The above warnings are generated if CONFIG_FIT is enabled.
>
> Signed-off-by: Nikhil M Jain <n-jain1@ti.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
next prev parent reply other threads:[~2023-07-21 23:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 10:59 [PATCH V2 0/2] Fix warnings occurred during compilation Nikhil M Jain
2023-06-21 10:59 ` [PATCH V2 1/2] board: ti: am62x: evm: Include necessary header files Nikhil M Jain
2023-07-21 23:34 ` Tom Rini
2023-06-21 10:59 ` [PATCH V2 2/2] common: splash_source: Fix type casting errors Nikhil M Jain
2023-07-21 23:34 ` Tom Rini [this message]
2023-07-19 11:14 ` [PATCH V2 0/2] Fix warnings occurred during compilation Nikhil M Jain
2023-07-19 11:58 ` Tom Rini
2023-07-19 13:14 ` [EXTERNAL] " Nikhil M Jain
2023-07-19 13:18 ` Tom Rini
2023-07-20 6:05 ` Nikhil M Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230721233431.GI3630934@bill-the-cat \
--to=trini@konsulko.com \
--cc=devarsht@ti.com \
--cc=n-jain1@ti.com \
--cc=nsekhar@ti.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox