From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0832C0015E for ; Tue, 25 Jul 2023 21:13:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id EB0F3867EA; Tue, 25 Jul 2023 23:13:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="fb11nGad"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 9E4C786795; Tue, 25 Jul 2023 23:13:10 +0200 (CEST) Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 912B7867B3 for ; Tue, 25 Jul 2023 23:13:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vs1-xe30.google.com with SMTP id ada2fe7eead31-440d1ba5662so1592876137.2 for ; Tue, 25 Jul 2023 14:13:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1690319586; x=1690924386; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=UUqU7O6FpfJQ/ijY8oOhb8MeSh3DxP2qfRaHTaHFIBg=; b=fb11nGad2V0u6Ws2zPTYsWTB4vcK03J1/O+FBWvcBHv4Ig9rNOu0gB0xDtHYlxKHEL Chntn8Fn+cMbMm7fMzx/HL/hpFmBIU4uITSi0iXcdoE0KaoFfSk6NuxrSLAq6N0EmLVC S4nBfkMoFW90ZWoNNyTEaBSJhSidxXXa3FfHg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690319586; x=1690924386; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UUqU7O6FpfJQ/ijY8oOhb8MeSh3DxP2qfRaHTaHFIBg=; b=hJnkMeyOo/xrD+fGQIxeoQceq4Pis5W50oDe/aBTPiIOt4LSn1a6RQ6fksiu6H5xc/ NnsIgfjuRIp9oEPEZWL+BwUBue1Muw9sKEtCVAJM5TFvFpGNmAbDwcoBDvnjpIA5wRun HS9hW97btGM4JDwYHUHKz1/mkANIj3ccFo3xgpwNU2iV1VdOZ0LvtcZxONLurJtUM0jF 6geFqrVUCavEXYfHIEHBrMayOiuNfxi3QJ9snYUfyW47ar2iWx7pFE05DpvVZSk2XVxV NQkVaXa9ZBl1aDVMHh0V8Ef2Kb99r3+y+bL429IlfofxKo44dg2/Z6/A+ReQDeT4K5FP AXIw== X-Gm-Message-State: ABy/qLaAzFhF+UlSS2IZ3yWQ3WcXo00PpQ/h7m47ao1csty2hyfW9hLp EGaxKOSvYTfDBwO2pMQqLlrzVQ== X-Google-Smtp-Source: APBJJlFw4Bv7Ydg+JK+z4+z0S8jqE36u/nP/beeWHHlQSU2S8B1MiuHMfJrHXNgR2uKxhd+ZILambg== X-Received: by 2002:a05:6102:a2c:b0:443:6392:71ea with SMTP id 12-20020a0561020a2c00b00443639271eamr83148vsb.34.1690319586284; Tue, 25 Jul 2023 14:13:06 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b236-e3a5-57be-379d.res6.spectrum.com. [2603:6081:7b00:6400:b236:e3a5:57be:379d]) by smtp.gmail.com with ESMTPSA id e11-20020a67e18b000000b004435c659092sm2065226vsl.5.2023.07.25.14.13.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 14:13:05 -0700 (PDT) Date: Tue, 25 Jul 2023 17:13:03 -0400 From: Tom Rini To: Michal Simek Cc: u-boot@lists.denx.de, git@xilinx.com, Etienne Carriere , Ilias Apalodimas , Jassi Brar , Masahisa Kojima , Patrick Delaunay , Sughosh Ganu Subject: Re: [PATCH] fwu: Allow code to properly decode trial state Message-ID: <20230725211303.GK3630934@bill-the-cat> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ckTBUbNJjuVzi+mW" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --ckTBUbNJjuVzi+mW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 13, 2023 at 04:35:24PM +0200, Michal Simek wrote: > Current code after capsule update (mtd write) is not changing active_index > in mdata to previous_active_index. > On the reboot this is shown but showing message > "Boot idx 1 is not matching active idx 0, changing active_idx" > which is changing active_idx and writing mdata to flash. >=20 > But when this message is visible it is not checking which state that imag= es > are. If they have acceptance bit setup to yes everything is fine and valid > images are booted (doesn't mean the latest one). > But if acceptance bit is no and images are in trial state in_trial variab= le > is never setup. Which means that from new flashed image stable image can = be > rewritten because in_trial is not setup properly. >=20 > Signed-off-by: Michal Simek > Acked-by: Jassi Brar Applied to u-boot/master, thanks! --=20 Tom --ckTBUbNJjuVzi+mW Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTAOt8ACgkQFHw5/5Y0 tywDIAwAiYTRqGevaFgJgV1bhh3nduPudBkplTUotIDuk8axVt6ew6vP2pAoDID6 hjO/GfpL7KtTIufiLofHIDHlpS1rnwzY3HZZwZSkce/FRK+uiepib4gRPNhTP7L+ vqXRXcDg7jdglExTPvkso2DQtTeBDCSbNvS+sdc1pNfb++uXjEvYjjcM2qNSTjAr VBP+hfIIm06JInII98ZRUiG5OgdsFSNm7qiy4FpzZ7vR1IJTQz8Umn73eiLnL+p4 IbbDs6MRWe3n9iDUuIqEJ0GbiNqwLuFeJ586RSqIkZBsnOfvXPkXmMWoxvMWEtoM Mqcb+5WXDvx4sDK+0w5Uamto3gmQrdCz8vsY4F45Y5XISwJMy1vy3F3g1bnTEYaJ Bt4pqpEYbkg8OE5noTYMWi8sRhonkN7UqlTiE1+ae5bf2CzSF3lz1lWwSayCCNRr Jk0q95KvHX19qPLlwLZh7UyG9qwkR1TaduPNk6CrLwAT7Ee6hRY842f+DbgHG7yP 5qFC9h3X =NQUK -----END PGP SIGNATURE----- --ckTBUbNJjuVzi+mW--