From: Tom Rini <trini@konsulko.com>
To: Michal Simek <michal.simek@amd.com>
Cc: u-boot@lists.denx.de, git@xilinx.com,
Jassi Brar <jaswinder.singh@linaro.org>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>
Subject: Re: [PATCH] fwu: mtd: Fix dfu_alt_info generation for 2 images per bank
Date: Tue, 25 Jul 2023 17:13:09 -0400 [thread overview]
Message-ID: <20230725211309.GL3630934@bill-the-cat> (raw)
In-Reply-To: <4c394b35b179bfb5d6a1681b84397c14ae17f9bc.1689258984.git.michal.simek@amd.com>
[-- Attachment #1: Type: text/plain, Size: 732 bytes --]
On Thu, Jul 13, 2023 at 04:36:27PM +0200, Michal Simek wrote:
> Code rewrites the last char of size with adding &. It is visible from
> dfu_alt_info print before this patch:
>
> Make dfu_alt_info: 'mtd nor0=bank0 raw 2320000 80000;bank1 raw 27a0000
> 8000&mtd nor0=bank0 raw 23a0000 4000000;bank1 raw 2820000 4000000'
>
> And after it:
> Make dfu_alt_info: 'mtd nor0=bank0 raw 2320000 80000;bank1 raw 27a0000
> 80000&mtd nor0=bank0 raw 23a0000 4000000;bank1 raw 2820000 4000000'
>
> Size for bank0 and bank1 must be the same because it is the same image.
>
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-07-25 21:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 14:36 [PATCH] fwu: mtd: Fix dfu_alt_info generation for 2 images per bank Michal Simek
2023-07-13 15:59 ` Jassi Brar
2023-07-25 21:13 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725211309.GL3630934@bill-the-cat \
--to=trini@konsulko.com \
--cc=git@xilinx.com \
--cc=jaswinder.singh@linaro.org \
--cc=masami.hiramatsu@linaro.org \
--cc=michal.simek@amd.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox