From: Tom Rini <trini@konsulko.com>
To: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Cc: Simon Glass <sjg@chromium.org>,
Stefan Herbrechtsmeier <stefan.herbrechtsmeier@weidmueller.com>,
Heiko Schocher <hs@denx.de>,
Tobias Waldekranz <tobias@waldekranz.com>,
Kever Yang <kever.yang@rock-chips.com>,
u-boot@lists.denx.de, "Andrew F . Davis" <afd@ti.com>
Subject: Re: [PATCH 1/1] part: eliminate part_get_info_by_name_type()
Date: Tue, 25 Jul 2023 17:13:35 -0400 [thread overview]
Message-ID: <20230725211335.GQ3630934@bill-the-cat> (raw)
In-Reply-To: <20230716113444.23238-1-heinrich.schuchardt@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
On Sun, Jul 16, 2023 at 01:34:44PM +0200, Heinrich Schuchardt wrote:
> Since commit 56670d6fb83f ("disk: part: use common api to lookup part
> driver") part_get_info_by_name_type() ignores the part_type parameter
> used to restrict the partition table type.
>
> omap_mmc_get_part_size() and part_get_info_by_name() are the only
> consumers.
>
> omap_mmc_get_part_size() calls with part_type = PART_TYPE_EFI because at
> the time of implementation a speed up could be gained by passing the
> partition table type. After 5 years experience without this restriction
> it looks safe to keep it that way.
>
> part_get_info_by_name() uses PART_TYPE_ALL.
>
> Move the logic of part_get_info_by_name_type() to part_get_info_by_name()
> and replace the function in omap_mmc_get_part_size().
>
> Fixes: 56670d6fb83f ("disk: part: use common api to lookup part driver")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-07-25 21:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 11:34 [PATCH 1/1] part: eliminate part_get_info_by_name_type() Heinrich Schuchardt
2023-07-19 1:08 ` Simon Glass
2023-07-19 2:17 ` Heinrich Schuchardt
2023-07-25 21:13 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725211335.GQ3630934@bill-the-cat \
--to=trini@konsulko.com \
--cc=afd@ti.com \
--cc=heinrich.schuchardt@canonical.com \
--cc=hs@denx.de \
--cc=kever.yang@rock-chips.com \
--cc=sjg@chromium.org \
--cc=stefan.herbrechtsmeier@weidmueller.com \
--cc=tobias@waldekranz.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox