From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5F01C0015E for ; Wed, 26 Jul 2023 16:57:48 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BC37D84751; Wed, 26 Jul 2023 18:57:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="SGx7eyju"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2FB938622D; Wed, 26 Jul 2023 18:57:32 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 11258860A6 for ; Wed, 26 Jul 2023 18:57:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=nm@ti.com Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 36QCpFoF086387; Wed, 26 Jul 2023 07:51:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1690375875; bh=D0INaUCOBNcfPexG5byxN7HxxkUgHYLOT3vw6MlniQY=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=SGx7eyjukP5GfT8K5fXBBhOQdIG4WW7372Rc+fpIOMWJF1nylAfmX5HEx7wx5UYMh ik5fEqRgbqok2+MGwTxLPN0vhkR1PXgPBTdwD/b92Nf0tKv9U5kOnFRh9qd02Kc4De lYOo09qmuWLOMqVqNZDkWLnddR9hiNczODEtqGb8= Received: from DFLE113.ent.ti.com (dfle113.ent.ti.com [10.64.6.34]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 36QCpFhA120552 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 26 Jul 2023 07:51:15 -0500 Received: from DFLE114.ent.ti.com (10.64.6.35) by DFLE113.ent.ti.com (10.64.6.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Wed, 26 Jul 2023 07:51:15 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Wed, 26 Jul 2023 07:51:15 -0500 Received: from localhost (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 36QCpFOI041888; Wed, 26 Jul 2023 07:51:15 -0500 Date: Wed, 26 Jul 2023 07:51:15 -0500 From: Nishanth Menon To: Maxime Ripard CC: Ravi Gunasekaran , Tom Rini , , Wadim Egorov , Francesco Dolcini , Sjoerd Simons , Neha Malcom Francis , Bryan Brattlof , Vignesh Raghavendra , Mattijs Korpershoek , Marcel Ziswiler , Roger Quadros Subject: Re: [PATCH 3/3] arm: dts: k3-am62: Bump dtsi from linux v6.5-rc1 Message-ID: <20230726125115.bugzqulyicy5gwef@study> References: <20230725125856.1807742-1-nm@ti.com> <20230725125856.1807742-4-nm@ti.com> <20230725140934.wxo7ndfkfvem5xhs@excitable> <20230725181742.GB3630934@bill-the-cat> <932d1dd9-c9e2-5853-fdd7-210d7fb15106@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 10:15-20230726, Maxime Ripard wrote: > On Wed, Jul 26, 2023 at 11:26:05AM +0530, Ravi Gunasekaran wrote: > > On 7/25/23 11:47 PM, Tom Rini wrote: > > > On Tue, Jul 25, 2023 at 09:09:34AM -0500, Nishanth Menon wrote: > > >> On 15:56-20230725, Maxime Ripard wrote: > > >>> Hi, > > >>> > > >>> On Tue, Jul 25, 2023 at 07:58:56AM -0500, Nishanth Menon wrote: > > >>>> Update the am62 and am625 device-trees from linux v6.3-rc5 This needed the followin > > >>>> tweaks to the u-boot specific dtsi as well: > > >>>> - Switch tick-timer to the main_timer as it's now defined in the main dtsi > > >>>> - Secure proxies are defined in Soc dtsis > > >>>> - Drop duplicate nodes - u-boot.dtsi is includes in r5-sk, no need for > > >>>> either the definitions from main.dtsi OR duplication from u-boot.dtsi > > >>>> - Add mdio pins to the cpsw3g pinctrl in u-boot dtsi. It moved to a subnode in the > > >>>> linux dtsi that u-boot doesn't use/support > > >>>> > > >>>> Cc: Francesco Dolcini > > >>>> Cc: Sjoerd Simons > > >>>> Cc: Wadim Egorov > > >>>> Signed-off-by: Nishanth Menon > > >>>> --- > > >>>> > > >>>> I decided not to pick up changes from Roger and Maxime as they are'nt > > >>>> regression fixes, instead the fixups can be done on top of the basic > > >>>> sync. > > >>> > > >>> This breaks Linux network interfaces so I very much considers this a regression. > > >> The current u-boot.dtsi I am confused - pinctrl mdio is still a > > >> problem, is'nt it? > > >> https://github.com/u-boot/u-boot/blob/master/arch/arm/dts/k3-am625-sk-u-boot.dtsi#L132 > > >> The follow on fixups from both your and Roger's series should fix things > > >> up, correct? > > > > > > I'm a little confused here too. For each of these cases, what happens? > > > - Today, one of these platforms, we pass the kernel the in-memory U-Boot > > > device tree. And if this is functional for networking, how/why? > > > > In here, the mdio pinctrl configuration is present only in one node (CPSW). > > So there is no conflict when the in-memory DT is passed by U-Boot to kernel. > > > > > - "Tomorrow", one of these platforms, with Nishanth's series applied, we > > > pass the in-memory U-Boot device tree > > > > In this case, the DT passed by U-Boot has the mdio pinctrl info present in > > two nodes - one in CPSW and other in MDIO. This causes failure in Linux as > > both nodes refer to same pinctrl configuration. > > Yeah, exactly. The "Tomorrow" case probably makes it functional for > U-Boot but breaks Linux in the process. It was functional in Linux > before because it has everything needed to set up the network and didn't > rely on U-Boot for that at all. > https://github.com/nmenon/fix-k3-dt-u-boot/commits/fdt-fixup-s1-am625-rev3.1 If we are willing to add the dependency of: https://lore.kernel.org/r/20230724-ti-mdio-pinmux-v4-1-18541f976501@kernel.org https://lore.kernel.org/r/20230722193151.117345-2-rogerq@kernel.org https://lore.kernel.org/r/20230722193151.117345-3-rogerq@kernel.org Tom, I need some guidance here - i can squash the fixup if the dependencies queued. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D