From: Yuepeng Xing <xingyuepeng@eswincomputing.com>
To: u-boot@lists.denx.de
Cc: zhuwenjun@eswincomputing.com, zhengyu@eswincomputing.com,
jinyanjiang@eswincomputing.com,
Yuepeng Xing <xingyuepeng@eswincomputing.com>
Subject: [PATCH] Remove unused parameters
Date: Fri, 28 Jul 2023 17:31:14 +0800 [thread overview]
Message-ID: <20230728093114.866-1-xingyuepeng@eswincomputing.com> (raw)
Remove unused parameters from function arch_env_get_location
Signed-off-by: Yuepeng Xing <xingyuepeng@eswincomputing.com>
---
arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 2 +-
arch/arm/mach-imx/imx8m/soc.c | 2 +-
board/theobroma-systems/puma_rk3399/puma-rk3399.c | 2 +-
env/env.c | 4 ++--
include/env_internal.h | 2 +-
5 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
index c11341a1d3..321900b6d5 100644
--- a/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
+++ b/arch/arm/cpu/armv8/fsl-layerscape/cpu.c
@@ -818,7 +818,7 @@ int mmc_get_env_dev(void)
}
#endif
-enum env_location arch_env_get_location(enum env_operation op, int prio)
+enum env_location arch_env_get_location(int prio)
{
enum boot_src src = get_boot_src();
enum env_location env_loc = ENVL_NOWHERE;
diff --git a/arch/arm/mach-imx/imx8m/soc.c b/arch/arm/mach-imx/imx8m/soc.c
index a4863281e3..1fe7011f07 100644
--- a/arch/arm/mach-imx/imx8m/soc.c
+++ b/arch/arm/mach-imx/imx8m/soc.c
@@ -1539,7 +1539,7 @@ void do_error(struct pt_regs *pt_regs)
#endif
#if defined(CONFIG_IMX8MN) || defined(CONFIG_IMX8MP)
-enum env_location arch_env_get_location(enum env_operation op, int prio)
+enum env_location arch_env_get_location(int prio)
{
enum boot_device dev = get_boot_device();
diff --git a/board/theobroma-systems/puma_rk3399/puma-rk3399.c b/board/theobroma-systems/puma_rk3399/puma-rk3399.c
index 97f398bd75..3b3f1b0e9f 100644
--- a/board/theobroma-systems/puma_rk3399/puma-rk3399.c
+++ b/board/theobroma-systems/puma_rk3399/puma-rk3399.c
@@ -140,7 +140,7 @@ int mmc_get_env_dev(void)
#error Please enable CONFIG_ENV_IS_NOWHERE
#endif
-enum env_location arch_env_get_location(enum env_operation op, int prio)
+enum env_location arch_env_get_location(int prio)
{
const char *boot_device =
ofnode_read_chosen_string("u-boot,spl-boot-device");
diff --git a/env/env.c b/env/env.c
index 69848fb060..a8a94d4e2a 100644
--- a/env/env.c
+++ b/env/env.c
@@ -128,7 +128,7 @@ static void env_set_inited(enum env_location location)
* Returns:
* an enum env_location value on success, a negative error code otherwise
*/
-__weak enum env_location arch_env_get_location(enum env_operation op, int prio)
+__weak enum env_location arch_env_get_location(int prio)
{
if (prio >= ARRAY_SIZE(env_locations))
return ENVL_UNKNOWN;
@@ -156,7 +156,7 @@ __weak enum env_location arch_env_get_location(enum env_operation op, int prio)
*/
__weak enum env_location env_get_location(enum env_operation op, int prio)
{
- return arch_env_get_location(op, prio);
+ return arch_env_get_location(prio);
}
/**
diff --git a/include/env_internal.h b/include/env_internal.h
index f30fd6159d..4aaa40d17c 100644
--- a/include/env_internal.h
+++ b/include/env_internal.h
@@ -246,7 +246,7 @@ const char *env_ext4_get_dev_part(void);
* highest priority
* Return: an enum env_location value on success, or -ve error code.
*/
-enum env_location arch_env_get_location(enum env_operation op, int prio);
+enum env_location arch_env_get_location(int prio);
/**
* env_get_location()- Provide the best location for the U-Boot environment
--
2.31.1.windows.1
next reply other threads:[~2023-07-28 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 9:31 Yuepeng Xing [this message]
2023-07-28 17:32 ` [PATCH] Remove unused parameters Simon Glass
-- strict thread matches above, loose matches on Subject: below --
2023-07-28 7:01 Shenlin Liang
2023-07-28 17:32 ` Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728093114.866-1-xingyuepeng@eswincomputing.com \
--to=xingyuepeng@eswincomputing.com \
--cc=jinyanjiang@eswincomputing.com \
--cc=u-boot@lists.denx.de \
--cc=zhengyu@eswincomputing.com \
--cc=zhuwenjun@eswincomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox