From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1224C00528 for ; Fri, 28 Jul 2023 09:53:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3438B868B1; Fri, 28 Jul 2023 11:53:24 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 2451B8689D; Fri, 28 Jul 2023 11:53:22 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by phobos.denx.de (Postfix) with ESMTP id 0A06C868B7 for ; Fri, 28 Jul 2023 11:53:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=abdellatif.elkhlifi@arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93A232F4; Fri, 28 Jul 2023 02:54:00 -0700 (PDT) Received: from e130802.arm.com (unknown [10.57.2.208]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 744053F67D; Fri, 28 Jul 2023 02:53:16 -0700 (PDT) Date: Fri, 28 Jul 2023 10:53:07 +0100 From: Abdellatif El Khlifi To: Simon Glass Cc: xypron.glpk@gmx.de, nd@arm.com, u-boot@lists.denx.de Subject: Re: [PATCH 2/6] arm_ffa: introduce armffa command Message-ID: <20230728095307.GA44498@e130802.arm.com> References: <20220329151659.16894-1-abdellatif.elkhlifi@arm.com> <20220329151659.16894-3-abdellatif.elkhlifi@arm.com> <14abbf36-f536-fb8c-2ac7-833c62f7fb4b@gmx.de> <20230727090027.GA23053@e130802.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon, Heinrich, On Thu, Jul 27, 2023 at 07:52:00PM -0600, Simon Glass wrote: > Hi Abdellatif, > > On Thu, 27 Jul 2023 at 03:00, Abdellatif El Khlifi > wrote: > > > > Hi Heinrich, > > > > On Thu, Jul 27, 2023 at 07:51:42AM +0200, Heinrich Schuchardt wrote: > > > On 3/29/22 17:16, abdellatif.elkhlifi@arm.com wrote: > > > > From: Abdellatif El Khlifi > > > > > > > > Provide armffa command showcasing the use of the FF-A driver > > > > > > > > The armffa command allows to query secure partitions data from > > > > the secure world and exchanging messages with the partitions. > > > > > > > > Signed-off-by: Abdellatif El Khlifi > > > > Cc: Tom Rini > > > > --- > > > > MAINTAINERS | 1 + > > > > cmd/Kconfig | 10 ++ > > > > cmd/Makefile | 2 + > > > > cmd/armffa.c | 266 ++++++++++++++++++++++++++++++++++++++++ > > > > drivers/arm-ffa/Kconfig | 1 + > > > > > > We want to have all commands to be documented in /doc/usage/cmd/. > > > > > > Could you, please, provide the missing /doc/usage/cmd/armffa.rst file. > > > > > > > It's here [1]. > > I'd suggest mentioning that in the commit message for this patch, or > even putting the testin the same patch, along with the test for the > command. I find it hard to keep track of this too. Please refer to the commit provided by the latest version (v17). In the commit message the path to doc/usage/cmd/armffa.rst is already given. Please refer to the commit [A]. The commit log says: For more details please refer to the command documentation [1]. [A]: https://lore.kernel.org/all/20230727160712.81477-6-abdellatif.elkhlifi@arm.com/ Cheers Abdellatif > > > > > [1]: https://lore.kernel.org/all/20230726094503.100497-6-abdellatif.elkhlifi@arm.com/#Z31doc:usage:cmd:armffa.rst > > > > Cheers, > > Abdellatif > > Regards, > Simon