From: Lukasz Majewski <lukma@denx.de>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de, "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Stefano Babic <sbabic@denx.de>
Subject: Re: [PATCH] arm: mxs: Fix ICOLL macro name typo
Date: Mon, 31 Jul 2023 10:04:54 +0200 [thread overview]
Message-ID: <20230731100454.3679600e@wsk> (raw)
In-Reply-To: <20230729132941.8633-1-marex@denx.de>
[-- Attachment #1: Type: text/plain, Size: 1468 bytes --]
On Sat, 29 Jul 2023 15:29:41 +0200
Marek Vasut <marex@denx.de> wrote:
> The interrupt collector macro name for i.MX23 is MXS_ICOLL_BASE,
> this is correct and matches the documentation of both i.MX23 and
> i.MX28. Align the i.MX28 macro accordingly. No functional change.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: "NXP i.MX U-Boot Team" <uboot-imx@nxp.com>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
> arch/arm/include/asm/arch-mxs/regs-base.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/include/asm/arch-mxs/regs-base.h
> b/arch/arm/include/asm/arch-mxs/regs-base.h index
> 44d40cade87..33d2ab5230f 100644 ---
> a/arch/arm/include/asm/arch-mxs/regs-base.h +++
> b/arch/arm/include/asm/arch-mxs/regs-base.h @@ -60,7 +60,7 @@
> * Register base addresses for i.MX28
> */
> #elif defined(CONFIG_MX28)
> -#define MXS_ICOL_BASE 0x80000000
> +#define MXS_ICOLL_BASE 0x80000000
> #define MXS_HSADC_BASE 0x80002000
> #define MXS_APBH_BASE 0x80004000
> #define MXS_PERFMON_BASE 0x80006000
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-07-31 8:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-29 13:29 [PATCH] arm: mxs: Fix ICOLL macro name typo Marek Vasut
2023-07-31 8:04 ` Lukasz Majewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230731100454.3679600e@wsk \
--to=lukma@denx.de \
--cc=festevam@gmail.com \
--cc=marex@denx.de \
--cc=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
--cc=uboot-imx@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox