From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D4A5C001DF for ; Mon, 31 Jul 2023 13:20:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B9D3786A6A; Mon, 31 Jul 2023 15:20:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=sberdevices.ru Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=sberdevices.ru header.i=@sberdevices.ru header.b="dhQdoyYk"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 803D886A6C; Mon, 31 Jul 2023 15:20:16 +0200 (CEST) Received: from mx1.sberdevices.ru (mx2.sberdevices.ru [45.89.224.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D10C086A64 for ; Mon, 31 Jul 2023 15:20:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=sberdevices.ru Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=IVPrusov@sberdevices.ru Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id E169F120004; Mon, 31 Jul 2023 16:20:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru E169F120004 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1690809612; bh=7uHvfmS4GJCbPhVSCPf3ZYv5v1AecHi4WNDwEMJkpJI=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type:From; b=dhQdoyYkeAfF1q8hShEpDoEbwKe8492limv+6oaJ1r4zz1glG7JJWPKWy+KOr21/b 6h0Sa2m8qEUejx5jQ+/xJ4SKMDVfCuw05tJXIY9MyAmGt6aMZvT8TfKHi5zwHUwfkv GqOy6ETulNb5FqIsf4+9Yx5VFxMLqrm/XAGo8WFpXL5FawBnHwrVpxaaGn8EL3DGFf MCXo6JsAgE03fdP7IkTV1Q2XlMASRMVnfAXmcbeNIycEepsx0iemq05+vGX0zZpJs+ curVauguM8uCpUMRojud4dekQwYGeQPCdgiiMcgM/LCc2YcMqQsZ8XP5woNoXi+jWA q+NZ/9fsXWLaw== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Mon, 31 Jul 2023 16:20:12 +0300 (MSK) Received: from pc (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Mon, 31 Jul 2023 16:19:23 +0300 Date: Mon, 31 Jul 2023 16:20:05 +0300 From: Igor Prusov To: Michal Simek , Daniel Schwierzeck , Lukasz Majewski , Sean Anderson , Ryan Chen , Chia-Wei Wang , Aspeed BMC SW team , Joel Stanley , Stefan Roese , Patrick Delaunay , Patrice Chotard , CC: , , , Subject: Re: [PATCH v3 0/7] clk: Switch from soc_clk_dump to clk_ops function Message-ID: <20230731132005.57n24arwh6bcxpco@pc> References: <20230714152444.24395-1-ivprusov@sberdevices.ru> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230714152444.24395-1-ivprusov@sberdevices.ru> X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 178796 [Jul 22 2023] X-KSMG-AntiSpam-Version: 5.9.59.0 X-KSMG-AntiSpam-Envelope-From: IVPrusov@sberdevices.ru X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 525 525 723604743bfbdb7e16728748c3fa45e9eba05f7d, {Track_E25351}, {Tracking_from_domain_doesnt_match_to}, FromAlignment: s, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/07/23 08:49:00 #21663637 X-KSMG-AntiVirus-Status: Clean, skipped X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean +Simon Glass Hi Simon, Apologies for the ping, but could you please take a look at this series? There was not much feedback after a while, so I'd like to understand whether proposed fix is viable or not. On Fri, Jul 14, 2023 at 06:24:37PM +0300, Igor Prusov wrote: > Currently clock providers may override default implementation of > soc_clk_dump function to replace clk dump command output. This causes > confusing behaviour when u-boot is built with one of such drivers > enabled but still has clocks defined using CCF. For example, enabling > CMD_CLK and using clk dump on sandbox target will not show CCF clocks > because k210 driver overrides common soc_clk_dump. > > Changelog: > v1 -> v2: > - Add missing static to dump functions > v2 -> v3: > - Make soc_clk_dump in cmd/clk.c static instead of removing __weak > > Igor Prusov (7): > clk: zynq: Move soc_clk_dump to Zynq clock driver > clk: ast2600: Move soc_clk_dump function > clk: k210: Move soc_clk_dump function > clk: Add dump operation to clk_ops > cmd: clk: Use dump function from clk_ops > clk: treewide: switch to clock dump from clk_ops > cmd: clk: Make soc_clk_dump static > > arch/arm/mach-zynq/clk.c | 57 -------------- > arch/mips/mach-pic32/cpu.c | 23 ------ > cmd/clk.c | 13 +++- > drivers/clk/aspeed/clk_ast2600.c | 83 ++++++++++---------- > drivers/clk/clk_k210.c | 103 ++++++++++++------------- > drivers/clk/clk_pic32.c | 39 ++++++++++ > drivers/clk/clk_versal.c | 7 +- > drivers/clk/clk_zynq.c | 51 ++++++++++++ > drivers/clk/clk_zynqmp.c | 13 ++-- > drivers/clk/imx/clk-imx8.c | 11 +-- > drivers/clk/mvebu/armada-37xx-periph.c | 5 +- > drivers/clk/stm32/clk-stm32mp1.c | 29 ++----- > include/clk-uclass.h | 3 + > include/clk.h | 2 - > 14 files changed, 223 insertions(+), 216 deletions(-) > > -- > 2.34.1 > -- Best Regards, Igor Prusov