From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3F98C001DF for ; Mon, 31 Jul 2023 15:12:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E4D2D86941; Mon, 31 Jul 2023 17:12:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="epR4Fpdt"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1571086971; Mon, 31 Jul 2023 17:12:19 +0200 (CEST) Received: from mail-yw1-x112c.google.com (mail-yw1-x112c.google.com [IPv6:2607:f8b0:4864:20::112c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C1FCE8690D for ; Mon, 31 Jul 2023 17:12:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112c.google.com with SMTP id 00721157ae682-5839f38342fso49037427b3.0 for ; Mon, 31 Jul 2023 08:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1690816335; x=1691421135; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Z4p55Y8fCqExp6x2YRn4M1lJ/k6VUX3k017pleUp7YE=; b=epR4FpdtLRi/Um2GHgumBrZgPS5ftosOE4/cijFjxWm0SzjNy4MPI8o/pmejaTiDht BZfVR7a6roHf3xIbjRicG+hUPcLo2GP6MANyd9IYeWT9vSRZzv0mjdE/7mde0K2hH3Pl x3v1ezVJatwiCiMtVijLmNcSvRGOl/ckS9A7I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690816335; x=1691421135; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Z4p55Y8fCqExp6x2YRn4M1lJ/k6VUX3k017pleUp7YE=; b=TDqFGSws7uCrsielbLoUT3ch3d4JokQtyUmRMuk6RWpZANZ65ZBkxUr2xa5nDdtZy3 c+J9EhBu1NXUxhegUYu1IiWwq+BN61Dz0TZwTBhLK5Rv9pCCJlpf8crTnrOMhBzQIzk6 +CMhshXyBh7FreSCE5TbDv3OHR6+cQGlbJunq+kq0RohtJlCuT6hsiw96SFkXjYZmgUR pEgo9gqOEjcCot29bN3+Yivum4/ekimb35StQA37lMvrCx6hI/JQ35hwbNrjClG2TyXY Axr/5ebSSlEJbQG07yqoRhgFprVxx/zLxNe3EcU0JPiUtP31agAlhZ4OXe2n6y5mTUQc e/dQ== X-Gm-Message-State: ABy/qLbPS3IU6EiW1odeRjmbGrt4AUZAuO0PA7IVAF4CCVbdeAUuluDz DFiK2sGGmkscip+JZ/hTrY2IkQ== X-Google-Smtp-Source: APBJJlFdyHcv56X3jg10QPb/yNXjmBAPVT5AnFLfNRQNyVtLgMaB3b4DUx1xsnQbjgiV6HJKAOme9A== X-Received: by 2002:a81:a015:0:b0:573:4d8b:471f with SMTP id x21-20020a81a015000000b005734d8b471fmr11000402ywg.26.1690816335376; Mon, 31 Jul 2023 08:12:15 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-7e50-54e3-e9cb-536d.res6.spectrum.com. [2603:6081:7b00:6400:7e50:54e3:e9cb:536d]) by smtp.gmail.com with ESMTPSA id l5-20020a0dfb05000000b0057069c60799sm3104809ywf.53.2023.07.31.08.12.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 08:12:14 -0700 (PDT) Date: Mon, 31 Jul 2023 11:12:13 -0400 From: Tom Rini To: Siddharth Vadapalli Cc: joe.hershberger@ni.com, rfried.dev@gmail.com, sjg@chromium.org, u-boot@lists.denx.de, s-anna@ti.com, srk@ti.com Subject: Re: [PATCH 3/6] net: ti: am65-cpsw-nuss: Add logic to support MDIO reset Message-ID: <20230731151213.GU3630934@bill-the-cat> References: <20230708104523.228257-1-s-vadapalli@ti.com> <20230708104523.228257-4-s-vadapalli@ti.com> <20230721193617.GA722016@bill-the-cat> <628ac8ae-7c58-0ffb-292d-3fe831e168af@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YtsMAP26dxg1+x0K" Content-Disposition: inline In-Reply-To: <628ac8ae-7c58-0ffb-292d-3fe831e168af@ti.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --YtsMAP26dxg1+x0K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 31, 2023 at 02:06:26PM +0530, Siddharth Vadapalli wrote: >=20 >=20 > On 31/07/23 10:13, Siddharth Vadapalli wrote: > > Tom, > >=20 > > On 22/07/23 01:06, Tom Rini wrote: > >> On Sat, Jul 08, 2023 at 04:15:20PM +0530, Siddharth Vadapalli wrote: > >> > >>> From: Suman Anna > >>> > >>> Enhance the AM65 CPSW NUSS driver to perform a MDIO reset using a GPIO > >>> line. Logic is also added to perform a pre and post delay around reset > >>> using the optional 'reset-delay-us' and 'reset-post-delay-us' propert= ies. > >>> This is similar to the reset being performed in the Linux kernel. The > >>> reset is done once when the CPSW MDIO bus is being initialized. > >>> > >>> Signed-off-by: Suman Anna > >>> Signed-off-by: Siddharth Vadapalli > >>> --- > >>> drivers/net/ti/am65-cpsw-nuss.c | 34 +++++++++++++++++++++++++++++++= +- > >>> 1 file changed, 33 insertions(+), 1 deletion(-) > >> > >> So this breaks building on am62x_evm_a53 because now TI_AM65_CPSW_NUSS > >> needs to select DM_GPIO. And the next problem is that we don't enable= a > >> GPIO driver on that platform as we should I suspect make DA8XX_GPIO > >> default y if K3. > >=20 > > Sorry for the delayed response. I am planning to address this issue by = using: > > #if CONFIG_IS_ENABLED(DM_GPIO) >=20 > Instead of CONFIG_IS_ENABLED(DM_GPIO), I will use: > if (IS_ENABLED(CONFIG_DM_GPIO)) { > in the functions. That will break SPL, if that's a use case on these platforms. Please check that whatever approach you take doesn't break other platforms nor include code when not required on other platforms. --=20 Tom --YtsMAP26dxg1+x0K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTHz0kACgkQFHw5/5Y0 tyxuEwv9HOGNd6YBgUfYXyt+DHgIkgwYp25+umtEBwc+Y6K7Qgv9Zwrs5K8hKJvQ r2RZVRdHX4nmvkE/rOQkjU6yeo63GZAiR9RhwXAhdo7UPKcAGcuLC04ymfQ7hqVy b2eZHnc9oWZRs5hWx1lyAk7kNiQCwTjbUB13XJ63a/0wMO3K95d4g/1dCUQqHceu AZevksANaAjtGtfiGKTC1hVfephfM2zazwboFEegOyWtaMjYC6kYKwI2cCM4Eolj qA642eVMgDIn9V1HhqfovVhxbHoou606I6QpOUN2rg9BXtFB1DUVJBXgn1e8fN7z bQG1lTV2lOqUzvsmyEIB61Jl7vzsz3ummTJllsEMz6oa76ho52Lev0dJH6n9KQpE /y4RaMGUxVx59zHWvsLTPkHMwGJ6gx4SjxcZ+0QUP4ZP1duG2m3Y2Vx6gbqkARNs 4ZxMUSDMg16tGBnn7MWp6+76ySE1qPPjtE21The+wIu2HtC55RunTVKXT7xBo2XN oodQjD44 =zf7s -----END PGP SIGNATURE----- --YtsMAP26dxg1+x0K--