From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E3FEC001DC for ; Mon, 31 Jul 2023 14:25:29 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B938286941; Mon, 31 Jul 2023 16:25:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="nwqrTlGN"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2E972869F3; Mon, 31 Jul 2023 16:25:26 +0200 (CEST) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 9E4F986374 for ; Mon, 31 Jul 2023 16:25:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 801BA4000C; Mon, 31 Jul 2023 14:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690813523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+bVK2OFf/Bf0pkOT/MnjgB7j8P/yygNyyzn1ZjQWEGw=; b=nwqrTlGNl8SopyUzMiqFdfJob2Pu00loxuhN7Qi+Is+ottajeCqcfODRphETJuZ/sbgVok p9gK470OgMAK0yIWr7rJ2m4QtdjNkisczvVWqAZFK7Hd5ZOiUg/x+EIAIQx26wTnlDKcsd Z7Q9Eo/QoGHyKsehfsQgvoY9paZqhkgjE0ogNWBtDqHqKrKONgxFfTRNJjVNpPTba73uTI I/sHIDy+wuYSeAl/HHPHD4DPAFO6Cz4i7/gx7ulIryvGTjXGpyf9XTyg7+GA+eqJgcs852 vVOF3fZqtgw6wwhXGNPnkMNDIR/H0Lac6Dub9xYNFHGNepgiAwy4b4StYzDmmg== Date: Mon, 31 Jul 2023 16:25:20 +0200 From: Miquel Raynal To: Marek Vasut Cc: u-boot@lists.denx.de, Kevin Hilman , Lukasz Majewski , Simon Glass Subject: Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter Message-ID: <20230731162520.3897ba88@xps-13> In-Reply-To: <830897a6-d061-f7c8-8f30-7ccc906b53a4@denx.de> References: <20230729145712.213945-1-marex@denx.de> <20230731113159.26e710aa@xps-13> <20230731153607.6210e92f@xps-13> <8c31ee42-36c4-beab-853b-45f7828908a6@denx.de> <20230731155857.1575f5a4@xps-13> <830897a6-d061-f7c8-8f30-7ccc906b53a4@denx.de> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-GND-Sasl: miquel.raynal@bootlin.com X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Marek, marex@denx.de wrote on Mon, 31 Jul 2023 16:08:19 +0200: > On 7/31/23 15:58, Miquel Raynal wrote: > > Hi Marek, > > > > marex@denx.de wrote on Mon, 31 Jul 2023 15:50:58 +0200: > > > >> On 7/31/23 15:36, Miquel Raynal wrote: > >>> Hi Marek, > >>> > >>> marex@denx.de wrote on Mon, 31 Jul 2023 13:44:25 +0200: > >>> >>>> On 7/31/23 11:31, Miquel Raynal wrote: > >>>>> Hi Marek, > >>>>> > >>>>> marex@denx.de wrote on Sat, 29 Jul 2023 16:57:09 +0200: > >>>>> >>>> Extend the driver core to perform lookup by both OF node and driver > >>>>>> bound to the node. Use this to look up specific device instances to > >>>>>> unbind from nodes in the unbind command. One example where this is > >>>>>> needed is USB peripheral controller, which may have multiple gadget > >>>>>> drivers bound to it. The unbind command has to select that specific > >>>>>> gadget driver instance to unbind from the controller, not unbind the > >>>>>> controller driver itself from the controller. > >>>>>> > >>>>>> USB ethernet gadget usage looks as follows with this change. Notice > >>>>>> the extra 'usb_ether' addition in the 'unbind' command at the end. > >>>>>> " > >>>>>> bind /soc/usb-otg@49000000 usb_ether > >>>>>> setenv ethact usb_ether > >>>>>> setenv loadaddr 0xc2000000 > >>>>>> setenv ipaddr 10.0.0.2 > >>>>>> setenv serverip 10.0.0.1 > >>>>>> setenv netmask 255.255.255.0 > >>>>>> tftpboot 0xc2000000 10.0.0.1:test.file > >>>>>> unbind /soc/usb-otg@49000000 usb_ether > >>>>>> " > >>>>>> > >>>>>> Signed-off-by: Marek Vasut > >>>>>> --- > >>>>> > >>>>> I am no longer getting wrong pointer dereferences, the SPL is working in > >>>>> recovery mode, TFTP "File not found" errors are no longer a problem and > >>>>> I did not experience any reset while tftp'ing regular files. > >>>>> > >>>>> One last remaining request on my side is the need for using fastboot as > >>>>> well which does no longer work as-is: > >>>>> >>> => fastboot usb 0 > >>>>> couldn't find an available UDC > >>>>> g_dnl_register: failed!, error: -19 > >>>>> exit not allowed from main input shell. > >>>>> > >>>>> Can you advise what bind/unbind command would be necessary here? > >>>> > >>>> Either 'unbind usb_ether' or run 'dm tree' -> look up the path to usb_ether in the tree (it will be hanging under usb_peripheral or some such), and then use 'unbind '. > >>> > >>> Nice `dm tree` command, never used it before. > >>> > >>> Even when I unbind usb_ether I still get the same error: > >>> >>> => unbind /ocp/usb@47400000/usb@47401000 > >>> => fastboot usb 0 > >>> couldn't find an available UDC > >>> g_dnl_register: failed!, error: -19 > >>> exit not allowed from main input shell. > >>> > >>> Is there a specific gadget driver which I should bind again manually? > >> > >> Can you share the output of dm tree before/after unbind ? > >> > >> fastboot should auto-bind to the right thing. > > > > Ok. Apparently it does not, but I don't have any clue why. If you want > > me to check something else I will. Here is the output: > > > > U-Boot 2023.07-00806-g979e7443428 (Jul 31 2023 - 11:17:06 +0200) > > [...] > > > watchdog 0 [ + ] omap3_wdt | |-- wdt@44e35000 > > misc 0 [ + ] ti-musb-wrapper | |-- usb@47400000 > > usb 0 [ + ] ti-musb-peripheral | | |-- usb@47401000 > > ethernet 1 [ + ] usb_ether | | | `-- usb_ether > > bootdev 3 [ ] eth_bootdev | | | `-- usb_ether.bootdev > > usb 0 [ ] ti-musb-host | | `-- usb@47401800 > > ethernet 0 [ + ] eth_cpsw | |-- ethernet@4a100000 > > bootdev 2 [ ] eth_bootdev | | `-- ethernet@4a100000.bootdev > > simple_bus 67 [ ] ti_sysc | |-- target-module@53100000 > > simple_bus 68 [ ] ti_sysc | |-- target-module@53500000 > > simple_bus 69 [ ] ti_sysc | `-- target-module@56000000 > > clk 62 [ ] fixed_clock |-- clk_mcasp0_fixed > > bootstd 0 [ ] bootstd_drv |-- bootstd > > bootmeth 0 [ ] bootmeth_efi | |-- efi > > bootmeth 1 [ ] bootmeth_extlinux | |-- extlinux > > bootmeth 2 [ ] bootmeth_pxe | |-- pxe > > bootmeth 3 [ ] vbe_simple | `-- vbe_simple > > timer 0 [ + ] omap_timer `-- timer@0 > > => unbind /ocp/usb@47400000/usb@47401000 > > The commit message of this patch contains the following example: > unbind /soc/usb-otg@49000000 usb_ether > so in your case, try > unbind /ocp/usb@47400000/usb@47401000 usb_ether Does not work, unfortunately: => unbind /ocp/usb@47400000/usb@47401000 usb_ether Cannot find a device with path /ocp/usb@47400000/usb@47401000 => unbind /ocp/usb@47400000/usb@47401000 =>