From: Eugen Hristev <eugen.hristev@collabora.com>
To: kever.yang@rock-chips.com, u-boot@lists.denx.de
Cc: marex@denx.de, jonas@kwiboo.se, jagan@edgeble.ai,
eugen.hristev@collabora.com, kernel@collabora.com
Subject: [PATCH v2 01/10] rockchip: allow env defines for SPL build
Date: Tue, 1 Aug 2023 10:28:02 +0300 [thread overview]
Message-ID: <20230801072811.10354-2-eugen.hristev@collabora.com> (raw)
In-Reply-To: <20230801072811.10354-1-eugen.hristev@collabora.com>
For environment in SPL, all these defines are required, otherwise
build fails:
[...]
include/env_default.h:120:9: note: in expansion of macro ‘CFG_EXTRA_ENV_SETTINGS’
120 | CFG_EXTRA_ENV_SETTINGS
| ^~~~~~~~~~~~~~~~~~~~~~
In file included from env/common.c:32:
[...]
Environment in SPL is needed e.g. for DFU, as dfu_alt is kept as
env variable.
Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com>
---
include/configs/rockchip-common.h | 4 ----
1 file changed, 4 deletions(-)
diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
index 9121bba37384..be20b135066e 100644
--- a/include/configs/rockchip-common.h
+++ b/include/configs/rockchip-common.h
@@ -11,8 +11,6 @@
#define CFG_CPUID_OFFSET 0x7
#endif
-#ifndef CONFIG_SPL_BUILD
-
#define BOOT_TARGETS "mmc1 mmc0 nvme scsi usb pxe dhcp spi"
#ifdef CONFIG_ARM64
@@ -28,6 +26,4 @@
"name=boot,size=112M,bootable,uuid=${uuid_gpt_boot};" \
"name=rootfs,size=-,uuid="ROOT_UUID
-#endif
-
#endif /* _ROCKCHIP_COMMON_H_ */
--
2.34.1
next prev parent reply other threads:[~2023-08-01 7:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 7:28 [PATCH v2 00/10] rockchip: rk3588: add support for DFU in SPL Eugen Hristev
2023-08-01 7:28 ` Eugen Hristev [this message]
2023-08-12 2:45 ` [PATCH v2 01/10] rockchip: allow env defines for SPL build Kever Yang
2023-08-01 7:28 ` [PATCH v2 02/10] usb: dwc3: core: improve reset sequence Eugen Hristev
2023-08-01 11:44 ` Marek Vasut
2023-08-01 7:28 ` [PATCH v2 03/10] usb: dwc3: gadget: Don't send unintended link state change Eugen Hristev
2023-08-01 11:44 ` Marek Vasut
2023-08-01 7:28 ` [PATCH v2 04/10] usb: dwc3: core: Only handle soft-reset in DCTL Eugen Hristev
2023-08-01 11:44 ` Marek Vasut
2023-08-01 7:28 ` [PATCH v2 05/10] usb: dwc3: Increase DWC3 controller halt timeout Eugen Hristev
2023-08-01 11:44 ` Marek Vasut
2023-08-01 7:28 ` [PATCH v2 06/10] ARM: dts: rockchip: rk3588-rock-5b-u-boot: add bootph-all to gadget nodes Eugen Hristev
2023-08-12 2:53 ` Kever Yang
2023-08-13 6:59 ` Eugen Hristev
2023-08-01 7:28 ` [PATCH v2 07/10] ARM: mach-rockchip: spl-boot-order: add possibility to DFU Eugen Hristev
2023-08-12 2:52 ` Kever Yang
2023-08-01 7:28 ` [PATCH v2 08/10] ARM: mach-rockchip: rk3588: add gadget device to the boot order Eugen Hristev
2023-08-01 7:28 ` [PATCH v2 09/10] rockchip: rk3588: prepare env for DFU Eugen Hristev
2023-08-01 7:28 ` [PATCH v2 10/10] configs: rockchip: rock5b-rk3588: enable DFU and related configs Eugen Hristev
2023-08-12 2:53 ` Kever Yang
2023-09-21 14:47 ` [PATCH v2 00/10] rockchip: rk3588: add support for DFU in SPL Eugen Hristev
2023-09-22 0:48 ` Kever Yang
2023-09-22 9:57 ` Eugen Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801072811.10354-2-eugen.hristev@collabora.com \
--to=eugen.hristev@collabora.com \
--cc=jagan@edgeble.ai \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox