From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 870B4C001E0 for ; Tue, 1 Aug 2023 12:59:11 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B83F886BFF; Tue, 1 Aug 2023 14:59:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1690894749; bh=LdPUDbSd5lFnh8GfrzlvEYSy0GQ4qZ2EJZWnx30VJZY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=ybREayicnUfFusbqdkEnA32cVQ8yjbrhOnxxkX1ZmHNCYdN10QmTmRLydaDCyil76 X/ARkappdV83JBmCH3+/I7wIS5cWUi9S+nOmcbUhTBollvXsHqpK6WWjX8ojM9LYkm 9HJ+MXnDWcdbiAJkyN7WfxmLrcfwdDSJC7WiqAxNcmcn+IcEQyTZF5fznccfVmicUS fv8ax9U5hQz2faONdodFgOqDxKi+hNiGyMSsHUVLQwH7G8hJi6YOF+BM5KrXGD1jkM DhHQZmurJ5OzyKyUhk+UCNlOrOGKfIHE7yG87bpuqHKvw0hkMkHTSOakR8hlV7lVdL 73z2q38vLIt4A== Received: from crub (pd95f1a1c.dip0.t-ipconnect.de [217.95.26.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: agust@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 4647386ABF; Tue, 1 Aug 2023 14:59:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1690894748; bh=LdPUDbSd5lFnh8GfrzlvEYSy0GQ4qZ2EJZWnx30VJZY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Hyi8IX9M0BVykDIOjUPsXUCuYSOe+fMceE/IL8aa5xPHqh0z1ez0tscJFTfVrv0Se ejoiNRt7bfXV0XuvuGni5nqMLqMJ6Xo5W78LVUAuwShC+f/5FJUGoj2ktPA1e/T4aN VMNKDE5r7IVFRJ7wSto36/lGSjHykIbbrzHJUMh7WHPs5v2dO3Y7SgNvuzL91kXQwx ffnEeVwveAt21Zv8HhKSJSLu4ecLE0kxM0TABiBo60dsQzSjzhcWSfe4rcTqAqrSrV ai9bRF0t81lydY6Y5m1RfHdTgzvly6+7DKe1XseHRWHUWwjl+vSvWvf4b81ek27mzc TcFQH2ocT9WiA== Date: Tue, 1 Aug 2023 14:59:07 +0200 From: Anatolij Gustschin To: Bin Meng Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH 03/18] video: bochs: Drop the useless argument of bochs_vga_write() Message-ID: <20230801145907.0fbbc59a@crub> In-Reply-To: <20230723044041.1089804-4-bmeng@tinylab.org> References: <20230723044041.1089804-1-bmeng@tinylab.org> <20230723044041.1089804-4-bmeng@tinylab.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sun, 23 Jul 2023 12:40:26 +0800 Bin Meng bmeng@tinylab.org wrote: > bochs_vga_write() takes 'index' as one argument, but never uses it. > > While we are here, use macros instead of magic numbers for the > VGA IO port register name and value. > > Signed-off-by: Bin Meng > --- > > drivers/video/bochs.c | 7 ++++--- > drivers/video/bochs.h | 5 ++++- > 2 files changed, 8 insertions(+), 4 deletions(-) applied to u-boot-video/master, thanks! -- Anatolij