From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E368BC001E0 for ; Tue, 1 Aug 2023 12:59:38 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4EA8286C4C; Tue, 1 Aug 2023 14:59:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1690894777; bh=TH/ZcbFteBjNUABWFwdQhfLcMju3PG/QFuZwXbQfFSU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=xDNLh2VpVyUy+FTrHdA93OHic3gydPqSnkH16TK+9aRRVU+sQVSt7M6erwy/AyT9Y CWBhp31VmRt5F/4HEEV8I2+ttqbsu5Z7QPfeuFmKSkDSKl3JfHGEmGuVGAbh+Ip6WT o5eWD2SdXhdZEhxRMnoaodhMLqWBtxpJS+hDs6u1CcBKc6k8PMwpmZ2pY8sHucPu94 X2cT2xTAwap+Q1uZ26aiIkhY83dM8vAMZfS5OXbbwfZSUc6MNBNJ/wM2PB5HMhp6tN ZBp75PwcFpjJLe2Hd44SpnP6AsKkl0+yO5YYenTzkOQ372X2JRotZQy6IAVuWxG6yQ gNXr2H1W6x4tQ== Received: from crub (pd95f1a1c.dip0.t-ipconnect.de [217.95.26.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: agust@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id A46AE86ABF; Tue, 1 Aug 2023 14:59:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1690894776; bh=TH/ZcbFteBjNUABWFwdQhfLcMju3PG/QFuZwXbQfFSU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=v+ENppXAnYvyN97Le8BSAT2BN4b0AA8JyxXd1+q1pyGY+0HByPXHD17ll9Zbdcg// BU/Lmczir57vaSZHmbyNQ+PIGWjE6hcbAMFS+6g+Wi0bDewWLrVvFzjg1V5wc9dtVw gwHlPOxofoeWPWHzuDQ2a/6L3FhtFTccdwgrhBxB984bhIQNpliACLyYMXsh0clQwY fPy3kS+wMxKLJCr64k8kUgltQ3lotHrWEJ4W5psSvn2BLiHrOj+ej65J8M9sz0plIs r5CRQ7fMPwY7R/I8+kPKio2GzgpHghimw8to1Pi7/AWcxYBOuM3gNkXoiS25YEk/WP qKi4D+c9XIOBg== Date: Tue, 1 Aug 2023 14:59:35 +0200 From: Anatolij Gustschin To: Bin Meng Cc: Simon Glass , u-boot@lists.denx.de Subject: Re: [PATCH 04/18] video: bochs: Avoid using IO instructions to access VGA IO port Message-ID: <20230801145935.207e70b9@crub> In-Reply-To: <20230723044041.1089804-5-bmeng@tinylab.org> References: <20230723044041.1089804-1-bmeng@tinylab.org> <20230723044041.1089804-5-bmeng@tinylab.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Sun, 23 Jul 2023 12:40:27 +0800 Bin Meng bmeng@tinylab.org wrote: > At present the driver uses IO instructions to access the legacy > VGA IO ports, which unfortunately limits the driver to work only > on x86. It turns out the IO instruction is not necessary as Bochs > VGA card remaps the legacy VGA IO ports (0x3c0 -> 0x3df) to its > memory mapped register space from offset 0x400. > > Update the driver to use MMIO access for VGA IO port. > > Signed-off-by: Bin Meng > --- > > drivers/video/bochs.c | 6 +++--- > drivers/video/bochs.h | 4 +--- > 2 files changed, 4 insertions(+), 6 deletions(-) applied to u-boot-video/master, thanks! -- Anatolij