From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 07446C0015E for ; Tue, 1 Aug 2023 15:14:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C3AB786C8A; Tue, 1 Aug 2023 17:14:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="CbIqtq9t"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 1803386C97; Tue, 1 Aug 2023 17:14:18 +0200 (CEST) Received: from mail-yw1-x1133.google.com (mail-yw1-x1133.google.com [IPv6:2607:f8b0:4864:20::1133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id DB21686C14 for ; Tue, 1 Aug 2023 17:14:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1133.google.com with SMTP id 00721157ae682-58653c9bed3so11852377b3.2 for ; Tue, 01 Aug 2023 08:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1690902854; x=1691507654; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=zy3Cw1JI0KxdfXqKvtjgFhZwu+JAC0oHxHcMD5pQffM=; b=CbIqtq9t6LQ8uqSpzBLjBqHd2MDF4oO28HLZdrwTo9cSEczjhD1rnpP1+2LL7szcAP kO94ZRpxEiX5TaU85I6xIz46VBSiw3EMD653qgrQLl7gNOLNS2H7BnuSrMQqdlEOyas/ QwiE+DD9q8fHtWQIwWnPHj5CgfTVVxfwsY61s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690902854; x=1691507654; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zy3Cw1JI0KxdfXqKvtjgFhZwu+JAC0oHxHcMD5pQffM=; b=YbhoRM9dmrh+aLR2fOX6ll3bLDr/iloC74B+2TA77mXbqaecNoFoa2qJjhRinhOcnT SJyCy3QCbM7+Z4gg3JERmysxoNGowHCTBBJ7brgTexxbv82mvGO17X6Oo1yFxRE9nSwo bMauHGj0hawnaJ+pfgrXdZtJ5zIKplgf0ZvV6KMrW8LEI39ATIP70mqOinBFK8kKeowj UCPTnesxouLPWkk3+HGaEdnkcNLc9W/uaQDgoaIMG4ppXcEoceyPUkGizAJ4HELhloLn h2h2jhpV9+KUjYdOQDOAiYANnf6IbSv6dGMra26gxxHlRm8GZaE/YFfyPKXNS7wLvZZK 7BhQ== X-Gm-Message-State: ABy/qLYdhdhuoB2IbmlYYMOvFGIO0Mo6h0ckKe1AaIW5CxrGM/KPuAkt FyIBNoyMaAee4cs0SLNa0IhYtg== X-Google-Smtp-Source: APBJJlFzEV39vW+auxQ+85fGo9PfRAfbWDvKVGH44tnI13783jeej+CKe7Xrw+n15Q35JSySslWNbQ== X-Received: by 2002:a81:9242:0:b0:583:9c78:9a84 with SMTP id j63-20020a819242000000b005839c789a84mr12824564ywg.43.1690902854518; Tue, 01 Aug 2023 08:14:14 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-383c-c9ce-d23d-78ae.res6.spectrum.com. [2603:6081:7b00:6400:383c:c9ce:d23d:78ae]) by smtp.gmail.com with ESMTPSA id n20-20020a0dcb14000000b005772abf6234sm3845714ywd.11.2023.08.01.08.14.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Aug 2023 08:14:14 -0700 (PDT) Date: Tue, 1 Aug 2023 11:14:12 -0400 From: Tom Rini To: Heinrich Schuchardt Cc: Simon Glass , Pali =?iso-8859-1?Q?Roh=E1r?= , u-boot@lists.denx.de Subject: Re: [PATCH 1/1] common: fix detection of SYS_MALLOC_F_LEN=0x0 Message-ID: <20230801151412.GP3630934@bill-the-cat> References: <20230801133341.105298-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="toN9bR+Yg/35TW2b" Content-Disposition: inline In-Reply-To: <20230801133341.105298-1-heinrich.schuchardt@canonical.com> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --toN9bR+Yg/35TW2b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 01, 2023 at 03:33:41PM +0200, Heinrich Schuchardt wrote: > CONFIG_$(SPL_TPL_)SYS_MALLOC_F_LEN is defined as hex. If set to zero > manually, .config contains '0x0' and not '0' as value. >=20 > The default value for CONFIG_SPL_SYS_MALLOC_F_LEN should not be set to 0 > but to 0x0 if CONFIG_SPL_FRAMEWORK=3Dn to match a manually set value. >=20 > Fixes: c0126bd862a0 ("spl: Support bootstage, log, hash and early malloc = in TPL") > Fixes: b61694705217 ("SPL: Do not enable SPL_SYS_MALLOC_SIMPLE without SP= L_FRAMEWORK by default") > Signed-off-by: Heinrich Schuchardt Reviewed-by: Tom Rini And I see a number of other cases where a "hex" option has a default of "0" and not "0x0" so I'll have a patch soon. --=20 Tom --toN9bR+Yg/35TW2b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTJIT0ACgkQFHw5/5Y0 tyxPnQv/Y8Zb9e+s5MDoe87+BS3NxtwJSLL7cjshEnc6btbw2xoycxF0OM69Z0QD dgZfFgsISR3NQ+rdZfBrIuRvCqFT+grodrgGsNj04PxjVdXLM+t4DFrm8FrCfUsU En/LKrbQJdgQtuZZ/nBxB9YtmB4et5CWBjUtsKUH4UaVsvJbWT4rtvSck2mLeWmm JJkFFuuG4qOJLlz9HLhcwi/Eglw46DblH8CTD1hxAd88VWMLGbI04Ehva496BS2P ek+lHjrXjBawMqPfIJg9NV0ABe9TKYuTaEEZ9NBdxNwVXiW7wW/Vvr06rIHdVZUc R3dQw4udD9OajjDS7swyIgDBjh0erJh9ZnZZ7lcaQkXw377vb6WeCsdEYzcSWIHy wHXoSrt2rFLTYa2mPr/dvhahS1p5HAj+iCzBBfAH0c+WjN5i+Cwccj0wuaH/CcbJ BwH5S2Y3VaB6aUOzusnz8lWNLtz8bH5AnOG0KTNILxJt5icRDlMobgwP2qXVnUz+ cI2Q24UV =ZttD -----END PGP SIGNATURE----- --toN9bR+Yg/35TW2b--