From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 73624C00528 for ; Tue, 1 Aug 2023 18:53:52 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id AA40586BE6; Tue, 1 Aug 2023 20:53:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="E5MajljL"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id BE55C86BC6; Tue, 1 Aug 2023 20:53:48 +0200 (CEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B6A6E86BC2 for ; Tue, 1 Aug 2023 20:53:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=miquel.raynal@bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 793B31BF206; Tue, 1 Aug 2023 18:53:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1690916025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=c+XTz4tbrI7PTy1ES5BxyiIXJd6C2Vi+9K2nEHESIVg=; b=E5MajljLGBGjaEnnrtV4M/8J1TaIRNSZjvs6TfYg4oDAXVF4m+uvVIy6oD8agfl7tDGRO7 tKBiSTjMUa8rznk0EMpIaHLWbtf2jHnTzg65PvvubI+sj9cscRSNAj9b3JqQATI4R6Pydp hQBseWsEhImwUzVvFp23iugr0MXwVH12euSBnMfZ1zpqukRvc03XRZUc7nKpVmqYF/isLE IIxyLSQrkQ59qLGUGldvnsZsa90IRbZWv0WBj+QtfBsdS0gFd1Z7HyBY/NeS68HexQuh8U lSdwZepYBxBKyn99jTDFgV4ABVhCVdDom+p3s98Sw3XRNDaOoLrBzUlRhfLzEA== Date: Tue, 1 Aug 2023 20:53:42 +0200 From: Miquel Raynal To: Marek Vasut Cc: u-boot@lists.denx.de, Kevin Hilman , Lukasz Majewski , Simon Glass Subject: Re: [PATCH v3 1/4] cmd: bind: Add unbind command with driver filter Message-ID: <20230801205342.2fdbffc8@xps-13> In-Reply-To: References: <20230729145712.213945-1-marex@denx.de> <20230731113159.26e710aa@xps-13> <20230731153607.6210e92f@xps-13> <8c31ee42-36c4-beab-853b-45f7828908a6@denx.de> <20230731155857.1575f5a4@xps-13> <830897a6-d061-f7c8-8f30-7ccc906b53a4@denx.de> <20230731162520.3897ba88@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Marek, marex@denx.de wrote on Mon, 31 Jul 2023 16:40:04 +0200: > On 7/31/23 16:25, Miquel Raynal wrote: > > Hi Marek, > >=20 > > marex@denx.de wrote on Mon, 31 Jul 2023 16:08:19 +0200: > > =20 > >> On 7/31/23 15:58, Miquel Raynal wrote: =20 > >>> Hi Marek, > >>> > >>> marex@denx.de wrote on Mon, 31 Jul 2023 15:50:58 +0200: =20 > >>> >>>> On 7/31/23 15:36, Miquel Raynal wrote: =20 > >>>>> Hi Marek, > >>>>> > >>>>> marex@denx.de wrote on Mon, 31 Jul 2023 13:44:25 +0200: =20 > >>>>> >>>> On 7/31/23 11:31, Miquel Raynal wrote: =20 > >>>>>>> Hi Marek, > >>>>>>> > >>>>>>> marex@denx.de wrote on Sat, 29 Jul 2023 16:57:09 +0200: =20 > >>>>>>> >>>> Extend the driver core to perform lookup by both OF nod= e and driver =20 > >>>>>>>> bound to the node. Use this to look up specific device instances= to > >>>>>>>> unbind from nodes in the unbind command. One example where this = is > >>>>>>>> needed is USB peripheral controller, which may have multiple gad= get > >>>>>>>> drivers bound to it. The unbind command has to select that speci= fic > >>>>>>>> gadget driver instance to unbind from the controller, not unbind= the > >>>>>>>> controller driver itself from the controller. > >>>>>>>> > >>>>>>>> USB ethernet gadget usage looks as follows with this change. Not= ice > >>>>>>>> the extra 'usb_ether' addition in the 'unbind' command at the en= d. > >>>>>>>> " > >>>>>>>> bind /soc/usb-otg@49000000 usb_ether > >>>>>>>> setenv ethact usb_ether > >>>>>>>> setenv loadaddr 0xc2000000 > >>>>>>>> setenv ipaddr 10.0.0.2 > >>>>>>>> setenv serverip 10.0.0.1 > >>>>>>>> setenv netmask 255.255.255.0 > >>>>>>>> tftpboot 0xc2000000 10.0.0.1:test.file > >>>>>>>> unbind /soc/usb-otg@49000000 usb_ether > >>>>>>>> " > >>>>>>>> > >>>>>>>> Signed-off-by: Marek Vasut > >>>>>>>> --- =20 > >>>>>>> > >>>>>>> I am no longer getting wrong pointer dereferences, the SPL is wor= king in > >>>>>>> recovery mode, TFTP "File not found" errors are no longer a probl= em and > >>>>>>> I did not experience any reset while tftp'ing regular files. > >>>>>>> > >>>>>>> One last remaining request on my side is the need for using fastb= oot as > >>>>>>> well which does no longer work as-is: =20 > >>>>>>> >>> =3D> fastboot usb 0 =20 > >>>>>>> couldn't find an available UDC > >>>>>>> g_dnl_register: failed!, error: -19 > >>>>>>> exit not allowed from main input shell. > >>>>>>> > >>>>>>> Can you advise what bind/unbind command would be necessary here? = =20 > >>>>>> > >>>>>> Either 'unbind usb_ether' or run 'dm tree' -> look up the path to = usb_ether in the tree (it will be hanging under usb_peripheral or some such= ), and then use 'unbind '. =20 > >>>>> > >>>>> Nice `dm tree` command, never used it before. > >>>>> > >>>>> Even when I unbind usb_ether I still get the same error: =20 > >>>>> >>> =3D> unbind /ocp/usb@47400000/usb@47401000 =20 > >>>>> =3D> fastboot usb 0 =20 > >>>>> couldn't find an available UDC > >>>>> g_dnl_register: failed!, error: -19 > >>>>> exit not allowed from main input shell. > >>>>> > >>>>> Is there a specific gadget driver which I should bind again manuall= y? =20 > >>>> > >>>> Can you share the output of dm tree before/after unbind ? > >>>> > >>>> fastboot should auto-bind to the right thing. =20 > >>> > >>> Ok. Apparently it does not, but I don't have any clue why. If you want > >>> me to check something else I will. Here is the output: > >>> > >>> U-Boot 2023.07-00806-g979e7443428 (Jul 31 2023 - 11:17:06 +0200) =20 > >> > >> [...] > >> =20 > >>> watchdog 0 [ + ] omap3_wdt | |-- wdt@44e35000 > >>> misc 0 [ + ] ti-musb-wrapper | |-- usb@47400000 > >>> usb 0 [ + ] ti-musb-peripheral | | |-- usb@474= 01000 > >>> ethernet 1 [ + ] usb_ether | | | `-- usb= _ether > >>> bootdev 3 [ ] eth_bootdev | | | `--= usb_ether.bootdev > >>> usb 0 [ ] ti-musb-host | | `-- usb@474= 01800 > >>> ethernet 0 [ + ] eth_cpsw | |-- ethernet@4a= 100000 > >>> bootdev 2 [ ] eth_bootdev | | `-- etherne= t@4a100000.bootdev > >>> simple_bus 67 [ ] ti_sysc | |-- target-modu= le@53100000 > >>> simple_bus 68 [ ] ti_sysc | |-- target-modu= le@53500000 > >>> simple_bus 69 [ ] ti_sysc | `-- target-modu= le@56000000 > >>> clk 62 [ ] fixed_clock |-- clk_mcasp0_fixed > >>> bootstd 0 [ ] bootstd_drv |-- bootstd > >>> bootmeth 0 [ ] bootmeth_efi | |-- efi > >>> bootmeth 1 [ ] bootmeth_extlinux | |-- extlinux > >>> bootmeth 2 [ ] bootmeth_pxe | |-- pxe > >>> bootmeth 3 [ ] vbe_simple | `-- vbe_simple > >>> timer 0 [ + ] omap_timer `-- timer@0 =20 > >>> =3D> unbind /ocp/usb@47400000/usb@47401000 =20 > >> > >> The commit message of this patch contains the following example: > >> unbind /soc/usb-otg@49000000 usb_ether > >> so in your case, try > >> unbind /ocp/usb@47400000/usb@47401000 usb_ether =20 > >=20 > > Does not work, unfortunately: =20 > > =3D> unbind /ocp/usb@47400000/usb@47401000 usb_ether =20 > > Cannot find a device with path /ocp/usb@47400000/usb@47401000 =20 > > =3D> unbind /ocp/usb@47400000/usb@47401000 =20 >=20 > Did this even work before , i.e. without this series, if you were to use = USB ethernet first and then fastboot second (that sequence is important) ? Yes it did. > Can you debug this ? Basically the problem that happens is that if you ru= n: > unbind /ocp/usb@47400000/usb@47401000 > this unbind ti-musb-peripheral usb@47401000 instead of just unbinding > usb_ether usb_ether True. > Maybe just try > unbind usb_ether =3D> unbind usb_ether unbind - Unbind a device from a driver Usage: unbind [] unbind unbind > or > unbind usb_ether usb_ether =3D> unbind usb_ether usb_ether =20 usb_ether is not a valid uclass > ti-musb-peripheral usb@47401000 has to stay in the dm tree output after t= he unbind. Or maybe try >=20 > bind /ocp/usb@47400000/usb@47401000 ti-musb-peripheral Indeed when we perform the unbind, ti-musb-peripheral is removed. Yes, binding it again like you advise makes it come back. > and then the fastboot thing Unfortunately after binding it again, so with the following dm tree snippet: misc 0 [ + ] ti-musb-wrapper | |-- usb@47400000 usb 0 [ ] ti-musb-host | | |-- usb@47401800 usb 0 [ ] ti-musb-peripheral | | `-- usb@47401000 It still fails: =3D> fastboot usb 0 couldn't find an available UDC g_dnl_register: failed!, error: -19 exit not allowed from main input shell. Without this series, this works: =3D> unbind /ocp/usb@47400000/usb@47401000 =3D> bind /ocp/usb@47400000/usb@47401000 ti-musb-peripheral =3D> fastboot usb 0 Thanks, Miqu=C3=A8l