* [PATCH] arm: dts: mediatek: convert gmac link mode to 2500base-x for r3
@ 2023-08-03 16:52 Frank Wunderlich
2023-08-04 9:48 ` Weijie Gao (高惟杰)
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Frank Wunderlich @ 2023-08-03 16:52 UTC (permalink / raw)
To: u-boot; +Cc: Frank Wunderlich, Weijie Gao, Daniel Golle
From: Frank Wunderlich <frank-w@public-files.de>
Ethernet on Bananapi-r3 is broken after
commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")
because changes from this commit were not applied to bpi-r3 devicetree too:
commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
arch/arm/dts/mt7986a-bpi-r3-sd.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/dts/mt7986a-bpi-r3-sd.dts b/arch/arm/dts/mt7986a-bpi-r3-sd.dts
index 15256302b86b..c156a8136343 100644
--- a/arch/arm/dts/mt7986a-bpi-r3-sd.dts
+++ b/arch/arm/dts/mt7986a-bpi-r3-sd.dts
@@ -76,12 +76,12 @@
ð {
status = "okay";
mediatek,gmac-id = <0>;
- phy-mode = "sgmii";
+ phy-mode = "2500base-x";
mediatek,switch = "mt7531";
reset-gpios = <&gpio 5 GPIO_ACTIVE_HIGH>;
fixed-link {
- speed = <1000>;
+ speed = <2500>;
full-duplex;
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm: dts: mediatek: convert gmac link mode to 2500base-x for r3
2023-08-03 16:52 [PATCH] arm: dts: mediatek: convert gmac link mode to 2500base-x for r3 Frank Wunderlich
@ 2023-08-04 9:48 ` Weijie Gao (高惟杰)
2023-08-18 17:49 ` Tom Rini
2023-08-29 14:09 ` Tom Rini
2 siblings, 0 replies; 6+ messages in thread
From: Weijie Gao (高惟杰) @ 2023-08-04 9:48 UTC (permalink / raw)
To: u-boot@lists.denx.de, linux@fw-web.de
Cc: daniel@makrotopia.org, frank-w@public-files.de
On Thu, 2023-08-03 at 18:52 +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Ethernet on Bananapi-r3 is broken after
>
> commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps
> auto-negotiation mode")
>
> because changes from this commit were not applied to bpi-r3
> devicetree too:
>
> commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to
> 2500base-x")
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
Reviewed-by: Weijie Gao <weijie.gao@mediatek.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: dts: mediatek: convert gmac link mode to 2500base-x for r3
2023-08-03 16:52 [PATCH] arm: dts: mediatek: convert gmac link mode to 2500base-x for r3 Frank Wunderlich
2023-08-04 9:48 ` Weijie Gao (高惟杰)
@ 2023-08-18 17:49 ` Tom Rini
2023-08-18 18:45 ` Frank Wunderlich
2023-08-29 14:09 ` Tom Rini
2 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2023-08-18 17:49 UTC (permalink / raw)
To: Frank Wunderlich; +Cc: u-boot, Frank Wunderlich, Weijie Gao, Daniel Golle
[-- Attachment #1: Type: text/plain, Size: 600 bytes --]
On Thu, Aug 03, 2023 at 06:52:58PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Ethernet on Bananapi-r3 is broken after
>
> commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")
>
> because changes from this commit were not applied to bpi-r3 devicetree too:
>
> commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Reviewed-by: Weijie Gao <weijie.gao@mediatek.com>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: dts: mediatek: convert gmac link mode to 2500base-x for r3
2023-08-18 17:49 ` Tom Rini
@ 2023-08-18 18:45 ` Frank Wunderlich
2023-08-18 18:47 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Frank Wunderlich @ 2023-08-18 18:45 UTC (permalink / raw)
To: Tom Rini; +Cc: u-boot, Frank Wunderlich, Weijie Gao, Daniel Golle
Am 18. August 2023 19:49:45 MESZ schrieb Tom Rini <trini@konsulko.com>:
>On Thu, Aug 03, 2023 at 06:52:58PM +0200, Frank Wunderlich wrote:
>
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> Ethernet on Bananapi-r3 is broken after
>>
>> commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")
>>
>> because changes from this commit were not applied to bpi-r3 devicetree too:
>>
>> commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>> Reviewed-by: Weijie Gao <weijie.gao@mediatek.com>
>
>Applied to u-boot/next, thanks!
>
>--
>Tom
Thx,but this leaves ethernet broken on 2023.10 for r3...could this be added to this release too?
regards Frank
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm: dts: mediatek: convert gmac link mode to 2500base-x for r3
2023-08-18 18:45 ` Frank Wunderlich
@ 2023-08-18 18:47 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2023-08-18 18:47 UTC (permalink / raw)
To: Frank Wunderlich; +Cc: u-boot, Frank Wunderlich, Weijie Gao, Daniel Golle
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
On Fri, Aug 18, 2023 at 08:45:33PM +0200, Frank Wunderlich wrote:
> Am 18. August 2023 19:49:45 MESZ schrieb Tom Rini <trini@konsulko.com>:
> >On Thu, Aug 03, 2023 at 06:52:58PM +0200, Frank Wunderlich wrote:
> >
> >> From: Frank Wunderlich <frank-w@public-files.de>
> >>
> >> Ethernet on Bananapi-r3 is broken after
> >>
> >> commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")
> >>
> >> because changes from this commit were not applied to bpi-r3 devicetree too:
> >>
> >> commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")
> >>
> >> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> >> Reviewed-by: Weijie Gao <weijie.gao@mediatek.com>
> >
> >Applied to u-boot/next, thanks!
> >
> >--
> >Tom
>
> Thx,but this leaves ethernet broken on 2023.10 for r3...could this be added to this release too?
Ah, OK, I'll grab it for master too then, thanks. FWIW, some Fixes tags
would have made it more clear as those stand out in patchwork.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm: dts: mediatek: convert gmac link mode to 2500base-x for r3
2023-08-03 16:52 [PATCH] arm: dts: mediatek: convert gmac link mode to 2500base-x for r3 Frank Wunderlich
2023-08-04 9:48 ` Weijie Gao (高惟杰)
2023-08-18 17:49 ` Tom Rini
@ 2023-08-29 14:09 ` Tom Rini
2 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2023-08-29 14:09 UTC (permalink / raw)
To: Frank Wunderlich; +Cc: u-boot, Frank Wunderlich, Weijie Gao, Daniel Golle
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
On Thu, Aug 03, 2023 at 06:52:58PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Ethernet on Bananapi-r3 is broken after
>
> commit bd70f3cea353 ("net: mediatek: add support for SGMII 1Gbps auto-negotiation mode")
>
> because changes from this commit were not applied to bpi-r3 devicetree too:
>
> commit aef54ea16cac ("arm: dts: medaitek: convert gmac link mode to 2500base-x")
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> Reviewed-by: Weijie Gao <weijie.gao@mediatek.com>
Applied to u-boot/master, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-29 14:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-03 16:52 [PATCH] arm: dts: mediatek: convert gmac link mode to 2500base-x for r3 Frank Wunderlich
2023-08-04 9:48 ` Weijie Gao (高惟杰)
2023-08-18 17:49 ` Tom Rini
2023-08-18 18:45 ` Frank Wunderlich
2023-08-18 18:47 ` Tom Rini
2023-08-29 14:09 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox