public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
Cc: u-boot@lists.denx.de, cfsworks@gmail.com,
	hsiangkao@linux.alibaba.com, jnhuang95@gmail.com
Subject: Re: [PATCH] fs/erofs: Remove an unnecessary assertion
Date: Mon, 7 Aug 2023 15:28:58 -0400	[thread overview]
Message-ID: <20230807192858.GI3630934@bill-the-cat> (raw)
In-Reply-To: <20230726045604.40958-1-zhaoyifan@sjtu.edu.cn>

[-- Attachment #1: Type: text/plain, Size: 733 bytes --]

On Wed, Jul 26, 2023 at 12:56:04PM +0800, Yifan Zhao wrote:

> In [1] Sam points out an assertion does not hold true for 32-bit
> platforms, which only impacts Large File Support (LFS) API usage
> in erofs-utils according to Xiang [2]. We don't think these APIs
> are used in u-boot and this restriction could be safely removed.
> 
> [1] https://lists.denx.de/pipermail/u-boot/2023-July/524679.html
> [2] https://lists.denx.de/pipermail/u-boot/2023-July/524727.html
> 
> Fixes: 3a21e92fc255 ("fs/erofs: Introduce new features including ztailpacking, fragments and dedupe")
> Signed-off-by: Yifan Zhao <zhaoyifan@sjtu.edu.cn>
> Tested-by: Sam Edwards <CFSworks@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

      parent reply	other threads:[~2023-08-07 19:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-26  4:56 [PATCH] fs/erofs: Remove an unnecessary assertion Yifan Zhao
2023-07-26  6:12 ` Gao Xiang
2023-07-27  1:05 ` Sam Edwards
2023-08-07 19:28 ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230807192858.GI3630934@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=cfsworks@gmail.com \
    --cc=hsiangkao@linux.alibaba.com \
    --cc=jnhuang95@gmail.com \
    --cc=u-boot@lists.denx.de \
    --cc=zhaoyifan@sjtu.edu.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox