From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B4E1C001DB for ; Mon, 7 Aug 2023 19:30:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 027EF80771; Mon, 7 Aug 2023 21:29:07 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="nHNQk4Sv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6CBD780717; Mon, 7 Aug 2023 21:29:05 +0200 (CEST) Received: from mail-yw1-x1129.google.com (mail-yw1-x1129.google.com [IPv6:2607:f8b0:4864:20::1129]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 1F72F861DA for ; Mon, 7 Aug 2023 21:29:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1129.google.com with SMTP id 00721157ae682-5861116fd74so45879347b3.0 for ; Mon, 07 Aug 2023 12:29:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1691436542; x=1692041342; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=dFMsptoYSVJR6SLpRWRTw0motIohQxinsZC4edAsiJ8=; b=nHNQk4SvRgJ66GH8AXP+YYh31WGtak4kx35bYhTVwRAa+6XoNl83/79MJz5dVcKwlt e8lH6Qco9hfAzGZxSaRX+H2lDSyjp2wKCMcOAD65473G99GXU2ByEWqR+6LdxBpju8Kp fBBGINo9GxskSvXZZq6Blg5cuQGOv1mCxWwVk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691436542; x=1692041342; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dFMsptoYSVJR6SLpRWRTw0motIohQxinsZC4edAsiJ8=; b=c2O9hKeUcXXkRXE7+WWcpV/dyqzQctKqvUYk6wq+AOtE7XKCRCU4oVxNrCV9sbGl5L xt4BH8fhKQU0wCXvQBY8dlwobSpMKjj++EUBVAHuhFY1rV7NLVQQ7q1B98Wof2gtbsiO Hqw1DoE9cfJxQ/pSMwMDKhiAPpFbulbRm4fh92RJlLFXkVwQ2cas4CtCv80bnlmnQGG3 xlxBgrNPeKvW9YZ4XMVqXjfFPDLrFXydq4FASQmPUeaR6h8+TN9bf0mbRVrYbTCUK+5P 01LR7fNuunk6Bo6qABUebNvuydhk6EYyG6US4XeMgDnlHNWswK1LAWErUPAf9hDICMWv MUGw== X-Gm-Message-State: AOJu0YwJ65rEMpQbUv8frRbxhuK7weVhVzjkqIQjk8XxtuENS5HilYBc Vr1++mhNruaR+vWiKyL622LXqQ== X-Google-Smtp-Source: AGHT+IFyoe2yCK5eH0yvtuIJBPcMbRWeIz90JINN9n0i2Eoxk5kp6gW3Qd0TlnZaz9OgNgO/BqTSjA== X-Received: by 2002:a81:a110:0:b0:57a:5039:aa01 with SMTP id y16-20020a81a110000000b0057a5039aa01mr9994583ywg.22.1691436541797; Mon, 07 Aug 2023 12:29:01 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-3ce2-35b7-c17c-93f2.res6.spectrum.com. [2603:6081:7b00:6400:3ce2:35b7:c17c:93f2]) by smtp.gmail.com with ESMTPSA id p204-20020a815bd5000000b00586a19a229dsm2883930ywb.60.2023.08.07.12.29.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 12:29:01 -0700 (PDT) Date: Mon, 7 Aug 2023 15:28:58 -0400 From: Tom Rini To: Yifan Zhao Cc: u-boot@lists.denx.de, cfsworks@gmail.com, hsiangkao@linux.alibaba.com, jnhuang95@gmail.com Subject: Re: [PATCH] fs/erofs: Remove an unnecessary assertion Message-ID: <20230807192858.GI3630934@bill-the-cat> References: <20230726045604.40958-1-zhaoyifan@sjtu.edu.cn> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CHbaOXka0N08Pv5p" Content-Disposition: inline In-Reply-To: <20230726045604.40958-1-zhaoyifan@sjtu.edu.cn> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --CHbaOXka0N08Pv5p Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 26, 2023 at 12:56:04PM +0800, Yifan Zhao wrote: > In [1] Sam points out an assertion does not hold true for 32-bit > platforms, which only impacts Large File Support (LFS) API usage > in erofs-utils according to Xiang [2]. We don't think these APIs > are used in u-boot and this restriction could be safely removed. >=20 > [1] https://lists.denx.de/pipermail/u-boot/2023-July/524679.html > [2] https://lists.denx.de/pipermail/u-boot/2023-July/524727.html >=20 > Fixes: 3a21e92fc255 ("fs/erofs: Introduce new features including ztailpac= king, fragments and dedupe") > Signed-off-by: Yifan Zhao > Tested-by: Sam Edwards Applied to u-boot/master, thanks! --=20 Tom --CHbaOXka0N08Pv5p Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTRRfoACgkQFHw5/5Y0 tywsOQv/YOYedVmQlZiUBNiKFciBRqZfu5uK7MvvxiOisTu7VHg8gnq0A+IWxJcV 2N1skqRHB3F4xMffFMMxnvkNJuKkVxGgNp8RjjjqiHdf+DLcf8I9IzJDsXpHrdSH nkIDAPK7lC2wZ9n4IyzamVzHZeSAhpQ0Ed4/dsQT2gHFLGVO37WdfkCNCnMh42kM XqY6kwNM8iaKuUOexEHMPzyoOdTHhhkyJG8/64my4jyktt52wstzh7CCokXoSuov 9K/we8S64njJTpBvA/WtR4NmhQjC+3GvTdTYuogHIuOtsf09T/nXrOYsn1qHmaAh Dmca4m7uNtNTEYrSgL6hFqtCDSA22EWEyTcoZQPNZidpLbgIFSxS1nRZzCt43FT2 t/bqF4OQgFBtmI7VdAQ/HOp93Up4aQQJc8A+M84fq+apv8yYyvsdNqfWHaKhheeH QDP+JwDIqwVCOOxCSnp5B7zQ1cYqFzq5rNqUGxV5lfv/C9Mi45q13J3B+SC5hb46 v7k3Cfnj =XJkd -----END PGP SIGNATURE----- --CHbaOXka0N08Pv5p--