Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants

[Tom Rini <trini@konsulko.com>]

[-- Attachment #1: Type: text/plain, Size: 1833 bytes --]

On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sughosh Ganu wrote:
> On Thu, 10 Aug 2023 at 21:22, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu wrote:
> >
> > > Build the mkeficapsule tool for all the sandbox variants. This tool
> > > will be used subsequently for testing capsule generation in binman.
> > >
> > > Signed-off-by: Sughosh Ganu <sughosh.ganu@linaro.org>
> > > ---
> > > Changes since V7: None
> > >
> > >  tools/Kconfig | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/tools/Kconfig b/tools/Kconfig
> > > index 6e23f44d55..353a855243 100644
> > > --- a/tools/Kconfig
> > > +++ b/tools/Kconfig
> > > @@ -91,10 +91,10 @@ config TOOLS_SHA512
> > >         Enable SHA512 support in the tools builds
> > >
> > >  config TOOLS_MKEFICAPSULE
> > > -     bool "Build efimkcapsule command"
> > > -     default y if EFI_CAPSULE_ON_DISK
> > > +     bool "Build mkeficapsule tool"
> > > +     default y if EFI_CAPSULE_ON_DISK || SANDBOX
> > >       help
> > > -       This command allows users to create a UEFI capsule file and,
> > > +       This tool allows users to create a UEFI capsule file and,
> > >         optionally sign that file. If you want to enable UEFI capsule
> > >         update feature on your target, you certainly need this.
> >
> > Sorry, what is this fixing exactly?
> 
> The tool is required to be supported on the sandbox_spl variant, since
> that is used for the binman tests in CI. Simon had then asked me to
> add support for the tool on all sandbox variants. I missed putting his
> R-b on this patch.

OK, moving forward just depend on:
https://patchwork.ozlabs.org/project/uboot/patch/20230810165224.514772-1-trini@konsulko.com/
instead please, thanks.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]