From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F0CBC0015E for ; Fri, 11 Aug 2023 15:56:22 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 46DFC861C5; Fri, 11 Aug 2023 17:56:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="Dg8jKpD+"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 288FE86377; Fri, 11 Aug 2023 17:56:19 +0200 (CEST) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id AEE8285C98 for ; Fri, 11 Aug 2023 17:56:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-6424c61c80eso2542076d6.1 for ; Fri, 11 Aug 2023 08:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1691769375; x=1692374175; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4OC0/qX/6ygDbVwKoNWXeQFAUDGry+PrSdmn0SToACQ=; b=Dg8jKpD+dqqsuv+SygyQDllcUWO24LERwmigNysGF0bWjanTreae4eT52MDoN9MJoa e0Y0A8QrXWfl4bmdXoJi0vfLiddXV9A50xltBX3aOkGv4mASvw7Qle3CVlE/xRmOb9UF 5GcrWzYSiHs2jx/BOTHFEOqBHjlQKDwE8TGCQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691769375; x=1692374175; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4OC0/qX/6ygDbVwKoNWXeQFAUDGry+PrSdmn0SToACQ=; b=Sma4RHZsKAlO3vsScnGTU93gUXrNZ4t8/DGHbMPbykrm5vrywtJ1y4iwZEDMhybadg VNr7BBPa0vucVhPmdFcgK0TxUgR7dT1YI4H+LNSd1jZYl7+/PANFdWy7FlqtYX8bN5I+ gSKoY0uAl5n5VERviLRImOLTn6VhNU1yJVQDpuEU8J6gcTCDoOrcybj9jbnZ6CjAubEz D6iF1aSWkVhURPOlfjzQsBYQvIbqqRdHhe/d3QE870KB+dPaG9CM+gScMr8YhrmzyPEN eU+0M2G8VUECfcS+IiJyrFO4rVjepfynkcsWuxXgAYRD6nP9hq49Ii6iT2FPVQ6QOPtd 9Iww== X-Gm-Message-State: AOJu0YxCIguEBsmDy57ebEm0lDBBcCB0OdkbRDnOgYFnaCPLhCEZvsSq nFslfbc3lWmCd5UxmGVB2wRu3Q== X-Google-Smtp-Source: AGHT+IES1jlX2wDU4w2/FPnMaRxqfIKk4KP++48NKYl3+/AqfhqMB6VahbbPQikuNq2fZJ6KmMoCPg== X-Received: by 2002:a05:6214:1304:b0:63d:580:9c68 with SMTP id pn4-20020a056214130400b0063d05809c68mr6936723qvb.32.1691769375470; Fri, 11 Aug 2023 08:56:15 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b133-f454-a438-5224.res6.spectrum.com. [2603:6081:7b00:6400:b133:f454:a438:5224]) by smtp.gmail.com with ESMTPSA id pc5-20020a05620a840500b0076d0312b8basm1256822qkn.131.2023.08.11.08.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 08:56:15 -0700 (PDT) Date: Fri, 11 Aug 2023 11:56:13 -0400 From: Tom Rini To: Simon Glass , Sughosh Ganu Cc: u-boot@lists.denx.de, Heinrich Schuchardt , Ilias Apalodimas , Takahiro Akashi , Malte Schmidt , Michal Simek Subject: Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants Message-ID: <20230811155613.GE3630934@bill-the-cat> References: <20230810142338.3402963-1-sughosh.ganu@linaro.org> <20230810142338.3402963-5-sughosh.ganu@linaro.org> <20230810155232.GS3630934@bill-the-cat> <20230810171702.GW3630934@bill-the-cat> <20230811135812.GB3630934@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TMu+W1hphPos3a4f" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --TMu+W1hphPos3a4f Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 11, 2023 at 08:26:36AM -0600, Simon Glass wrote: > Hi Sughosh, >=20 > On Fri, 11 Aug 2023 at 08:23, Sughosh Ganu wrot= e: > > > > On Fri, 11 Aug 2023 at 19:28, Tom Rini wrote: > > > > > > On Fri, Aug 11, 2023 at 04:29:37PM +0530, Sughosh Ganu wrote: > > > > On Thu, 10 Aug 2023 at 22:47, Tom Rini wrote: > > > > > > > > > > On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sughosh Ganu wrote: > > > > > > On Thu, 10 Aug 2023 at 21:22, Tom Rini wro= te: > > > > > > > > > > > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu wrote: > > > > > > > > > > > > > > > Build the mkeficapsule tool for all the sandbox variants. T= his tool > > > > > > > > will be used subsequently for testing capsule generation in= binman. > > > > > > > > > > > > > > > > Signed-off-by: Sughosh Ganu > > > > > > > > --- > > > > > > > > Changes since V7: None > > > > > > > > > > > > > > > > tools/Kconfig | 6 +++--- > > > > > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > > > > > > > > > diff --git a/tools/Kconfig b/tools/Kconfig > > > > > > > > index 6e23f44d55..353a855243 100644 > > > > > > > > --- a/tools/Kconfig > > > > > > > > +++ b/tools/Kconfig > > > > > > > > @@ -91,10 +91,10 @@ config TOOLS_SHA512 > > > > > > > > Enable SHA512 support in the tools builds > > > > > > > > > > > > > > > > config TOOLS_MKEFICAPSULE > > > > > > > > - bool "Build efimkcapsule command" > > > > > > > > - default y if EFI_CAPSULE_ON_DISK > > > > > > > > + bool "Build mkeficapsule tool" > > > > > > > > + default y if EFI_CAPSULE_ON_DISK || SANDBOX > > > > > > > > help > > > > > > > > - This command allows users to create a UEFI capsule = file and, > > > > > > > > + This tool allows users to create a UEFI capsule fil= e and, > > > > > > > > optionally sign that file. If you want to enable UE= FI capsule > > > > > > > > update feature on your target, you certainly need t= his. > > > > > > > > > > > > > > Sorry, what is this fixing exactly? > > > > > > > > > > > > The tool is required to be supported on the sandbox_spl variant= , since > > > > > > that is used for the binman tests in CI. Simon had then asked m= e to > > > > > > add support for the tool on all sandbox variants. I missed putt= ing his > > > > > > R-b on this patch. > > > > > > > > > > OK, moving forward just depend on: > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230810165224.5= 14772-1-trini@konsulko.com/ > > > > > instead please, thanks. > > > > > > > > I will base my changes on top of your patch. However, we would still > > > > need this patch as part of the series, since Simon wants the capsul= es > > > > to be generated for all the sandbox variants. Thanks. > > > > > > No, this isn't needed. Any sandbox variant that needs capsules has > > > EFI_CAPSULE_ON_DISK enabled. > > > > Simon wants the capsules to be generated on all sandbox variants, > > including those that do not have the EFI_CAPSULE_ON_DISK enabled. > > Which is why we need to have the tool enabled for all sandbox > > variants. >=20 > I want to avoid #ifdefs in the sandbox .dts so far as possible. >=20 > Tom, I'll let you make the final decision. >=20 > In any case, the multiple-images thing needs to be fixed. Sughosh, please update the other sandbox defconfigs to just enable EFI_CAPSULE_ON_DISK. Simon, this I think is an example of where re-working configs/sandbox64_defconfig configs/sandbox_defconfig configs/sandbox_flattree_defconfig configs/sandbox_noinst_defconfig configs/sandbox_spl_defconfig configs/sandbox_vpl_defconfig To be configs/sandbox_defconfig + boards/sandbox/flattree.config, noinst.config, spl.config, vpl.config would be helpful. There's the sandbox config itself where EFI_CAPSULE_ON_DISK=3Dy and then every other variant just gets that, and we don't have to tweak N configs. --=20 Tom --TMu+W1hphPos3a4f Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTWWhIACgkQFHw5/5Y0 tywW2AwAsgp9swH4gui9cDvLLGRLRgM+EjfQdUAPBEEjdpRVTsGoFfZ+5PXG41re q8RxD9XgZq9zXr9QoitjxVBN8N3KVFjXyvkkKXokQ5khAwdQIWbgg44FeDnZdMjS kUAGNPsq85B5h1Gdib3S2P9iYjSvE0+5bTQ1hxYMDXShaMs3MsVPhM2hsQnpf402 YXkIRooNW70vAdnfPo5egT0E9nTg83x56+ZRGPROIpLncJYDxLtwyiruLnHyx2M5 9xGHyuiX9JwAPz/BijaNLOAt40YF5195NeJA+1uoHFJ3rqPR2TkGuuFqG+PdF3q/ N4URa9A7wIQzIDaBvdNGzqm9AGbVEDF9sTmjddJdZPiuwHhY9/mBH1f7ylk3K70P pTP8XThNmWhGGPpDxIOEh8+atxtMjw3vKDw1G27oe0hF8nKwNYCQXG5M0DI3flG6 gCOEILLB0pwJ6TzNM745DNHHtLRDTTtFI3RE3bBXjHhHA0q9+vvM8iAHju538Js5 Z9ivUrnB =y2qC -----END PGP SIGNATURE----- --TMu+W1hphPos3a4f--