From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5957C04A6A for ; Sat, 12 Aug 2023 14:22:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E02388638E; Sat, 12 Aug 2023 16:22:30 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="b4UwJEdR"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0885B86751; Sat, 12 Aug 2023 16:22:30 +0200 (CEST) Received: from mail-yw1-x112e.google.com (mail-yw1-x112e.google.com [IPv6:2607:f8b0:4864:20::112e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 854DF833CF for ; Sat, 12 Aug 2023 16:22:27 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x112e.google.com with SMTP id 00721157ae682-5899ed05210so30163017b3.3 for ; Sat, 12 Aug 2023 07:22:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1691850146; x=1692454946; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZZKD95zXJzo46+yzV3kCSWScNMJ021jVAg/lB7NefcM=; b=b4UwJEdRjynt89QuFMfGkEs7nDm30pinULWDKwhgtfQw7ZhCyXdc76QkBVHjBQeUeU QrOC5DsjE2O5FEZ52GO55I+3tqcmxNgU4l06CvOQ87dcslTjcaLFk3I/fW8RbihcIRZJ qjq4apzbZh0We54mm37DPQCLv2junkT19D2bQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691850146; x=1692454946; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZZKD95zXJzo46+yzV3kCSWScNMJ021jVAg/lB7NefcM=; b=T4FWRzMMcZbCQjUrQBpvdeqtPaAzjLRcOw+bIgujgmXjtXs9PSt0c4OPN/R7r16h79 7RFA+GH6SaRyz77PNN9gPnHM5JBDD3MFd9uz6nJMVKav3iR5A7ylxPl5rpoN+3RqFaTL I3bC6hJgtrgIpwnovlfvrbLLtC4hMpi2JW6XCs0mlH/yG2jRNHD725XSzXqjbc04LgZ7 RqdophhWWQc88mKdy7RGlUIs3z80CIKWuQVaZ+zdAVv3cyPrwcJTZHMQzrZBULi7WX+Q gxqRyhoKUHE6N1VgumlRo5B1eU9AJkdYf5jCXvUd7mTcadH2VQZHRM8/MkbbmRWnhZxG A2NA== X-Gm-Message-State: AOJu0Yz6T3H2AJ5Vw0Z1L7jaSjaH/GDmu5qsFmlL+7ETN0tCp2myGGnI O7F45Z4DuvhdLst4//FwdUXKJQ== X-Google-Smtp-Source: AGHT+IG9b4NLl2GkM4f3lFslmNblJIcx8x6Wne8bYHp1CsQ0bLaqIVEB6LLAO/YlrtwzmNn+EluzbA== X-Received: by 2002:a0d:c904:0:b0:586:a117:b84d with SMTP id l4-20020a0dc904000000b00586a117b84dmr5498917ywd.34.1691850146242; Sat, 12 Aug 2023 07:22:26 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-7195-95bb-a2c8-510c.res6.spectrum.com. [2603:6081:7b00:6400:7195:95bb:a2c8:510c]) by smtp.gmail.com with ESMTPSA id n14-20020a819e4e000000b0055a07e36659sm1621280ywj.145.2023.08.12.07.22.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Aug 2023 07:22:25 -0700 (PDT) Date: Sat, 12 Aug 2023 10:22:23 -0400 From: Tom Rini To: Simon Glass Cc: Sughosh Ganu , U-Boot Mailing List , Heinrich Schuchardt , Ilias Apalodimas , Takahiro Akashi , Malte Schmidt , Michal Simek Subject: Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants Message-ID: <20230812142223.GI3630934@bill-the-cat> References: <20230810142338.3402963-5-sughosh.ganu@linaro.org> <20230810155232.GS3630934@bill-the-cat> <20230810171702.GW3630934@bill-the-cat> <20230811135812.GB3630934@bill-the-cat> <20230811155613.GE3630934@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zyrPPzZpeJ7B5qFx" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --zyrPPzZpeJ7B5qFx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 12, 2023 at 07:08:44AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Fri, 11 Aug 2023 at 09:56, Tom Rini wrote: > > > > On Fri, Aug 11, 2023 at 08:26:36AM -0600, Simon Glass wrote: > > > Hi Sughosh, > > > > > > On Fri, 11 Aug 2023 at 08:23, Sughosh Ganu > wrote: > > > > > > > > On Fri, 11 Aug 2023 at 19:28, Tom Rini wrote: > > > > > > > > > > On Fri, Aug 11, 2023 at 04:29:37PM +0530, Sughosh Ganu wrote: > > > > > > On Thu, 10 Aug 2023 at 22:47, Tom Rini wro= te: > > > > > > > > > > > > > > On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sughosh Ganu wrote: > > > > > > > > On Thu, 10 Aug 2023 at 21:22, Tom Rini > wrote: > > > > > > > > > > > > > > > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu > wrote: > > > > > > > > > > > > > > > > > > > Build the mkeficapsule tool for all the sandbox variant= s. > This tool > > > > > > > > > > will be used subsequently for testing capsule generation > in binman. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Sughosh Ganu > > > > > > > > > > --- > > > > > > > > > > Changes since V7: None > > > > > > > > > > > > > > > > > > > > tools/Kconfig | 6 +++--- > > > > > > > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > > > > > > > > > > > > > diff --git a/tools/Kconfig b/tools/Kconfig > > > > > > > > > > index 6e23f44d55..353a855243 100644 > > > > > > > > > > --- a/tools/Kconfig > > > > > > > > > > +++ b/tools/Kconfig > > > > > > > > > > @@ -91,10 +91,10 @@ config TOOLS_SHA512 > > > > > > > > > > Enable SHA512 support in the tools builds > > > > > > > > > > > > > > > > > > > > config TOOLS_MKEFICAPSULE > > > > > > > > > > - bool "Build efimkcapsule command" > > > > > > > > > > - default y if EFI_CAPSULE_ON_DISK > > > > > > > > > > + bool "Build mkeficapsule tool" > > > > > > > > > > + default y if EFI_CAPSULE_ON_DISK || SANDBOX > > > > > > > > > > help > > > > > > > > > > - This command allows users to create a UEFI > capsule file and, > > > > > > > > > > + This tool allows users to create a UEFI capsule > file and, > > > > > > > > > > optionally sign that file. If you want to enable > UEFI capsule > > > > > > > > > > update feature on your target, you certainly ne= ed > this. > > > > > > > > > > > > > > > > > > Sorry, what is this fixing exactly? > > > > > > > > > > > > > > > > The tool is required to be supported on the sandbox_spl > variant, since > > > > > > > > that is used for the binman tests in CI. Simon had then ask= ed > me to > > > > > > > > add support for the tool on all sandbox variants. I missed > putting his > > > > > > > > R-b on this patch. > > > > > > > > > > > > > > OK, moving forward just depend on: > > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230810165224.514772-1-= trini@konsulko.com/ > > > > > > > instead please, thanks. > > > > > > > > > > > > I will base my changes on top of your patch. However, we would > still > > > > > > need this patch as part of the series, since Simon wants the > capsules > > > > > > to be generated for all the sandbox variants. Thanks. > > > > > > > > > > No, this isn't needed. Any sandbox variant that needs capsules h= as > > > > > EFI_CAPSULE_ON_DISK enabled. > > > > > > > > Simon wants the capsules to be generated on all sandbox variants, > > > > including those that do not have the EFI_CAPSULE_ON_DISK enabled. > > > > Which is why we need to have the tool enabled for all sandbox > > > > variants. > > > > > > I want to avoid #ifdefs in the sandbox .dts so far as possible. > > > > > > Tom, I'll let you make the final decision. > > > > > > In any case, the multiple-images thing needs to be fixed. > > > > Sughosh, please update the other sandbox defconfigs to just enable > > EFI_CAPSULE_ON_DISK. > > > > Simon, this I think is an example of where re-working > > configs/sandbox64_defconfig > > configs/sandbox_defconfig > > configs/sandbox_flattree_defconfig > > configs/sandbox_noinst_defconfig > > configs/sandbox_spl_defconfig > > configs/sandbox_vpl_defconfig > > > > To be configs/sandbox_defconfig + boards/sandbox/flattree.config, > > noinst.config, spl.config, vpl.config would be helpful. There's the > > sandbox config itself where EFI_CAPSULE_ON_DISK=3Dy and then every other > > variant just gets that, and we don't have to tweak N configs. >=20 > You mean split configs? So far I am unable to build those... I don't know what you mean by split configs. I mean that I think the only intentional difference between configs/sandbox_defconfig and configs/sandbox64_defconfig is: CONFIG_SANDBOX64=3Dy CONFIG_DEFAULT_DEVICE_TREE=3D"sandbox64" And everything else is unintentional. And there's lots of other deltas like that between each of the other variants, and sandbox. And that this isn't the first, nor likely the last, time where we need to enable some option on other sandbox config files too, so that CI passes. This would all be avoided by using the config fragments mechanism so that we captured only the intentional delta of a fragment rather than maintaining N nearly identical, but not quite, files. --=20 Tom --zyrPPzZpeJ7B5qFx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTXlZ8ACgkQFHw5/5Y0 tywF+gv/WeP/UjaQIaVKBwfyhOw8uvhJIjUZdA31tiIx2Eaocikx54XD99z9OpbS oXgn63heodf0Yqo3VwFlGfh5OCdg1UHukeFZtLrjjs9HRT/6dZHwvZjlBNqxohbr JsS9iN26dWiMd9tXu5W7hjOyWWYzZooePscIkshedjnInhMSVtUfHoJEWh7BobJF VpgUlKi+YXpGSXkp5kVPdOGJNx3L6c/cOw1lvYrngNs3y5Yqt2u7zcJFhRYGDink zo5UUGI9uRG4RyXfFWt68jBaHeXHauecYnB2ARPi7rdiZeLxiM5lmt8IVH4LSXVk qh77WshItzhor3dnx8kqpHjJMioM4uI0KHjoMzVmZCiluRRoAh2SlGXnreCs7NWT bDPEXbBPSz/pz4X7YANtnRtHmAUp0PwTIQri9yVv7Ep6zyHsrZtJlXNlVY2iMVtm 6NbCuifbnuHLShhTItZrNRVDQUlED3K0tvLPczYygy/y7FcZj8XFjUswNyNK4gyF ikAaG9T0 =aOvX -----END PGP SIGNATURE----- --zyrPPzZpeJ7B5qFx--