From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDEFEC001B0 for ; Sat, 12 Aug 2023 14:28:32 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5A1DF868B0; Sat, 12 Aug 2023 16:28:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="qdTf6SVV"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id C49D18696D; Sat, 12 Aug 2023 16:28:30 +0200 (CEST) Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4AE4386751 for ; Sat, 12 Aug 2023 16:28:28 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-58439daf39fso30448037b3.1 for ; Sat, 12 Aug 2023 07:28:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1691850507; x=1692455307; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ekzzLSbbzL4zvAqZ4Qq3xFh2o1rXj0GtiwraAfE1ALs=; b=qdTf6SVVjoZyoet/2QDd4pClnLU7ibY9ciRPrM0qaeLAh0fTTwR2XrlJRALCCmAUbG qPaepHeUmEWHrn8wYIqYtveJ4epv7FG1lrL8AOzjZWM2j9+JbWXKNBwUmzofXDcVi0Pt qF2LiE4b3tFE3QU01hnu1BUibZDANhHnLirkA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691850507; x=1692455307; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ekzzLSbbzL4zvAqZ4Qq3xFh2o1rXj0GtiwraAfE1ALs=; b=PuK6M7kFAmW06jZ91WIGNnkw7r+pLj65+3NP2r1ad5n22so0nKy+EMRVgQyiypxWeW Od7mg9r2UwpVQ9j/NBz5ehwG5CJUDHhtLC9jkLP3o5qp41nxuO5rF0ekBlPOLSVI7/20 lexRmjsxOhHJ6/6YOqkjKrqczOux50a4buQNzWQB4ko7GpFFvzQV67VJEPh/JFfkGCkK TXQ3G7XSHgaFtclFkv2zbVm04OzNC2v29q2a5vu++rjNfMtpCQP2tyH6gQtki2mTF2c6 CHlWPTFPYw/YyvXfaAixXRrgXEoKfnqSleYGZVQp+VYYts1KObMjsOf/pC6LXX9RG2+R GmGg== X-Gm-Message-State: AOJu0YwvMcH9MFhDULAEY7/f96o78cFOSuMJ4orjVvtnVWj+ij9CCbxK taA3A0M0fxEW2doaE0phQFOK/g== X-Google-Smtp-Source: AGHT+IFbzD4K/75K37Dl70nTI2wm6Dm9hmlkBOe+sUquM7Aj+wfH5oxDkcGEXVuwhmNp7FZ+Nk1rew== X-Received: by 2002:a81:a542:0:b0:56d:d58:82b7 with SMTP id v2-20020a81a542000000b0056d0d5882b7mr5390418ywg.23.1691850506967; Sat, 12 Aug 2023 07:28:26 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-7195-95bb-a2c8-510c.res6.spectrum.com. [2603:6081:7b00:6400:7195:95bb:a2c8:510c]) by smtp.gmail.com with ESMTPSA id u140-20020a818492000000b00576e67820f3sm1636183ywf.66.2023.08.12.07.28.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 12 Aug 2023 07:28:26 -0700 (PDT) Date: Sat, 12 Aug 2023 10:28:24 -0400 From: Tom Rini To: Simon Glass Cc: Sughosh Ganu , U-Boot Mailing List , Heinrich Schuchardt , Ilias Apalodimas , Takahiro Akashi , Malte Schmidt , Michal Simek Subject: Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants Message-ID: <20230812142824.GJ3630934@bill-the-cat> References: <20230810171702.GW3630934@bill-the-cat> <20230811135812.GB3630934@bill-the-cat> <20230811155613.GE3630934@bill-the-cat> <20230812142223.GI3630934@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="/+EnuwOBGgl8zGrE" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --/+EnuwOBGgl8zGrE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 12, 2023 at 08:24:59AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Sat, 12 Aug 2023 at 08:22, Tom Rini wrote: > > > > On Sat, Aug 12, 2023 at 07:08:44AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Fri, 11 Aug 2023 at 09:56, Tom Rini wrote: > > > > > > > > On Fri, Aug 11, 2023 at 08:26:36AM -0600, Simon Glass wrote: > > > > > Hi Sughosh, > > > > > > > > > > On Fri, 11 Aug 2023 at 08:23, Sughosh Ganu > > > wrote: > > > > > > > > > > > > On Fri, 11 Aug 2023 at 19:28, Tom Rini wro= te: > > > > > > > > > > > > > > On Fri, Aug 11, 2023 at 04:29:37PM +0530, Sughosh Ganu wrote: > > > > > > > > On Thu, 10 Aug 2023 at 22:47, Tom Rini = wrote: > > > > > > > > > > > > > > > > > > On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sughosh Ganu wr= ote: > > > > > > > > > > On Thu, 10 Aug 2023 at 21:22, Tom Rini > > > wrote: > > > > > > > > > > > > > > > > > > > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sughosh Ganu > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > Build the mkeficapsule tool for all the sandbox var= iants. > > > This tool > > > > > > > > > > > > will be used subsequently for testing capsule gener= ation > > > in binman. > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Sughosh Ganu > > > > > > > > > > > > --- > > > > > > > > > > > > Changes since V7: None > > > > > > > > > > > > > > > > > > > > > > > > tools/Kconfig | 6 +++--- > > > > > > > > > > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/tools/Kconfig b/tools/Kconfig > > > > > > > > > > > > index 6e23f44d55..353a855243 100644 > > > > > > > > > > > > --- a/tools/Kconfig > > > > > > > > > > > > +++ b/tools/Kconfig > > > > > > > > > > > > @@ -91,10 +91,10 @@ config TOOLS_SHA512 > > > > > > > > > > > > Enable SHA512 support in the tools builds > > > > > > > > > > > > > > > > > > > > > > > > config TOOLS_MKEFICAPSULE > > > > > > > > > > > > - bool "Build efimkcapsule command" > > > > > > > > > > > > - default y if EFI_CAPSULE_ON_DISK > > > > > > > > > > > > + bool "Build mkeficapsule tool" > > > > > > > > > > > > + default y if EFI_CAPSULE_ON_DISK || SANDBOX > > > > > > > > > > > > help > > > > > > > > > > > > - This command allows users to create a UEFI > > > capsule file and, > > > > > > > > > > > > + This tool allows users to create a UEFI cap= sule > > > file and, > > > > > > > > > > > > optionally sign that file. If you want to e= nable > > > UEFI capsule > > > > > > > > > > > > update feature on your target, you certainl= y need > > > this. > > > > > > > > > > > > > > > > > > > > > > Sorry, what is this fixing exactly? > > > > > > > > > > > > > > > > > > > > The tool is required to be supported on the sandbox_spl > > > variant, since > > > > > > > > > > that is used for the binman tests in CI. Simon had then= asked > > > me to > > > > > > > > > > add support for the tool on all sandbox variants. I mis= sed > > > putting his > > > > > > > > > > R-b on this patch. > > > > > > > > > > > > > > > > > > OK, moving forward just depend on: > > > > > > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230810165224.51477= 2-1-trini@konsulko.com/ > > > > > > > > > instead please, thanks. > > > > > > > > > > > > > > > > I will base my changes on top of your patch. However, we wo= uld > > > still > > > > > > > > need this patch as part of the series, since Simon wants the > > > capsules > > > > > > > > to be generated for all the sandbox variants. Thanks. > > > > > > > > > > > > > > No, this isn't needed. Any sandbox variant that needs capsul= es has > > > > > > > EFI_CAPSULE_ON_DISK enabled. > > > > > > > > > > > > Simon wants the capsules to be generated on all sandbox variant= s, > > > > > > including those that do not have the EFI_CAPSULE_ON_DISK enable= d. > > > > > > Which is why we need to have the tool enabled for all sandbox > > > > > > variants. > > > > > > > > > > I want to avoid #ifdefs in the sandbox .dts so far as possible. > > > > > > > > > > Tom, I'll let you make the final decision. > > > > > > > > > > In any case, the multiple-images thing needs to be fixed. > > > > > > > > Sughosh, please update the other sandbox defconfigs to just enable > > > > EFI_CAPSULE_ON_DISK. > > > > > > > > Simon, this I think is an example of where re-working > > > > configs/sandbox64_defconfig > > > > configs/sandbox_defconfig > > > > configs/sandbox_flattree_defconfig > > > > configs/sandbox_noinst_defconfig > > > > configs/sandbox_spl_defconfig > > > > configs/sandbox_vpl_defconfig > > > > > > > > To be configs/sandbox_defconfig + boards/sandbox/flattree.config, > > > > noinst.config, spl.config, vpl.config would be helpful. There's the > > > > sandbox config itself where EFI_CAPSULE_ON_DISK=3Dy and then every = other > > > > variant just gets that, and we don't have to tweak N configs. > > > > > > You mean split configs? So far I am unable to build those... > > > > I don't know what you mean by split configs. I mean that I think the > > only intentional difference between configs/sandbox_defconfig and > > configs/sandbox64_defconfig is: > > CONFIG_SANDBOX64=3Dy > > CONFIG_DEFAULT_DEVICE_TREE=3D"sandbox64" > > > > And everything else is unintentional. And there's lots of other deltas > > like that between each of the other variants, and sandbox. And that > > this isn't the first, nor likely the last, time where we need to enable > > some option on other sandbox config files too, so that CI passes. This > > would all be avoided by using the config fragments mechanism so that > > we captured only the intentional delta of a fragment rather than > > maintaining N nearly identical, but not quite, files. >=20 > Well we do have other intentional differences, e.g. OF_LIVE. But OK if > we can find a way to make fragments work with buildman (amd qconfig), > then we could do this. Yes, I was noting this in hopes of sparking your interest in figuring out how to handle fragments with buildman. It's similar to how we have the override option today. --=20 Tom --/+EnuwOBGgl8zGrE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTXlwgACgkQFHw5/5Y0 tyxBSAv/fSMxF9DXsr0JhWhx4iOQKsakyLl9zK24IXXwoKTx5oYGKPR56wE/swKu 37OrHiElpnvObHplV10RUuOCHUnSFoPO9/oe/elcVR5foMxx1jdioupuyBNrA5SO aZZLruExC0w6qTkrN1ZIIfW8G9lErn1PoGHDeYNQwNRlZvat3sTJjUIvh/okg0pA oR6r2wLGSdvQTE5nq8kH5tzV0nLbF6mzNR27h0xbNAo8XDZgIHPcjqy7QiFxze7p 9Rj+OcOFAyfcXj+pWjUCvCpb7lYc8DcEJjvPWVShYpcripPanooz9jXb9IUmeYMZ rE/GVMihmQoZGpSRSRPanOvsy4UET60YY329BFG4xK4djjO23F6knIKEBVYbDjux ZSNMnELVvZYbvhvFWzeR6X9J3RBoznV4a7qN3c3GgoXc/J53Zl1fHfEyIYwMeZkY smHA9DEJiVHFe+bfCs4BRF2OExqnJv1rOci5glUtekLw6fyoRzag7PAiptSQMX9F 25iuDe/d =fREY -----END PGP SIGNATURE----- --/+EnuwOBGgl8zGrE--