From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0D7EEB64DD for ; Sun, 13 Aug 2023 12:40:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 820B4846FB; Sun, 13 Aug 2023 14:40:54 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="pVE+A/q5"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6373A847C3; Sun, 13 Aug 2023 14:40:53 +0200 (CEST) Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id BB3A980DF7 for ; Sun, 13 Aug 2023 14:40:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yb1-xb31.google.com with SMTP id 3f1490d57ef6-d62ae3fc7f1so2572928276.2 for ; Sun, 13 Aug 2023 05:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1691930449; x=1692535249; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=66YX5/k2u60BsyzC/K+2cjulVzpDXJAfL9b431rDjgY=; b=pVE+A/q5dslcPaeAIYtygpfHyFfuQ3xdMb2z8Z9tl97vxHh80/ZeDr+BRDNwh3xZKK 8T3q8aJyt2NvLNPOuoZE4jeAIZbiuW1/XbVbVxEZXrrfdhm1nfBaZqOiCT1Y6DRFtkeR YqGBbylc6QsPviRAkMfPOd7BFuM+AD0TK4FE4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691930449; x=1692535249; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=66YX5/k2u60BsyzC/K+2cjulVzpDXJAfL9b431rDjgY=; b=HWXf1aEfiAgfEzleaDSMwIKUDThvNf23sGlNiThhmY874QvVxT+/fP+WrWgzvAOQo+ vUEeo4CoVSw5EF9pPVkylOCI+9+/QI9LW3PX9j6ljBKNsem7HmleGslP/L10OPsJ9SPr qJxaukaHb3hC+TBUjSqmcUJ2EuR8mahVAyazMqFV00RO0d4Y+FVcFz5IlNXKsYp2eWJa ZYipnBA1l9lJgobdDBYu09EBf1vLtpSnKlvOGCyedybejYJ02T4GsKaUwVkv9fRu9Azs gs5uzBpZQdsg30wFWbinYu4AUaxyQe9ndeZNO9KUjMws3CCLSU4ymEGUQX6sTljnohLg oW6A== X-Gm-Message-State: AOJu0YyvHaSv0zSfk4GMjZcWFK15J4T6vzBY6E7jd/rhtCGEY+S/1uJb 8lyudXRfShNUjt61K8GhQPOrVg== X-Google-Smtp-Source: AGHT+IEcg9fACBoZK24QmiR+skP9MbMMyKWU/t3MlE2yLh3LK9oxq/nt/JPCZgRQTAFFg1dgwgBlPQ== X-Received: by 2002:a25:508d:0:b0:d35:9a48:51b0 with SMTP id e135-20020a25508d000000b00d359a4851b0mr5817012ybb.7.1691930449281; Sun, 13 Aug 2023 05:40:49 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b7a2-eada-624b-a58a.res6.spectrum.com. [2603:6081:7b00:6400:b7a2:eada:624b:a58a]) by smtp.gmail.com with ESMTPSA id s133-20020a25778b000000b00d0bad22d652sm1928755ybc.36.2023.08.13.05.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Aug 2023 05:40:48 -0700 (PDT) Date: Sun, 13 Aug 2023 08:40:45 -0400 From: Tom Rini To: Simon Glass Cc: Sughosh Ganu , U-Boot Mailing List , Heinrich Schuchardt , Ilias Apalodimas , Takahiro Akashi , Malte Schmidt , Michal Simek Subject: Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants Message-ID: <20230813124045.GL3630934@bill-the-cat> References: <20230811155613.GE3630934@bill-the-cat> <20230812142223.GI3630934@bill-the-cat> <20230812142824.GJ3630934@bill-the-cat> <20230812223758.GK3630934@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QRBppMvewktuHGUZ" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --QRBppMvewktuHGUZ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 12, 2023 at 06:14:45PM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Sat, 12 Aug 2023 at 16:38, Tom Rini wrote: > > > > On Sat, Aug 12, 2023 at 11:03:36AM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sat, 12 Aug 2023 at 08:28, Tom Rini wrote: > > > > > > > > On Sat, Aug 12, 2023 at 08:24:59AM -0600, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Sat, 12 Aug 2023 at 08:22, Tom Rini wrote: > > > > > > > > > > > > On Sat, Aug 12, 2023 at 07:08:44AM -0600, Simon Glass wrote: > > > > > > > Hi Tom, > > > > > > > > > > > > > > On Fri, 11 Aug 2023 at 09:56, Tom Rini w= rote: > > > > > > > > > > > > > > > > On Fri, Aug 11, 2023 at 08:26:36AM -0600, Simon Glass wrote: > > > > > > > > > Hi Sughosh, > > > > > > > > > > > > > > > > > > On Fri, 11 Aug 2023 at 08:23, Sughosh Ganu > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > On Fri, 11 Aug 2023 at 19:28, Tom Rini wrote: > > > > > > > > > > > > > > > > > > > > > > On Fri, Aug 11, 2023 at 04:29:37PM +0530, Sughosh Gan= u wrote: > > > > > > > > > > > > On Thu, 10 Aug 2023 at 22:47, Tom Rini wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sughosh= Ganu wrote: > > > > > > > > > > > > > > On Thu, 10 Aug 2023 at 21:22, Tom Rini > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530, Sug= hosh Ganu > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Build the mkeficapsule tool for all the san= dbox variants. > > > > > > > This tool > > > > > > > > > > > > > > > > will be used subsequently for testing capsu= le generation > > > > > > > in binman. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Sughosh Ganu > > > > > > > > > > > > > > > > --- > > > > > > > > > > > > > > > > Changes since V7: None > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > tools/Kconfig | 6 +++--- > > > > > > > > > > > > > > > > 1 file changed, 3 insertions(+), 3 deletio= ns(-) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/tools/Kconfig b/tools/Kconfig > > > > > > > > > > > > > > > > index 6e23f44d55..353a855243 100644 > > > > > > > > > > > > > > > > --- a/tools/Kconfig > > > > > > > > > > > > > > > > +++ b/tools/Kconfig > > > > > > > > > > > > > > > > @@ -91,10 +91,10 @@ config TOOLS_SHA512 > > > > > > > > > > > > > > > > Enable SHA512 support in the tools = builds > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > config TOOLS_MKEFICAPSULE > > > > > > > > > > > > > > > > - bool "Build efimkcapsule command" > > > > > > > > > > > > > > > > - default y if EFI_CAPSULE_ON_DISK > > > > > > > > > > > > > > > > + bool "Build mkeficapsule tool" > > > > > > > > > > > > > > > > + default y if EFI_CAPSULE_ON_DISK || S= ANDBOX > > > > > > > > > > > > > > > > help > > > > > > > > > > > > > > > > - This command allows users to create= a UEFI > > > > > > > capsule file and, > > > > > > > > > > > > > > > > + This tool allows users to create a = UEFI capsule > > > > > > > file and, > > > > > > > > > > > > > > > > optionally sign that file. If you w= ant to enable > > > > > > > UEFI capsule > > > > > > > > > > > > > > > > update feature on your target, you = certainly need > > > > > > > this. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Sorry, what is this fixing exactly? > > > > > > > > > > > > > > > > > > > > > > > > > > > > The tool is required to be supported on the san= dbox_spl > > > > > > > variant, since > > > > > > > > > > > > > > that is used for the binman tests in CI. Simon = had then asked > > > > > > > me to > > > > > > > > > > > > > > add support for the tool on all sandbox variant= s. I missed > > > > > > > putting his > > > > > > > > > > > > > > R-b on this patch. > > > > > > > > > > > > > > > > > > > > > > > > > > OK, moving forward just depend on: > > > > > > > > > > > > > > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/202308101652= 24.514772-1-trini@konsulko.com/ > > > > > > > > > > > > > instead please, thanks. > > > > > > > > > > > > > > > > > > > > > > > > I will base my changes on top of your patch. Howeve= r, we would > > > > > > > still > > > > > > > > > > > > need this patch as part of the series, since Simon = wants the > > > > > > > capsules > > > > > > > > > > > > to be generated for all the sandbox variants. Thank= s. > > > > > > > > > > > > > > > > > > > > > > No, this isn't needed. Any sandbox variant that need= s capsules has > > > > > > > > > > > EFI_CAPSULE_ON_DISK enabled. > > > > > > > > > > > > > > > > > > > > Simon wants the capsules to be generated on all sandbox= variants, > > > > > > > > > > including those that do not have the EFI_CAPSULE_ON_DIS= K enabled. > > > > > > > > > > Which is why we need to have the tool enabled for all s= andbox > > > > > > > > > > variants. > > > > > > > > > > > > > > > > > > I want to avoid #ifdefs in the sandbox .dts so far as pos= sible. > > > > > > > > > > > > > > > > > > Tom, I'll let you make the final decision. > > > > > > > > > > > > > > > > > > In any case, the multiple-images thing needs to be fixed. > > > > > > > > > > > > > > > > Sughosh, please update the other sandbox defconfigs to just= enable > > > > > > > > EFI_CAPSULE_ON_DISK. > > > > > > > > > > > > > > > > Simon, this I think is an example of where re-working > > > > > > > > configs/sandbox64_defconfig > > > > > > > > configs/sandbox_defconfig > > > > > > > > configs/sandbox_flattree_defconfig > > > > > > > > configs/sandbox_noinst_defconfig > > > > > > > > configs/sandbox_spl_defconfig > > > > > > > > configs/sandbox_vpl_defconfig > > > > > > > > > > > > > > > > To be configs/sandbox_defconfig + boards/sandbox/flattree.c= onfig, > > > > > > > > noinst.config, spl.config, vpl.config would be helpful. Th= ere's the > > > > > > > > sandbox config itself where EFI_CAPSULE_ON_DISK=3Dy and the= n every other > > > > > > > > variant just gets that, and we don't have to tweak N config= s. > > > > > > > > > > > > > > You mean split configs? So far I am unable to build those... > > > > > > > > > > > > I don't know what you mean by split configs. I mean that I thi= nk the > > > > > > only intentional difference between configs/sandbox_defconfig a= nd > > > > > > configs/sandbox64_defconfig is: > > > > > > CONFIG_SANDBOX64=3Dy > > > > > > CONFIG_DEFAULT_DEVICE_TREE=3D"sandbox64" > > > > > > > > > > > > And everything else is unintentional. And there's lots of othe= r deltas > > > > > > like that between each of the other variants, and sandbox. And= that > > > > > > this isn't the first, nor likely the last, time where we need t= o enable > > > > > > some option on other sandbox config files too, so that CI passe= s. This > > > > > > would all be avoided by using the config fragments mechanism so= that > > > > > > we captured only the intentional delta of a fragment rather than > > > > > > maintaining N nearly identical, but not quite, files. > > > > > > > > > > Well we do have other intentional differences, e.g. OF_LIVE. But = OK if > > > > > we can find a way to make fragments work with buildman (amd qconf= ig), > > > > > then we could do this. > > > > > > > > Yes, I was noting this in hopes of sparking your interest in figuri= ng > > > > out how to handle fragments with buildman. It's similar to how we = have > > > > the override option today. > > > > > > We need a list of fragments somewhere, so that it is possible to > > > enumerate the different board combinations. Does the main defconfig > > > have a way to specify this, or could we add it? > > > > No, I don't think that's the right way to go. I was thinking of > > something along the lines of how --adjust-cfg works, but instead it's a > > csv of additional targets to pass along with the defconfig name when > > invoking make. >=20 > So we would do them one at a time, with the 'name' of the board being > some portion of the filename of the config-fragment file? >=20 > BTW CSV is not great for humans...perhaps a text file with columns > like boards.cfg ? I think you're still missing what I'm saying. There should not be a file that lists fragments. Outside of documentation, at least. I was saying csv above because it would make sense to do something like: =2E/tools/buildman/buildman --add-fragments=3D64bit,vpl sandbox And that would eventually do: make sandbox_config 64bit.config vpl.config Which has the standard Kconfig merging of configs/sandbox_defconfig boards/sandbox/64bit.config (replaces sandbox64_defconfig) and boards/sandbox/vpl.config And passing multiple files with a comma seems easiest. --=20 Tom --QRBppMvewktuHGUZ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTYz0cACgkQFHw5/5Y0 tyyfggwAlAdS97Vb2HS/N6okoZfqXdrPDVdPOgLWlwNIyrmojXdlnUUhOCCS8QoM oaBW0gr8s1P/sN2+2tugmKL2HLaMmEsmqPzeIta2SMeRKFhOmxNVM8k8xuOBxDhw ocFbtSQZ2GTC6zxYhWsS+4Y02EHhg4dja3NWTOeTTdfic8l46QKPePmAYBAs+3+v KxWRIwsKb1SDEd3AsUPF+oZgGL5/vYkn8OE9yA3wH21+eK1zk6DCyQj2grUr/aBl rBvGoAiWYp8sSQwUUJ19rDYeT3LZ/ElxGkX6fED+KIa1GTWycUQNZkweSJNsKuSu EKTZE5g/O+Gc0xU0hA2jeGL2VV1iMR1HqHd4xYoUfnx2+m5IA7TDDoWCWs0wtXQ0 JN3eQPGw5+CqYzJI8mLzsfk/7KjCuLipQuR8jSujfKnEPmPPbtt436o+EmwyeyLd /fCH43vurvK6N7c4mCEpg7z8tr7LivK9ciNI+GRbqYENWnN6TZMkAnxYIxCf7xuC g7b77VeZ =r+0c -----END PGP SIGNATURE----- --QRBppMvewktuHGUZ--