From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9931C001B0 for ; Sun, 13 Aug 2023 14:44:00 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 718AE847C3; Sun, 13 Aug 2023 16:43:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="TtEj5miP"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B48F3847C3; Sun, 13 Aug 2023 16:43:58 +0200 (CEST) Received: from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com [IPv6:2607:f8b0:4864:20::1134]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 22EC78475C for ; Sun, 13 Aug 2023 16:43:56 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1134.google.com with SMTP id 00721157ae682-5844bb9923eso40635367b3.0 for ; Sun, 13 Aug 2023 07:43:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1691937835; x=1692542635; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1A1hmdbG5REk/ZoOGRsURtdaoazYHuljK9OgJL5BMlQ=; b=TtEj5miP9egojel/SR6pTnf95RKqKyezJEDwSVSB0bJmj1z+H2wS6TYM00PbKlUMcA MVFXLpDiO0DihwI8Ps2D9q8JN3G+oxycYv0K0kjvs5+R2+Pbczw7RxQ2uI9fZleNHFar 1rViv2SMNREMvyyxhg/72TCX0FjwqFgczVQMY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691937835; x=1692542635; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1A1hmdbG5REk/ZoOGRsURtdaoazYHuljK9OgJL5BMlQ=; b=hyTiymTVN7pmuF6NUcuGwpZX2TH4wQf6mHk1NLP6RZR6GNyA4JHalYRN4uG+9u7/Bx eIgfE5l++XF49PK5tQwL5ln+9xcn+6wPHCNQJANZxDpm66fDjmvaudMXV/L3X80IT9fQ srn4iul/5diLjWQm1wQhQ4t0e5xtXsDMUYZUDa/CU6XMnJ/6scxqc90WNAKzIKstF7gk CRReWVgQ80n0DutK3qmMyGL7tz38FHJ5nWy+RqjrO/oTwFw7YSx8hcjf5Kxlce6HknIb 6ITJ9iEWYbmtJ5v36yaK+y34FHYzHFCNlC9eKYgZ0lnJ1OK5upZLXPzbF8wpsB8hJSO4 mBJg== X-Gm-Message-State: AOJu0YzyT/UIuStpuE2QVsJxNYVP1+iXyV7HE8uo+DPhkVyoUjqQj/W/ cwJZ4LC6aKiJefbfdxfv7Aib+w== X-Google-Smtp-Source: AGHT+IECGJV/4fXbPfgle469gxN4YfJmdt/GZzNo96jqyM4FyvPpwAzuxX7y2CzhlVaeopUjEI6FaQ== X-Received: by 2002:a0d:dfd6:0:b0:56c:e706:2e04 with SMTP id i205-20020a0ddfd6000000b0056ce7062e04mr8701693ywe.0.1691937834787; Sun, 13 Aug 2023 07:43:54 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-b7a2-eada-624b-a58a.res6.spectrum.com. [2603:6081:7b00:6400:b7a2:eada:624b:a58a]) by smtp.gmail.com with ESMTPSA id t12-20020a81830c000000b005772abf6234sm2233945ywf.11.2023.08.13.07.43.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Aug 2023 07:43:54 -0700 (PDT) Date: Sun, 13 Aug 2023 10:43:52 -0400 From: Tom Rini To: Simon Glass Cc: Sughosh Ganu , U-Boot Mailing List , Heinrich Schuchardt , Ilias Apalodimas , Takahiro Akashi , Malte Schmidt , Michal Simek Subject: Re: [PATCH v8 4/9] sandbox: Build the mkeficapsule tool for the sandbox variants Message-ID: <20230813144352.GM3630934@bill-the-cat> References: <20230811155613.GE3630934@bill-the-cat> <20230812142223.GI3630934@bill-the-cat> <20230812142824.GJ3630934@bill-the-cat> <20230812223758.GK3630934@bill-the-cat> <20230813124045.GL3630934@bill-the-cat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XRJCMBfLSVsx56Iq" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --XRJCMBfLSVsx56Iq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 13, 2023 at 07:36:45AM -0600, Simon Glass wrote: > Hi Tom, >=20 > On Sun, 13 Aug 2023 at 06:40, Tom Rini wrote: > > > > On Sat, Aug 12, 2023 at 06:14:45PM -0600, Simon Glass wrote: > > > Hi Tom, > > > > > > On Sat, 12 Aug 2023 at 16:38, Tom Rini wrote: > > > > > > > > On Sat, Aug 12, 2023 at 11:03:36AM -0600, Simon Glass wrote: > > > > > Hi Tom, > > > > > > > > > > On Sat, 12 Aug 2023 at 08:28, Tom Rini wrote: > > > > > > > > > > > > On Sat, Aug 12, 2023 at 08:24:59AM -0600, Simon Glass wrote: > > > > > > > Hi Tom, > > > > > > > > > > > > > > On Sat, 12 Aug 2023 at 08:22, Tom Rini w= rote: > > > > > > > > > > > > > > > > On Sat, Aug 12, 2023 at 07:08:44AM -0600, Simon Glass wrote: > > > > > > > > > Hi Tom, > > > > > > > > > > > > > > > > > > On Fri, 11 Aug 2023 at 09:56, Tom Rini wrote: > > > > > > > > > > > > > > > > > > > > On Fri, Aug 11, 2023 at 08:26:36AM -0600, Simon Glass w= rote: > > > > > > > > > > > Hi Sughosh, > > > > > > > > > > > > > > > > > > > > > > On Fri, 11 Aug 2023 at 08:23, Sughosh Ganu > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 11 Aug 2023 at 19:28, Tom Rini wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, Aug 11, 2023 at 04:29:37PM +0530, Sughosh= Ganu wrote: > > > > > > > > > > > > > > On Thu, 10 Aug 2023 at 22:47, Tom Rini wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Aug 10, 2023 at 10:39:06PM +0530, Sug= hosh Ganu wrote: > > > > > > > > > > > > > > > > On Thu, 10 Aug 2023 at 21:22, Tom Rini > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Aug 10, 2023 at 07:53:33PM +0530,= Sughosh Ganu > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Build the mkeficapsule tool for all the= sandbox variants. > > > > > > > > > This tool > > > > > > > > > > > > > > > > > > will be used subsequently for testing c= apsule generation > > > > > > > > > in binman. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Sughosh Ganu > > > > > > > > > > > > > > > > > > --- > > > > > > > > > > > > > > > > > > Changes since V7: None > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > tools/Kconfig | 6 +++--- > > > > > > > > > > > > > > > > > > 1 file changed, 3 insertions(+), 3 del= etions(-) > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > diff --git a/tools/Kconfig b/tools/Kcon= fig > > > > > > > > > > > > > > > > > > index 6e23f44d55..353a855243 100644 > > > > > > > > > > > > > > > > > > --- a/tools/Kconfig > > > > > > > > > > > > > > > > > > +++ b/tools/Kconfig > > > > > > > > > > > > > > > > > > @@ -91,10 +91,10 @@ config TOOLS_SHA512 > > > > > > > > > > > > > > > > > > Enable SHA512 support in the to= ols builds > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > config TOOLS_MKEFICAPSULE > > > > > > > > > > > > > > > > > > - bool "Build efimkcapsule command" > > > > > > > > > > > > > > > > > > - default y if EFI_CAPSULE_ON_DISK > > > > > > > > > > > > > > > > > > + bool "Build mkeficapsule tool" > > > > > > > > > > > > > > > > > > + default y if EFI_CAPSULE_ON_DISK = || SANDBOX > > > > > > > > > > > > > > > > > > help > > > > > > > > > > > > > > > > > > - This command allows users to cr= eate a UEFI > > > > > > > > > capsule file and, > > > > > > > > > > > > > > > > > > + This tool allows users to creat= e a UEFI capsule > > > > > > > > > file and, > > > > > > > > > > > > > > > > > > optionally sign that file. If y= ou want to enable > > > > > > > > > UEFI capsule > > > > > > > > > > > > > > > > > > update feature on your target, = you certainly need > > > > > > > > > this. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Sorry, what is this fixing exactly? > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > The tool is required to be supported on the= sandbox_spl > > > > > > > > > variant, since > > > > > > > > > > > > > > > > that is used for the binman tests in CI. Si= mon had then asked > > > > > > > > > me to > > > > > > > > > > > > > > > > add support for the tool on all sandbox var= iants. I missed > > > > > > > > > putting his > > > > > > > > > > > > > > > > R-b on this patch. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > OK, moving forward just depend on: > > > > > > > > > > > > > > > > > > > > > > > > https://patchwork.ozlabs.org/project/uboot/patch/20230810= 165224.514772-1-trini@konsulko.com/ > > > > > > > > > > > > > > > instead please, thanks. > > > > > > > > > > > > > > > > > > > > > > > > > > > > I will base my changes on top of your patch. Ho= wever, we would > > > > > > > > > still > > > > > > > > > > > > > > need this patch as part of the series, since Si= mon wants the > > > > > > > > > capsules > > > > > > > > > > > > > > to be generated for all the sandbox variants. T= hanks. > > > > > > > > > > > > > > > > > > > > > > > > > > No, this isn't needed. Any sandbox variant that = needs capsules has > > > > > > > > > > > > > EFI_CAPSULE_ON_DISK enabled. > > > > > > > > > > > > > > > > > > > > > > > > Simon wants the capsules to be generated on all san= dbox variants, > > > > > > > > > > > > including those that do not have the EFI_CAPSULE_ON= _DISK enabled. > > > > > > > > > > > > Which is why we need to have the tool enabled for a= ll sandbox > > > > > > > > > > > > variants. > > > > > > > > > > > > > > > > > > > > > > I want to avoid #ifdefs in the sandbox .dts so far as= possible. > > > > > > > > > > > > > > > > > > > > > > Tom, I'll let you make the final decision. > > > > > > > > > > > > > > > > > > > > > > In any case, the multiple-images thing needs to be fi= xed. > > > > > > > > > > > > > > > > > > > > Sughosh, please update the other sandbox defconfigs to = just enable > > > > > > > > > > EFI_CAPSULE_ON_DISK. > > > > > > > > > > > > > > > > > > > > Simon, this I think is an example of where re-working > > > > > > > > > > configs/sandbox64_defconfig > > > > > > > > > > configs/sandbox_defconfig > > > > > > > > > > configs/sandbox_flattree_defconfig > > > > > > > > > > configs/sandbox_noinst_defconfig > > > > > > > > > > configs/sandbox_spl_defconfig > > > > > > > > > > configs/sandbox_vpl_defconfig > > > > > > > > > > > > > > > > > > > > To be configs/sandbox_defconfig + boards/sandbox/flattr= ee.config, > > > > > > > > > > noinst.config, spl.config, vpl.config would be helpful.= There's the > > > > > > > > > > sandbox config itself where EFI_CAPSULE_ON_DISK=3Dy and= then every other > > > > > > > > > > variant just gets that, and we don't have to tweak N co= nfigs. > > > > > > > > > > > > > > > > > > You mean split configs? So far I am unable to build those= =2E.. > > > > > > > > > > > > > > > > I don't know what you mean by split configs. I mean that I= think the > > > > > > > > only intentional difference between configs/sandbox_defconf= ig and > > > > > > > > configs/sandbox64_defconfig is: > > > > > > > > CONFIG_SANDBOX64=3Dy > > > > > > > > CONFIG_DEFAULT_DEVICE_TREE=3D"sandbox64" > > > > > > > > > > > > > > > > And everything else is unintentional. And there's lots of = other deltas > > > > > > > > like that between each of the other variants, and sandbox. = And that > > > > > > > > this isn't the first, nor likely the last, time where we ne= ed to enable > > > > > > > > some option on other sandbox config files too, so that CI p= asses. This > > > > > > > > would all be avoided by using the config fragments mechanis= m so that > > > > > > > > we captured only the intentional delta of a fragment rather= than > > > > > > > > maintaining N nearly identical, but not quite, files. > > > > > > > > > > > > > > Well we do have other intentional differences, e.g. OF_LIVE. = But OK if > > > > > > > we can find a way to make fragments work with buildman (amd q= config), > > > > > > > then we could do this. > > > > > > > > > > > > Yes, I was noting this in hopes of sparking your interest in fi= guring > > > > > > out how to handle fragments with buildman. It's similar to how= we have > > > > > > the override option today. > > > > > > > > > > We need a list of fragments somewhere, so that it is possible to > > > > > enumerate the different board combinations. Does the main defconf= ig > > > > > have a way to specify this, or could we add it? > > > > > > > > No, I don't think that's the right way to go. I was thinking of > > > > something along the lines of how --adjust-cfg works, but instead it= 's a > > > > csv of additional targets to pass along with the defconfig name when > > > > invoking make. > > > > > > So we would do them one at a time, with the 'name' of the board being > > > some portion of the filename of the config-fragment file? > > > > > > BTW CSV is not great for humans...perhaps a text file with columns > > > like boards.cfg ? > > > > I think you're still missing what I'm saying. There should not be a > > file that lists fragments. Outside of documentation, at least. I was > > saying csv above because it would make sense to do something like: > > ./tools/buildman/buildman --add-fragments=3D64bit,vpl sandbox > > And that would eventually do: > > make sandbox_config 64bit.config vpl.config > > Which has the standard Kconfig merging of configs/sandbox_defconfig > > boards/sandbox/64bit.config (replaces sandbox64_defconfig) and > > boards/sandbox/vpl.config > > And passing multiple files with a comma seems easiest. >=20 > So is it only possible to add one fragment file to a build? The example above is two, and yes, N config fragments works (they are merged in listed order). > I see what you are saying, but from my side I am trying to enumerate > the boards, since generally I (like) build things without explicitly > specifying each board defconfig. Yes, but that's not possible in this case I think. And I'm really just trying to figure out how we can make CI a little easier. But maybe we can't / don't bother in this case and keep fixing up the sandbox defconfig files as needed. --=20 Tom --XRJCMBfLSVsx56Iq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmTY7CIACgkQFHw5/5Y0 tyzVmAv/R5JgO1uRwUvSmfQ/yQigy+xAOJu1Vbhv8Ufxe4Yk2mNMS9XjtGKG5J4x Xbvh6fHul68AKpUYmIXms0wMtsaPDzgrfTOYcnb9x2O1l73jxtY3tHVO1GRVnhSZ itZ1IZU10M/LvOemtFZEzv/id96TXInm1vVb9sI6CYfn09N5bZ6Q5k2r/+axZXaQ XtoG68K2mCPVXcc4ltLuQJHuxNAEmEqwF3kM4nevo9dZD+Yfq5q9URqZSy2dHToW lR/AzN8ajhP47FC8UGipxFs7B7Tnf6tGsT0R/il+jVmUB+Pek3aWvmqmzSgT1sSt E0vbOcJTzhoCHdrCPyhEcyP8HxJP1xTodzEKknEGkd9Lbo07uqPo0rRA7/Huk/x9 rA6iYDFKUVUbyNADDPlRFgJqwCzos0DM1yM/RyBAw5AFUVouvbiOEpXf9hpvQk7F 3uDUObZDLzY/kDSma14QBxv2xayrZLlPRJSSdXKyxoHb/fIcIdqrqX75jiWspuHN feZ4+aSy =gUVn -----END PGP SIGNATURE----- --XRJCMBfLSVsx56Iq--