From: Tom Rini <trini@konsulko.com>
To: Marek Vasut <marex@denx.de>
Cc: u-boot@lists.denx.de, "Jonas Karlman" <jonas@kwiboo.se>,
"Pali Rohár" <pali@kernel.org>, "Bin Meng" <bmeng.cn@gmail.com>,
"Michal Suchanek" <msuchanek@suse.de>,
"Simon Glass" <sjg@chromium.org>
Subject: Re: [PATCH] pci: Fix device_find_first_child() return value handling
Date: Tue, 15 Aug 2023 10:42:59 -0400 [thread overview]
Message-ID: <20230815144259.GO3630934@bill-the-cat> (raw)
In-Reply-To: <20230716155324.11211-1-marex@denx.de>
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
On Sun, Jul 16, 2023 at 05:53:24PM +0200, Marek Vasut wrote:
> This function only ever returns 0, but may not assign the second
> parameter. Same thing for device_find_next_child(). Do not assign
> ret to stop proliferation of this misuse.
>
> Reported-by: Jonas Karlman <jonas@kwiboo.se>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/next, thanks!
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
prev parent reply other threads:[~2023-08-15 14:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-16 15:53 [PATCH] pci: Fix device_find_first_child() return value handling Marek Vasut
2023-07-17 7:42 ` Michal Suchánek
2023-07-17 17:03 ` Marek Vasut
2023-07-27 0:49 ` Simon Glass
2023-07-27 6:42 ` Michal Suchánek
2023-08-15 14:42 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815144259.GO3630934@bill-the-cat \
--to=trini@konsulko.com \
--cc=bmeng.cn@gmail.com \
--cc=jonas@kwiboo.se \
--cc=marex@denx.de \
--cc=msuchanek@suse.de \
--cc=pali@kernel.org \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox