From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Cc: Marek Vasut <marex@denx.de>, Angus Ainslie <angus@akkea.ca>,
Dmitrii Merkurev <dimorinny@google.com>,
Eddie Cai <eddie.cai.linux@gmail.com>,
Kever Yang <kever.yang@rock-chips.com>,
Lukasz Majewski <lukma@denx.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Nishanth Menon <nm@ti.com>,
Patrice Chotard <patrice.chotard@foss.st.com>,
Patrick Delaunay <patrick.delaunay@foss.st.com>,
Philipp Tomsich <philipp.tomsich@vrull.eu>,
Simon Glass <sjg@chromium.org>, Stefan Roese <sr@denx.de>,
kernel@puri.sm
Subject: [PATCH 15/17] usb: gadget: ether: Use plain udevice for UDC controller interaction
Date: Sat, 19 Aug 2023 16:24:05 +0200 [thread overview]
Message-ID: <20230819142407.49632-15-marex@denx.de> (raw)
In-Reply-To: <20230819142407.49632-1-marex@denx.de>
Convert to plain udevice interaction with UDC controller
device, avoid the use of UDC uclass dev_array .
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Angus Ainslie <angus@akkea.ca>
Cc: Dmitrii Merkurev <dimorinny@google.com>
Cc: Eddie Cai <eddie.cai.linux@gmail.com>
Cc: Kever Yang <kever.yang@rock-chips.com>
Cc: Lukasz Majewski <lukma@denx.de>
Cc: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: Nishanth Menon <nm@ti.com>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Cc: Philipp Tomsich <philipp.tomsich@vrull.eu>
Cc: Simon Glass <sjg@chromium.org>
Cc: Stefan Roese <sr@denx.de>
Cc: kernel@puri.sm
---
drivers/usb/gadget/ether.c | 22 +++++++++++++++-------
1 file changed, 15 insertions(+), 7 deletions(-)
diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c
index 5ff06d3814b..cb1317fd9f3 100644
--- a/drivers/usb/gadget/ether.c
+++ b/drivers/usb/gadget/ether.c
@@ -137,6 +137,7 @@ struct eth_dev {
struct ether_priv {
struct eth_dev ethdev;
struct udevice *netdev;
+ struct udevice *udcdev;
struct usb_gadget_driver eth_driver;
};
@@ -1895,7 +1896,7 @@ static int eth_stop(struct eth_dev *dev)
/* Wait until host receives OID_GEN_MEDIA_CONNECT_STATUS */
ts = get_timer(0);
while (get_timer(ts) < timeout)
- usb_gadget_handle_interrupts(0);
+ dm_usb_gadget_handle_interrupts(priv->udcdev);
#endif
rndis_uninit(dev->rndis_config);
@@ -2300,7 +2301,7 @@ static int usb_eth_start(struct udevice *udev)
pr_err("The remote end did not respond in time.");
goto fail;
}
- usb_gadget_handle_interrupts(0);
+ dm_usb_gadget_handle_interrupts(priv->udcdev);
}
packet_received = 0;
@@ -2370,7 +2371,7 @@ static int usb_eth_send(struct udevice *udev, void *packet, int length)
printf("timeout sending packets to usb ethernet\n");
return -1;
}
- usb_gadget_handle_interrupts(0);
+ dm_usb_gadget_handle_interrupts(priv->udcdev);
}
free(rndis_pkt);
@@ -2406,7 +2407,7 @@ static void usb_eth_stop(struct udevice *udev)
/* Clear pending interrupt */
if (dev->network_started) {
- usb_gadget_handle_interrupts(0);
+ dm_usb_gadget_handle_interrupts(priv->udcdev);
dev->network_started = 0;
}
}
@@ -2416,7 +2417,7 @@ static int usb_eth_recv(struct udevice *dev, int flags, uchar **packetp)
struct ether_priv *priv = dev_get_priv(dev);
struct eth_dev *ethdev = &priv->ethdev;
- usb_gadget_handle_interrupts(0);
+ dm_usb_gadget_handle_interrupts(priv->udcdev);
if (packet_received) {
if (ethdev->rx_req) {
@@ -2452,6 +2453,7 @@ static const struct eth_ops usb_eth_ops = {
int usb_ether_init(void)
{
+ struct ether_priv *priv;
struct udevice *usb_dev;
int ret;
@@ -2467,7 +2469,8 @@ int usb_ether_init(void)
return ret;
}
- return usb_gadget_initialize(0);
+ priv = dev_get_priv(usb_dev);
+ return udc_device_get_by_index(0, &priv->udcdev);
}
static int usb_eth_probe(struct udevice *dev)
@@ -2478,6 +2481,9 @@ static int usb_eth_probe(struct udevice *dev)
priv->netdev = dev;
l_priv = priv;
+ if (!priv->udcdev)
+ priv->udcdev = dev->parent;
+
get_ether_addr(CONFIG_USBNET_DEV_ADDR, pdata->enetaddr);
eth_env_set_enetaddr("usbnet_devaddr", pdata->enetaddr);
@@ -2528,7 +2534,9 @@ static int usb_eth_remove(struct udevice *dev)
static int usb_eth_unbind(struct udevice *dev)
{
- usb_gadget_release(0);
+ struct ether_priv *priv = dev_get_priv(dev);
+
+ udc_device_put(priv->udcdev);
return 0;
}
--
2.40.1
next prev parent reply other threads:[~2023-08-19 14:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-19 14:23 [PATCH 01/17] dm: usb: udc: Factor out plain udevice handler functions Marek Vasut
2023-08-19 14:23 ` [PATCH 02/17] usb: sandbox: Add DM_USB_GADGET support Marek Vasut
2023-08-20 17:48 ` Simon Glass
2023-08-22 16:10 ` Mattijs Korpershoek
2023-08-19 14:23 ` [PATCH 03/17] configs: sandbox: Enable DM_USB_GADGET Marek Vasut
2023-08-20 17:48 ` Simon Glass
2023-08-22 16:10 ` Mattijs Korpershoek
2023-08-19 14:23 ` [PATCH 04/17] cmd: fastboot: Use plain udevice for UDC controller interaction Marek Vasut
2023-08-22 16:22 ` Mattijs Korpershoek
2023-08-19 14:23 ` [PATCH 05/17] cmd: rockusb: " Marek Vasut
2023-08-19 14:23 ` [PATCH 06/17] cmd: sdp: Reorder variable declaration Marek Vasut
2023-08-22 16:24 ` Mattijs Korpershoek
2023-08-19 14:23 ` [PATCH 07/17] cmd: thordown: " Marek Vasut
2023-08-19 14:23 ` [PATCH 08/17] cmd: ums: Use plain udevice for UDC controller interaction Marek Vasut
2023-08-22 16:29 ` Mattijs Korpershoek
2023-08-19 14:23 ` [PATCH 09/17] dfu: Detach the controller on error Marek Vasut
2023-08-22 16:32 ` Mattijs Korpershoek
2023-08-19 14:24 ` [PATCH 10/17] dfu: Use plain udevice for UDC controller interaction Marek Vasut
2023-08-22 16:33 ` Mattijs Korpershoek
2023-08-19 14:24 ` [PATCH 11/17] spl: sdp: Detach the controller on error Marek Vasut
2023-08-22 16:44 ` Mattijs Korpershoek
2023-09-01 9:52 ` Marek Vasut
2023-08-19 14:24 ` [PATCH 12/17] sdp: Use plain udevice for UDC controller interaction Marek Vasut
2023-08-22 16:46 ` Mattijs Korpershoek
2023-08-19 14:24 ` [PATCH 13/17] thordown: " Marek Vasut
2023-08-19 14:24 ` [PATCH 14/17] usb: gadget: acm: " Marek Vasut
2023-08-19 14:24 ` Marek Vasut [this message]
2023-08-19 14:24 ` [PATCH 16/17] dm: usb: udc: Drop legacy udevice handler functions Marek Vasut
2023-08-22 16:52 ` Mattijs Korpershoek
2023-08-19 14:24 ` [PATCH 17/17] board: usb: Replace legacy usb_gadget_handle_interrupts() Marek Vasut
2023-08-22 16:58 ` Mattijs Korpershoek
2023-08-21 8:39 ` [PATCH 01/17] dm: usb: udc: Factor out plain udevice handler functions Miquel Raynal
2023-08-22 16:07 ` Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230819142407.49632-15-marex@denx.de \
--to=marex@denx.de \
--cc=angus@akkea.ca \
--cc=dimorinny@google.com \
--cc=eddie.cai.linux@gmail.com \
--cc=kernel@puri.sm \
--cc=kever.yang@rock-chips.com \
--cc=lukma@denx.de \
--cc=miquel.raynal@bootlin.com \
--cc=mkorpershoek@baylibre.com \
--cc=nm@ti.com \
--cc=patrice.chotard@foss.st.com \
--cc=patrick.delaunay@foss.st.com \
--cc=philipp.tomsich@vrull.eu \
--cc=sjg@chromium.org \
--cc=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox