Re: [PATCH 01/17] dm: usb: udc: Factor out plain udevice handler functions

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Marek,

marex@denx.de wrote on Sat, 19 Aug 2023 16:23:51 +0200:

> Pull the functionality of UDC uclass that operates on plain udevice
> and does not use this dev_array array into separate functions and
> expose those functions, so that as much code as possible can be
> switched over to these functions and the dev_array can be dropped.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Angus Ainslie <angus@akkea.ca>
> Cc: Dmitrii Merkurev <dimorinny@google.com>
> Cc: Eddie Cai <eddie.cai.linux@gmail.com>
> Cc: Kever Yang <kever.yang@rock-chips.com>
> Cc: Lukasz Majewski <lukma@denx.de>
> Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> Cc: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Patrice Chotard <patrice.chotard@foss.st.com>
> Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
> Cc: Philipp Tomsich <philipp.tomsich@vrull.eu>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Stefan Roese <sr@denx.de>
> Cc: kernel@puri.sm
> ---

Would you mind adding a cover letter to your series? It would be easier
for us to (a) know what is the final purpose of the series and (b) have
a location where to send global feedback.

Indeed, I did not yet investigate, in particular because every time
fastboot is broken I cannot easily test new images without going
through a whole recovery step with another image, but it seems like the
network over USB is no longer working (not 100% sure about that one,
sometimes the network is capricious) and anyway just calling unbind
crashes:

=> dm tree
[...]
 misc          0  [ + ]   ti-musb-wrapper       |   |-- usb@47400000
 usb           0  [ + ]   ti-musb-peripheral    |   |   |-- usb@47401000
 ethernet      1  [ + ]   usb_ether             |   |   |   `-- usb_ether
 bootdev       3  [   ]   eth_bootdev           |   |   |       `-- usb_ether.bootdev
 usb           0  [   ]   ti-musb-host          |   |   `-- usb@47401800
=> unbind ethernet 1
data abort
pc : [<9ff9a0e6>]          lr : [<9ff9a0e7>]
reloc pc : [<808350e6>]    lr : [<808350e7>]
sp : 9df2f998  ip : 0000001c     fp : 00000003
r10: 9df4d800  r9 : 9df44ea0     r8 : 9ffe4a0c
r7 : 9ff82ad9  r6 : 9df4d800     r5 : 84000000  r4 : 9df4cf48
r3 : 9ff9a0e1  r2 : 00000000     r1 : 00000000  r0 : 00000000
Flags: NzCv  IRQs off  FIQs on  Mode SVC_32 (T)
Code: 9ffd b508 f7ec fe63 (f8d0) 00b0 
Resetting CPU ...

Thanks,
Miquèl