Re: [PATCH 1/2] drivers/mtd/nvmxip: Rework the read accessor to support 32bit systems

[Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>]

Hi,

On Sat, Aug 19, 2023 at 02:23:02AM +0200, Marek Vasut wrote:
> On 8/13/23 23:46, Marek Vasut wrote:
> > Get rid of nvmxip_mmio_rawread() and just implement the readl()/readq()
> > reader loop within nvmxip_blk_read(). Cast the destination buffer as
> > needed and increment the read by either 4 or 8 bytes depending on if
> > this is systemd with 32bit or 64bit physical address.
> > 
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@mailbox.org>
> > ---
> > Cc: Abdellatif El Khlifi <abdellatif.elkhlifi@arm.com>
> > Cc: Simon Glass <sjg@chromium.org>
> 
> Sandbox CI test fails with this series:
> 
> https://source.denx.de/u-boot/custodians/u-boot-sh/-/pipelines/17427
> 
> https://u-boot.source-pages.denx.de/-/custodians/u-boot-sh/-/jobs/679256/artifacts/test-log.html
> 

I run the {host , blk_usb, blk_iter, blk_foreach, blk_flags} tests using the commit [1] preceding the NVMXIP patchset.
The tests fail as shown below [3]. I think these issues are not related to NVMXIP.

Regarding your comments for [2], I'll address them as soon as I can. 

[1]: b197f1f05dee730e173a0756cb1a5f2be5d3ba5b
[2]: https://lore.kernel.org/all/20230816110551.86930-2-abdellatif.elkhlifi@arm.com/
[3]: tests results:

host:

test/dm/host.c:44, dm_test_host(): 0 == host_attach_file(dev, filename): Expected 0x0 (0), got 0xfffffffe (-2)
Segmentation fault (core dumped)

blk_usb:

test/dm/blk.c:88, dm_test_blk_usb(): 6 == count_blk_devices(): Expected 0x6 (6), got 0x1 (1)
Bus usb@1: scanning bus usb@1 for devices... 2 USB Device(s) found
test/dm/blk.c:93, dm_test_blk_usb(): 6 == count_blk_devices(): Expected 0x6 (6), got 0x1 (1)
Test blk_usb failed 4 times

blk_iter:

test/dm/blk.c:188, dm_test_blk_iter(): 0 == blk_first_device_err(BLKF_FIXED, &dev): Expected 0x0 (0), got 0xffffffed (-19)
Segmentation fault (core dumped)

blk_foreach:

test/dm/blk.c:305, dm_test_blk_foreach(): 7 == found: Expected 0x7 (7), got 0x0 (0)
test/dm/blk.c:316, dm_test_blk_foreach(): 7 == found: Expected 0x7 (7), got 0x0 (0)
test/dm/blk.c:322, dm_test_blk_foreach(): 7 == found: Expected 0x7 (7), got 0x0 (0)
test/dm/blk.c:323, dm_test_blk_foreach(): 3 == blk_count_devices(BLKF_BOTH): Expected 0x3 (3), got 0x0 (0)
test/dm/blk.c:328, dm_test_blk_foreach(): 4 == found: Expected 0x4 (4), got 0x0 (0)
test/dm/blk.c:329, dm_test_blk_foreach(): 1 == blk_count_devices(BLKF_FIXED): Expected 0x1 (1), got 0x0 (0)
test/dm/blk.c:334, dm_test_blk_foreach(): 3 == found: Expected 0x3 (3), got 0x0 (0)
test/dm/blk.c:335, dm_test_blk_foreach(): 2 == blk_count_devices(BLKF_REMOVABLE): Expected 0x2 (2), got 0x0 (0)
...

blk_flags:

test/dm/blk.c:236, dm_test_blk_flags(): 0 == blk_find_first(BLKF_BOTH, &dev): Expected 0x0 (0), got 0xffffffed (-19)
test/dm/blk.c:237, dm_test_blk_flags(): dev = NULL: Expected non-null, got NULL
Segmentation fault (core dumped)

Cheers,
Abdellatif