public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Neha Francis <n-francis@ti.com>, Tom Rini <trini@konsulko.com>
Cc: Bryan <bb@ti.com>, Praneeth <praneeth@ti.com>,
	Andrew <afd@ti.com>, Robert Nelson <robertcnelson@gmail.com>,
	Vignesh <vigneshr@ti.com>, <u-boot@lists.denx.de>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	Jan Kiszka <jan.kiszka@siemens.com>, Nitin Yadav <n-yadav@ti.com>,
	Nishanth Menon <nm@ti.com>
Subject: [PATCH V4 4/8] drivers: mmc: am654_sdhci: Update OTAP/ITAP delay
Date: Tue, 22 Aug 2023 13:41:31 -0500	[thread overview]
Message-ID: <20230822184135.2328409-5-nm@ti.com> (raw)
In-Reply-To: <20230822184135.2328409-1-nm@ti.com>

From: Nitin Yadav <n-yadav@ti.com>

U-Boot is fail to boot class U1 UHS SD cards (such as microcenter)
due to incorrect OTAP and ITAP delay select values. Update OTAP and
ITAP delay select values based on recommeded RIOT values to fix boot
issue.

Signed-off-by: Nitin Yadav <n-yadav@ti.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
Picked up from TI u-boot
New patch in the series

 drivers/mmc/am654_sdhci.c | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/mmc/am654_sdhci.c b/drivers/mmc/am654_sdhci.c
index fd667aeafdaa..d0b51c0707d4 100644
--- a/drivers/mmc/am654_sdhci.c
+++ b/drivers/mmc/am654_sdhci.c
@@ -442,12 +442,18 @@ static int j721e_4bit_sdhci_set_ios_post(struct sdhci_host *host)
 {
 	struct udevice *dev = host->mmc->dev;
 	struct am654_sdhci_plat *plat = dev_get_plat(dev);
-	u32 otap_del_sel, mask, val;
+	u32 otap_del_sel, itap_del_sel, mask, val;
 
 	otap_del_sel = plat->otap_del_sel[host->mmc->selected_mode];
-	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK;
-	val = (1 << OTAPDLYENA_SHIFT) | (otap_del_sel << OTAPDLYSEL_SHIFT);
+	itap_del_sel = plat->itap_del_sel[host->mmc->selected_mode];
+	mask = OTAPDLYENA_MASK | OTAPDLYSEL_MASK | ITAPDLYSEL_MASK |
+		ITAPDLYENA_MASK;
+	val = (1 << OTAPDLYENA_SHIFT) | (otap_del_sel << OTAPDLYSEL_SHIFT) |
+		(1 << ITAPDLYENA_SHIFT) | (itap_del_sel << ITAPDLYSEL_SHIFT);
+	regmap_update_bits(plat->base, PHY_CTRL4, ITAPCHGWIN_MASK,
+			   1 << ITAPCHGWIN_SHIFT);
 	regmap_update_bits(plat->base, PHY_CTRL4, mask, val);
+	regmap_update_bits(plat->base, PHY_CTRL4, ITAPCHGWIN_MASK, 0);
 
 	regmap_update_bits(plat->base, PHY_CTRL5, CLKBUFSEL_MASK,
 			   plat->clkbuf_sel);
@@ -501,7 +507,7 @@ static int sdhci_am654_get_otap_delay(struct udevice *dev,
 	 * Remove the corresponding capability if an otap-del-sel
 	 * value is not found
 	 */
-	for (i = MMC_HS; i <= MMC_HS_400; i++) {
+	for (i = MMC_LEGACY; i <= MMC_HS_400; i++) {
 		ret = dev_read_u32(dev, td[i].otap_binding,
 				   &plat->otap_del_sel[i]);
 		if (ret) {
-- 
2.40.0


  parent reply	other threads:[~2023-08-22 18:42 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-22 18:41 [PATCH V4 0/8] board: ti: Add support for BeaglePlay Nishanth Menon
2023-08-22 18:41 ` [PATCH V4 1/8] env_default: Allow CONFIG_EXTRA_ENV_TEXT to override CFG_EXTRA_ENV_SETTINGS Nishanth Menon
2023-08-22 23:16   ` Simon Glass
2023-08-22 23:33     ` Nishanth Menon
2023-08-23  2:34       ` Simon Glass
2023-08-23 11:42         ` Nishanth Menon
2023-08-23  7:47   ` Mattijs Korpershoek
2023-08-23 14:42   ` Tom Rini
2023-08-23 15:06     ` Nishanth Menon
2023-08-23 15:17       ` Tom Rini
2023-08-22 18:41 ` [PATCH V4 2/8] configs: am62x_evm*: Enable EMMC_BOOT configuration Nishanth Menon
2023-08-23  7:50   ` Mattijs Korpershoek
2023-08-22 18:41 ` [PATCH V4 3/8] arm: mach-k3: am625: Add support for UDA FS Nishanth Menon
2023-08-23  7:54   ` Mattijs Korpershoek
2023-08-22 18:41 ` Nishanth Menon [this message]
2023-08-23  8:06   ` [PATCH V4 4/8] drivers: mmc: am654_sdhci: Update OTAP/ITAP delay Mattijs Korpershoek
2023-08-23 10:15     ` Nitin Yadav
2023-08-23 10:18       ` Nitin Yadav
2023-08-23 11:38         ` Nishanth Menon
2023-08-23 14:21           ` Nishanth Menon
2023-08-22 18:41 ` [PATCH V4 5/8] arm: dts: k3-am625-sk-binman: Add labels for unsigned binary Nishanth Menon
2023-08-23  8:09   ` Mattijs Korpershoek
2023-08-22 18:41 ` [PATCH V4 6/8] arm: dts: Add k3-am625-beagleplay Nishanth Menon
2023-08-23  8:26   ` Mattijs Korpershoek
2023-08-22 18:41 ` [PATCH V4 7/8] board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file Nishanth Menon
2023-08-23  8:29   ` Mattijs Korpershoek
2023-08-23 14:42   ` Tom Rini
2023-08-22 18:41 ` [PATCH V4 8/8] doc: board: ti: Add BeaglePlay documentation Nishanth Menon
2023-08-23  8:36   ` Mattijs Korpershoek
2023-08-23 15:30   ` Simon Glass
2023-08-23 17:15     ` Tom Rini
2023-08-23 23:57       ` Simon Glass
2023-08-24  0:18         ` Nishanth Menon
2023-08-24  3:01           ` Simon Glass
2023-08-24  3:27             ` Nishanth Menon
2023-08-24  8:21               ` Mattijs Korpershoek
2023-08-24 12:07                 ` Nishanth Menon
2023-08-24 13:16               ` Neha Malcom Francis
2023-08-24 14:20                 ` Tom Rini
2023-08-24 14:41                   ` Simon Glass
2023-08-24 14:43                     ` Tom Rini
2023-08-24 14:46                       ` Simon Glass
2023-08-25 14:17                         ` Neha Malcom Francis
2023-08-24 14:16               ` Tom Rini
2023-08-25  1:04   ` Simon Glass
2023-08-25  1:22     ` Nishanth Menon
2023-08-25  1:31       ` Simon Glass
2023-08-25  1:59         ` Nishanth Menon
2023-08-25 23:45           ` Simon Glass
2023-08-26  1:06             ` Robert Nelson
2023-08-26  2:04               ` Simon Glass
2023-08-28 13:01                 ` Nishanth Menon
2023-08-23  7:44 ` [PATCH V4 0/8] board: ti: Add support for BeaglePlay Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230822184135.2328409-5-nm@ti.com \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=jan.kiszka@siemens.com \
    --cc=mkorpershoek@baylibre.com \
    --cc=n-francis@ti.com \
    --cc=n-yadav@ti.com \
    --cc=praneeth@ti.com \
    --cc=robertcnelson@gmail.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox