From: "Milan P. Stanić" <mps@arvanta.net>
To: Shengyu Qu <wiagn233@outlook.com>
Cc: xypron.glpk@gmx.de, chanho61.park@samsung.com,
ycliang@andestech.com, yanhong.wang@starfivetech.com,
u-boot@lists.denx.de
Subject: Re: [PATCH v1 1/2] configs: starfive: Enable PCIE auto enum and NVME/USB stuff for Starfive Visionfive 2
Date: Wed, 23 Aug 2023 22:38:38 +0200 [thread overview]
Message-ID: <20230823203838.GA21828@m1> (raw)
In-Reply-To: <TY3P286MB2611C9AD6E5BB3756A959E89981FA@TY3P286MB2611.JPNP286.PROD.OUTLOOK.COM>
On Tue, 2023-08-22 at 22:33, Shengyu Qu wrote:
> Although PCIE driver already exists, board defconfig isn't configured to
> enable PCIE enum on boot, thus USB storage device and NVME drive are not
> supported by default. So modify defconfig to enable PCIE auto enum, then
> start USB subsystem and scan nvme drive on boot.
>
> Signed-off-by: Shengyu Qu <wiagn233@outlook.com>
Tested-by: Milan P. Stanić <mps@arvanta.net>
> ---
> configs/starfive_visionfive2_defconfig | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/configs/starfive_visionfive2_defconfig b/configs/starfive_visionfive2_defconfig
> index e9b63e5b84..3002c96f0e 100644
> --- a/configs/starfive_visionfive2_defconfig
> +++ b/configs/starfive_visionfive2_defconfig
> @@ -30,6 +30,7 @@ CONFIG_SPL_SPI=y
> CONFIG_SYS_LOAD_ADDR=0x82000000
> CONFIG_SYS_PCI_64BIT=y
> CONFIG_PCI=y
> +CONFIG_PCI_INIT_R=y
> CONFIG_TARGET_STARFIVE_VISIONFIVE2=y
> CONFIG_SPL_OPENSBI_LOAD_ADDR=0x40000000
> CONFIG_ARCH_RV64I=y
> @@ -43,7 +44,7 @@ CONFIG_SD_BOOT=y
> CONFIG_USE_BOOTARGS=y
> CONFIG_BOOTARGS="console=ttyS0,115200 debug rootwait earlycon=sbi"
> CONFIG_USE_PREBOOT=y
> -CONFIG_PREBOOT="setenv fdt_addr ${fdtcontroladdr};fdt addr ${fdtcontroladdr};"
> +CONFIG_PREBOOT="nvme scan; usb start; setenv fdt_addr ${fdtcontroladdr}; fdt addr ${fdtcontroladdr};"
> CONFIG_DEFAULT_FDT_FILE="starfive/jh7110-starfive-visionfive-2.dtb"
> CONFIG_DISPLAY_CPUINFO=y
> CONFIG_DISPLAY_BOARDINFO=y
> @@ -124,4 +125,9 @@ CONFIG_TIMER_EARLY=y
> CONFIG_USB=y
> CONFIG_USB_XHCI_HCD=y
> CONFIG_USB_XHCI_PCI=y
> +CONFIG_USB_EHCI_HCD=y
> +CONFIG_USB_EHCI_PCI=y
> +CONFIG_USB_OHCI_HCD=y
> +CONFIG_USB_OHCI_PCI=y
> +CONFIG_USB_STORAGE=y
> CONFIG_USB_KEYBOARD=y
> --
> 2.42.0
>
next prev parent reply other threads:[~2023-08-23 20:38 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230822143357.2818-1-wiagn233@outlook.com>
2023-08-22 14:33 ` [PATCH v1 1/2] configs: starfive: Enable PCIE auto enum and NVME/USB stuff for Starfive Visionfive 2 Shengyu Qu
2023-08-23 20:38 ` Milan P. Stanić [this message]
2023-09-05 5:58 ` Dennis Gilmore
2023-08-22 14:33 ` [PATCH v1 2/2] doc: board: starfive: Add more info about supported driver Shengyu Qu
2023-08-23 20:39 ` Milan P. Stanić
2023-09-05 5:58 ` Dennis Gilmore
2023-09-05 6:46 ` Heinrich Schuchardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230823203838.GA21828@m1 \
--to=mps@arvanta.net \
--cc=chanho61.park@samsung.com \
--cc=u-boot@lists.denx.de \
--cc=wiagn233@outlook.com \
--cc=xypron.glpk@gmx.de \
--cc=yanhong.wang@starfivetech.com \
--cc=ycliang@andestech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox