public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Neha Francis <n-francis@ti.com>, Tom Rini <trini@konsulko.com>,
	Simon Glass <sjg@google.com>
Cc: Bryan <bb@ti.com>, Praneeth <praneeth@ti.com>,
	Andrew <afd@ti.com>, Robert Nelson <robertcnelson@gmail.com>,
	Vignesh <vigneshr@ti.com>, <u-boot@lists.denx.de>,
	Mattijs Korpershoek <mkorpershoek@baylibre.com>,
	Jan Kiszka <jan.kiszka@siemens.com>, Nishanth Menon <nm@ti.com>
Subject: [PATCH V6 12/20] arm: mach-k3: am625_init: Use IS_ENABLED()
Date: Fri, 25 Aug 2023 13:02:57 -0500	[thread overview]
Message-ID: <20230825180305.69515-13-nm@ti.com> (raw)
In-Reply-To: <20230825180305.69515-1-nm@ti.com>

Drop the #ifdeffery and use IS_ENABLED() inline check and let the compiler
do it's thing.

Reviewed-by: Tom Rini <trini@konsulko.com>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Tested-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Signed-off-by: Nishanth Menon <nm@ti.com>
---
No change other than picking up reviews, tested tags along the way.
V5: https://lore.kernel.org/r/20230824031101.3460411-11-nm@ti.com
 arch/arm/mach-k3/am625_init.c | 35 +++++++++++++++++------------------
 1 file changed, 17 insertions(+), 18 deletions(-)

diff --git a/arch/arm/mach-k3/am625_init.c b/arch/arm/mach-k3/am625_init.c
index 0e5d44269ebf..165bca6885ef 100644
--- a/arch/arm/mach-k3/am625_init.c
+++ b/arch/arm/mach-k3/am625_init.c
@@ -121,10 +121,10 @@ void board_init_f(ulong dummy)
 	struct udevice *dev;
 	int ret;
 
-#if defined(CONFIG_CPU_V7R)
-	setup_k3_mpu_regions();
-	rtc_erratumi2327_init();
-#endif
+	if (IS_ENABLED(CONFIG_CPU_V7R)) {
+		setup_k3_mpu_regions();
+		rtc_erratumi2327_init();
+	}
 
 	/*
 	 * Cannot delay this further as there is a chance that
@@ -156,29 +156,28 @@ void board_init_f(ulong dummy)
 
 	preloader_console_init();
 
-#ifdef CONFIG_K3_EARLY_CONS
 	/*
 	 * Allow establishing an early console as required for example when
 	 * doing a UART-based boot. Note that this console may not "survive"
 	 * through a SYSFW PM-init step and will need a re-init in some way
 	 * due to changing module clock frequencies.
 	 */
-	early_console_init();
-#endif
+	if (IS_ENABLED(CONFIG_K3_EARLY_CONS))
+		early_console_init();
 
-#if defined(CONFIG_K3_LOAD_SYSFW)
 	/*
 	 * Configure and start up system controller firmware. Provide
 	 * the U-Boot console init function to the SYSFW post-PM configuration
 	 * callback hook, effectively switching on (or over) the console
 	 * output.
 	 */
-	ret = is_rom_loaded_sysfw(&bootdata);
-	if (!ret)
-		panic("ROM has not loaded TIFS firmware\n");
+	if (IS_ENABLED(CONFIG_K3_LOAD_SYSFW)) {
+		ret = is_rom_loaded_sysfw(&bootdata);
+		if (!ret)
+			panic("ROM has not loaded TIFS firmware\n");
 
-	k3_sysfw_loader(true, NULL, NULL);
-#endif
+		k3_sysfw_loader(true, NULL, NULL);
+	}
 
 	/*
 	 * Force probe of clk_k3 driver here to ensure basic default clock
@@ -209,11 +208,11 @@ void board_init_f(ulong dummy)
 		enable_mcu_esm_reset();
 	}
 
-#if defined(CONFIG_K3_AM64_DDRSS)
-	ret = uclass_get_device(UCLASS_RAM, 0, &dev);
-	if (ret)
-		panic("DRAM init failed: %d\n", ret);
-#endif
+	if (IS_ENABLED(CONFIG_K3_AM64_DDRSS)) {
+		ret = uclass_get_device(UCLASS_RAM, 0, &dev);
+		if (ret)
+			panic("DRAM init failed: %d\n", ret);
+	}
 	spl_enable_dcache();
 }
 
-- 
2.40.0


  parent reply	other threads:[~2023-08-25 18:04 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25 18:02 [PATCH V6 00/20] board: ti: Add support for BeaglePlay Nishanth Menon
2023-08-25 18:02 ` [PATCH V6 01/20] include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before proceeding Nishanth Menon
2023-08-25 21:51   ` Tom Rini
2023-08-28 15:18   ` Mattijs Korpershoek
2023-09-09 13:30   ` Tom Rini
2023-08-25 18:02 ` [PATCH V6 02/20] include: env: ti: mmc: envboot: Only attempt boot.scr if BOOTSTD is not enabled Nishanth Menon
2023-08-25 21:51   ` Tom Rini
2023-08-28 15:25   ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 03/20] include: configs: ti_armv7_common: Add documentation for protected section Nishanth Menon
2023-08-25 18:02 ` [PATCH V6 04/20] include: configs: am62x_evm: Drop unused SDRAM address Nishanth Menon
2023-08-28 15:27   ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 05/20] include: configs: am62x_evm: Wrap distroboot with CONFIG_DISTRO_DEFAULTS Nishanth Menon
2023-08-28 15:27   ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 06/20] board: ti: am62x: am62x.env: Add explicit boot_targets Nishanth Menon
2023-08-28 15:28   ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd Nishanth Menon
2023-08-25 21:51   ` Tom Rini
2023-08-28 15:28   ` Mattijs Korpershoek
2024-02-17  3:11   ` Alexander Sverdlin
2024-02-17  8:42     ` Jan Kiszka
2024-02-17 11:36       ` Alexander Sverdlin
2024-02-19 18:37         ` Jan Kiszka
2024-02-20  7:48           ` Jan Kiszka
2024-02-20 12:47             ` Nishanth Menon
2024-02-20 12:50           ` Nishanth Menon
2024-02-21  9:10           ` Francesco Dolcini
2024-02-21  9:19             ` Jan Kiszka
2023-08-25 18:02 ` [PATCH V6 08/20] include: configs: am62x_evm: Drop distro_bootcmd usage Nishanth Menon
2023-08-28 15:30   ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 09/20] include: env: ti: ti_armv7_common.env: Rename to ti_common.env Nishanth Menon
2023-08-25 18:02 ` [PATCH V6 10/20] include: env: ti: Add a generic default_findfdt.env Nishanth Menon
2023-08-25 21:52   ` Tom Rini
2023-08-28 15:32   ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 11/20] board: ti: am62x: am62x.env: Use default findfdt Nishanth Menon
2023-08-28 15:33   ` Mattijs Korpershoek
2023-08-25 18:02 ` Nishanth Menon [this message]
2023-08-25 18:02 ` [PATCH V6 13/20] arm: mach-k3: am625_init: Convert rtc_erratumi2327_init to static Nishanth Menon
2023-08-25 18:02 ` [PATCH V6 14/20] configs: am62x_evm*: Enable EMMC_BOOT configuration Nishanth Menon
2023-08-25 18:03 ` [PATCH V6 15/20] arm: mach-k3: am625: Add support for UDA FS Nishanth Menon
2023-08-25 18:03 ` [PATCH V6 16/20] configs: am62x_evm_a53_defconfig: Disable semi-functional PSCI reset support Nishanth Menon
2023-08-28 15:34   ` Mattijs Korpershoek
2023-08-25 18:03 ` [PATCH V6 17/20] arm: dts: k3-am625-sk-binman: Add labels for unsigned binary Nishanth Menon
2023-08-25 18:03 ` [PATCH V6 18/20] arm: dts: Add k3-am625-beagleplay Nishanth Menon
2023-08-25 18:03 ` [PATCH V6 19/20] board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file Nishanth Menon
2023-08-25 21:52   ` Tom Rini
2023-08-25 18:03 ` [PATCH V6 20/20] doc: board: ti: Add BeaglePlay documentation Nishanth Menon
2023-08-28 15:18 ` [PATCH V6 00/20] board: ti: Add support for BeaglePlay Mattijs Korpershoek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230825180305.69515-13-nm@ti.com \
    --to=nm@ti.com \
    --cc=afd@ti.com \
    --cc=bb@ti.com \
    --cc=jan.kiszka@siemens.com \
    --cc=mkorpershoek@baylibre.com \
    --cc=n-francis@ti.com \
    --cc=praneeth@ti.com \
    --cc=robertcnelson@gmail.com \
    --cc=sjg@google.com \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox