From: Nishanth Menon <nm@ti.com>
To: Neha Francis <n-francis@ti.com>, Tom Rini <trini@konsulko.com>,
Simon Glass <sjg@google.com>
Cc: Bryan <bb@ti.com>, Praneeth <praneeth@ti.com>,
Andrew <afd@ti.com>, Robert Nelson <robertcnelson@gmail.com>,
Vignesh <vigneshr@ti.com>, <u-boot@lists.denx.de>,
Mattijs Korpershoek <mkorpershoek@baylibre.com>,
Jan Kiszka <jan.kiszka@siemens.com>, Nishanth Menon <nm@ti.com>
Subject: [PATCH V6 01/20] include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before proceeding
Date: Fri, 25 Aug 2023 13:02:46 -0500 [thread overview]
Message-ID: <20230825180305.69515-2-nm@ti.com> (raw)
In-Reply-To: <20230825180305.69515-1-nm@ti.com>
If mmc dev reports that the device is not present, there is no point in
proceeding further to attempt to load the files.
Signed-off-by: Nishanth Menon <nm@ti.com>
---
new patch - noticed a series of 'MMC: no card present' in boot log
and was wondering why, now I know - shaves off 2 seconds or so into boot
process.
include/env/ti/mmc.env | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/include/env/ti/mmc.env b/include/env/ti/mmc.env
index 6fb47fb26673..b8eb51ca1744 100644
--- a/include/env/ti/mmc.env
+++ b/include/env/ti/mmc.env
@@ -15,7 +15,7 @@ loadbootenv=fatload mmc ${mmcdev} ${loadaddr} ${bootenvfile}
loadimage=load ${devtype} ${bootpart} ${loadaddr} ${bootdir}/${bootfile}
loadfdt=load ${devtype} ${bootpart} ${fdtaddr} ${bootdir}/dtb/${fdtfile}
get_fdt_mmc=load mmc ${bootpart} ${fdtaddr} ${bootdir}/dtb/${name_fdt}
-envboot=mmc dev ${mmcdev};
+envboot=if mmc dev ${mmcdev}; then
if mmc rescan; then
echo SD/MMC found on device ${mmcdev};
if run loadbootscript; then
@@ -31,6 +31,7 @@ envboot=mmc dev ${mmcdev};
fi;
fi;
fi;
+ fi;
mmcloados=
if test ${boot_fdt} = yes || test ${boot_fdt} = try; then
if run get_fdt_mmc; then
@@ -45,7 +46,7 @@ mmcloados=
else
bootz;
fi;
-mmcboot=mmc dev ${mmcdev};
+mmcboot=if mmc dev ${mmcdev}; then
devnum=${mmcdev};
devtype=mmc;
if mmc rescan; then
@@ -58,7 +59,8 @@ mmcboot=mmc dev ${mmcdev};
run mmcloados;
fi;
fi;
-fi;
+ fi;
+ fi;
init_mmc=run args_all args_mmc
get_overlay_mmc=
--
2.40.0
next prev parent reply other threads:[~2023-08-25 18:06 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 18:02 [PATCH V6 00/20] board: ti: Add support for BeaglePlay Nishanth Menon
2023-08-25 18:02 ` Nishanth Menon [this message]
2023-08-25 21:51 ` [PATCH V6 01/20] include: env: ti: mmc: envboot/mmcboot: Check result of mmc dev before proceeding Tom Rini
2023-08-28 15:18 ` Mattijs Korpershoek
2023-09-09 13:30 ` Tom Rini
2023-08-25 18:02 ` [PATCH V6 02/20] include: env: ti: mmc: envboot: Only attempt boot.scr if BOOTSTD is not enabled Nishanth Menon
2023-08-25 21:51 ` Tom Rini
2023-08-28 15:25 ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 03/20] include: configs: ti_armv7_common: Add documentation for protected section Nishanth Menon
2023-08-25 18:02 ` [PATCH V6 04/20] include: configs: am62x_evm: Drop unused SDRAM address Nishanth Menon
2023-08-28 15:27 ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 05/20] include: configs: am62x_evm: Wrap distroboot with CONFIG_DISTRO_DEFAULTS Nishanth Menon
2023-08-28 15:27 ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 06/20] board: ti: am62x: am62x.env: Add explicit boot_targets Nishanth Menon
2023-08-28 15:28 ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 07/20] configs: am62x_evm_a53_defconfig: Switch to bootstd Nishanth Menon
2023-08-25 21:51 ` Tom Rini
2023-08-28 15:28 ` Mattijs Korpershoek
2024-02-17 3:11 ` Alexander Sverdlin
2024-02-17 8:42 ` Jan Kiszka
2024-02-17 11:36 ` Alexander Sverdlin
2024-02-19 18:37 ` Jan Kiszka
2024-02-20 7:48 ` Jan Kiszka
2024-02-20 12:47 ` Nishanth Menon
2024-02-20 12:50 ` Nishanth Menon
2024-02-21 9:10 ` Francesco Dolcini
2024-02-21 9:19 ` Jan Kiszka
2023-08-25 18:02 ` [PATCH V6 08/20] include: configs: am62x_evm: Drop distro_bootcmd usage Nishanth Menon
2023-08-28 15:30 ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 09/20] include: env: ti: ti_armv7_common.env: Rename to ti_common.env Nishanth Menon
2023-08-25 18:02 ` [PATCH V6 10/20] include: env: ti: Add a generic default_findfdt.env Nishanth Menon
2023-08-25 21:52 ` Tom Rini
2023-08-28 15:32 ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 11/20] board: ti: am62x: am62x.env: Use default findfdt Nishanth Menon
2023-08-28 15:33 ` Mattijs Korpershoek
2023-08-25 18:02 ` [PATCH V6 12/20] arm: mach-k3: am625_init: Use IS_ENABLED() Nishanth Menon
2023-08-25 18:02 ` [PATCH V6 13/20] arm: mach-k3: am625_init: Convert rtc_erratumi2327_init to static Nishanth Menon
2023-08-25 18:02 ` [PATCH V6 14/20] configs: am62x_evm*: Enable EMMC_BOOT configuration Nishanth Menon
2023-08-25 18:03 ` [PATCH V6 15/20] arm: mach-k3: am625: Add support for UDA FS Nishanth Menon
2023-08-25 18:03 ` [PATCH V6 16/20] configs: am62x_evm_a53_defconfig: Disable semi-functional PSCI reset support Nishanth Menon
2023-08-28 15:34 ` Mattijs Korpershoek
2023-08-25 18:03 ` [PATCH V6 17/20] arm: dts: k3-am625-sk-binman: Add labels for unsigned binary Nishanth Menon
2023-08-25 18:03 ` [PATCH V6 18/20] arm: dts: Add k3-am625-beagleplay Nishanth Menon
2023-08-25 18:03 ` [PATCH V6 19/20] board: ti: am62x: Add am62x_beagleplay_* defconfigs and env file Nishanth Menon
2023-08-25 21:52 ` Tom Rini
2023-08-25 18:03 ` [PATCH V6 20/20] doc: board: ti: Add BeaglePlay documentation Nishanth Menon
2023-08-28 15:18 ` [PATCH V6 00/20] board: ti: Add support for BeaglePlay Mattijs Korpershoek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230825180305.69515-2-nm@ti.com \
--to=nm@ti.com \
--cc=afd@ti.com \
--cc=bb@ti.com \
--cc=jan.kiszka@siemens.com \
--cc=mkorpershoek@baylibre.com \
--cc=n-francis@ti.com \
--cc=praneeth@ti.com \
--cc=robertcnelson@gmail.com \
--cc=sjg@google.com \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox