Re: [PATCH v2 4/4] dm: core: Modify default for OFNODE_MULTI_TREE

Simon Glass
2023-08-31T02:50:13Z

On Tue, 29 Aug 2023 at 14:37, <seanedmond@linux.microsoft.com> wrote:
>
> From: Sean Edmond <seanedmond@microsoft.com>
>
> There is a preference to use the "ofnode" API for FDT fixups
> moving forward. The FDT fixup will usually be for the kernel FDT. To
> fixup the kernel FDT with the ofnode API, it's required to set the
> OFNODE_MULTI_TREE option.
>
> To ensure existing users of kaslr fdt fixup are not impacted, Let's modify
> the default value for OFNODE_MULTI_TREE to ensure it's always set if
> !OF_LIVE. This will cause a 1007 byte increase in the code size.

Interestingly, this option is not needed if we can pass the control
DTB to Linux, But at least for now, we don't know that a priori.

>
> Signed-off-by: Sean Edmond <seanedmond@microsoft.com>
> ---
> drivers/core/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
> index f0d848f45d..38e44ef6fc 100644
> --- a/drivers/core/Kconfig
> +++ b/drivers/core/Kconfig
> @@ -424,7 +424,7 @@ config DM_DEV_READ_INLINE
>
> config OFNODE_MULTI_TREE
> bool "Allow the ofnode interface to access any tree"
> - default y if EVENT && !DM_DEV_READ_INLINE && !DM_INLINE_OFNODE
> + default y if !OF_LIVE
> help
> Normally U-Boot makes use of its control FDT, the one used to bind
> devices and provide options. In some cases, U-Boot must also process
> --
> 2.40.0
>

Regards,
Simon