[PATCH] ARM: imx: Drop CONFIG_USE_BOOTCOMMAND=n on i.MX6 DHSOM

[PATCH] ARM: imx: Drop CONFIG_USE_BOOTCOMMAND=n on i.MX6 DHSOM

[Marek Vasut]

This board certainly does use default 'run distro_bootcmd' boot command,
make sure this is set in 'bootcmd' variable.

Fixes: 970bf8603b8 ("Convert CONFIG_USE_BOOTCOMMAND et al to Kconfig")
Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Andreas Geisreiter <ageisreiter@dh-electronics.de>
Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: u-boot@dh-electronics.com
---
 configs/dh_imx6_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configs/dh_imx6_defconfig b/configs/dh_imx6_defconfig
index c3f2782f748..79e86330002 100644
--- a/configs/dh_imx6_defconfig
+++ b/configs/dh_imx6_defconfig
@@ -37,7 +37,6 @@ CONFIG_FIT_VERBOSE=y
 CONFIG_SPL_FIT=y
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=3
-# CONFIG_USE_BOOTCOMMAND is not set
 CONFIG_SYS_CONSOLE_OVERWRITE_ROUTINE=y
 CONFIG_SYS_SPL_MALLOC=y
 CONFIG_SPL_SPI_LOAD=y
-- 
2.40.1

Re: [PATCH] ARM: imx: Drop CONFIG_USE_BOOTCOMMAND=n on i.MX6 DHSOM

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

On Tue, Jul 25, 2023 at 05:24:43PM +0200, Marek Vasut wrote:

> This board certainly does use default 'run distro_bootcmd' boot command,
> make sure this is set in 'bootcmd' variable.
> 
> Fixes: 970bf8603b8 ("Convert CONFIG_USE_BOOTCOMMAND et al to Kconfig")
> Signed-off-by: Marek Vasut <marex@denx.de>

This is also:

Fixes: fa2c14676c7c ("configs: Re-sync with CONFIG_DISTRO_DEFAULTS")

As that's where we set CONFIG_USE_BOOTCOMMAND=n but missed that
include/configs/dh_imx6.h was defining CONFIG_BOOTCOMMAND to the default
distro bootcmd.  Doing a step back in time to that commit I see that
this was the only case where a platform was in fact setting
CONFIG_BOOTCOMMAND to "run distro_boot" instead of something custom.

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

[PATCH] ARM: imx: Drop CONFIG_USE_BOOTCOMMAND=n on i.MX6 DHSOM

[sbabic]

> This board certainly does use default 'run distro_bootcmd' boot command,
> make sure this is set in 'bootcmd' variable.
> Fixes: 970bf8603b8 ("Convert CONFIG_USE_BOOTCOMMAND et al to Kconfig")
> Signed-off-by: Marek Vasut <marex@denx.de>
> Reviewed-by: Tom Rini <trini@konsulko.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================